summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorwolfbeast <mcwerewolf@wolfbeast.com>2019-06-28 19:47:49 +0200
committerwolfbeast <mcwerewolf@wolfbeast.com>2019-06-28 19:57:38 +0200
commit32e6b0f4711cd65ec513f3f3aa64779293b458be (patch)
tree9c7ec87c9a6778f8ca6c036e8f3e4058a0a0485b
parentb9acf529ef9d0007214950e5d81f03236b200acf (diff)
downloadUXP-32e6b0f4711cd65ec513f3f3aa64779293b458be.tar
UXP-32e6b0f4711cd65ec513f3f3aa64779293b458be.tar.gz
UXP-32e6b0f4711cd65ec513f3f3aa64779293b458be.tar.lz
UXP-32e6b0f4711cd65ec513f3f3aa64779293b458be.tar.xz
UXP-32e6b0f4711cd65ec513f3f3aa64779293b458be.zip
Revert "Treat *.jnlp as an executable class file, like *.jar"
Rationale: This was a Mozilla oversight and/or error. This change has caused harm and is causing users to switch back to Chrome, Safari or Edge for their WebStart needs. JNLP is not an executable and should not be treated as such. JNLP should be treated the same as any (e.g. Word) document and allowed to be opened with the designated program. A JNLP file will not cause execution on a system unless it has a valid signature, and the user explicitly authorizes the launching based on information provided by the signature. Moreover, there will even be a check by the Java environment to see if the Java runtime (if there is one) is current, and prompt the user to update if required. This reverts commit 21495c58976e3cbbfe54d2e54d1fd67e36dff2a6 and modifies ApplicationReputation.cpp to keep the list in sync (was a discrepancy before).
-rw-r--r--toolkit/components/downloads/ApplicationReputation.cpp2
-rw-r--r--xpcom/io/nsLocalFileWin.cpp1
2 files changed, 1 insertions, 2 deletions
diff --git a/toolkit/components/downloads/ApplicationReputation.cpp b/toolkit/components/downloads/ApplicationReputation.cpp
index 9fdc8a103..6adefbb8b 100644
--- a/toolkit/components/downloads/ApplicationReputation.cpp
+++ b/toolkit/components/downloads/ApplicationReputation.cpp
@@ -467,7 +467,7 @@ static const char16_t* kBinaryFileExtensions[] = {
u".isp", // IIS config
//u".isu", // InstallShield
u".jar", // Java
- u".jnlp", // Java
+ //u".jnlp", // Java
//u".job", // Windows
u".js", // JavaScript script
u".jse", // JScript
diff --git a/xpcom/io/nsLocalFileWin.cpp b/xpcom/io/nsLocalFileWin.cpp
index 23c283f95..e73e15950 100644
--- a/xpcom/io/nsLocalFileWin.cpp
+++ b/xpcom/io/nsLocalFileWin.cpp
@@ -3034,7 +3034,6 @@ nsLocalFile::IsExecutable(bool* aResult)
"ins",
"isp",
"jar", // java application bundle
- "jnlp", // java web start
"js",
"jse",
"lnk",