summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorwin7-7 <win7-7@users.noreply.github.com>2019-05-25 18:02:40 +0300
committerGitHub <noreply@github.com>2019-05-25 18:02:40 +0300
commit733f6b770fcd7c2e5577bfb1fc738dc6ae5c3920 (patch)
treeb50e469d3e4d8e0074138e197cdaa6456d72b10c
parent915ffc660053cc48153c00dec66b913517dba794 (diff)
downloadUXP-733f6b770fcd7c2e5577bfb1fc738dc6ae5c3920.tar
UXP-733f6b770fcd7c2e5577bfb1fc738dc6ae5c3920.tar.gz
UXP-733f6b770fcd7c2e5577bfb1fc738dc6ae5c3920.tar.lz
UXP-733f6b770fcd7c2e5577bfb1fc738dc6ae5c3920.tar.xz
UXP-733f6b770fcd7c2e5577bfb1fc738dc6ae5c3920.zip
use memcmp for nsIAtom Equals to improve performance xpcom/ds
issue #1113 Use memcmp and not slower string Equals in nsHtml5Portability::localEqualsBuffer
-rw-r--r--xpcom/ds/nsAtomTable.cpp8
-rw-r--r--xpcom/ds/nsIAtom.idl10
2 files changed, 9 insertions, 9 deletions
diff --git a/xpcom/ds/nsAtomTable.cpp b/xpcom/ds/nsAtomTable.cpp
index 4c93625ae..c2e77e31f 100644
--- a/xpcom/ds/nsAtomTable.cpp
+++ b/xpcom/ds/nsAtomTable.cpp
@@ -325,13 +325,7 @@ AtomTableMatchKey(const PLDHashEntryHdr* aEntry, const void* aKey)
nsDependentAtomString(he->mAtom)) == 0;
}
- uint32_t length = he->mAtom->GetLength();
- if (length != k->mLength) {
- return false;
- }
-
- return memcmp(he->mAtom->GetUTF16String(),
- k->mUTF16String, length * sizeof(char16_t)) == 0;
+ return he->mAtom->Equals(k->mUTF16String, k->mLength);
}
static void
diff --git a/xpcom/ds/nsIAtom.idl b/xpcom/ds/nsIAtom.idl
index 6e8602c42..ce4cff485 100644
--- a/xpcom/ds/nsIAtom.idl
+++ b/xpcom/ds/nsIAtom.idl
@@ -37,9 +37,15 @@ interface nsIAtom : nsISupports
size_t SizeOfIncludingThis(in MallocSizeOf aMallocSizeOf);
%{C++
- // note this is NOT virtual so this won't muck with the vtable!
+ // note these are NOT virtual so they won't muck with the vtable!
+ inline bool Equals(char16ptr_t aString, uint32_t aLength) const
+ {
+ return mLength == aLength &&
+ memcmp(mString, aString, mLength * sizeof(char16_t)) == 0;
+ }
+
inline bool Equals(const nsAString& aString) const {
- return aString.Equals(nsDependentString(mString, mLength));
+ return Equals(aString.BeginReading(), aString.Length());
}
inline bool IsStaticAtom() const {