summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMoonchild <moonchild@palemoon.org>2020-07-09 16:01:42 +0000
committerMoonchild <moonchild@palemoon.org>2020-07-10 18:33:01 +0000
commit407c503fa4f7a57f89195421eb004d3028013105 (patch)
tree064a93586b286e2f788a579ff06424f6de55046d
parent9130f129063dac30bef4c16dde56289fd889a3ae (diff)
downloadUXP-407c503fa4f7a57f89195421eb004d3028013105.tar
UXP-407c503fa4f7a57f89195421eb004d3028013105.tar.gz
UXP-407c503fa4f7a57f89195421eb004d3028013105.tar.lz
UXP-407c503fa4f7a57f89195421eb004d3028013105.tar.xz
UXP-407c503fa4f7a57f89195421eb004d3028013105.zip
[js] Improve readability and control flow of js date string parser.
-rwxr-xr-xjs/src/jsdate.cpp19
1 files changed, 16 insertions, 3 deletions
diff --git a/js/src/jsdate.cpp b/js/src/jsdate.cpp
index c6a369e2d..41722ffa9 100755
--- a/js/src/jsdate.cpp
+++ b/js/src/jsdate.cpp
@@ -21,6 +21,8 @@
#include "mozilla/FloatingPoint.h"
#include "mozilla/Sprintf.h"
+#include "nsCRT.h"
+
#include <ctype.h>
#include <math.h>
#include <string.h>
@@ -958,11 +960,20 @@ ParseDate(const CharT* s, size_t length, ClippedTime* result)
while (i < length) {
int c = s[i];
i++;
- if (c <= ' ' || c == ',' || c == '-') {
- if (c == '-' && '0' <= s[i] && s[i] <= '9')
+
+ // Spaces, ASCII control characters, and commas are ignored.
+ if (c <= ' ' || c == ',')
+ continue;
+
+ // Dashes are delimiters if they're immediately followed by a number field.
+ // If they're not followed by a number field, they're simply ignored.
+ if (c == '-') {
+ if (i < length && nsCRT::IsAsciiDigit(s[i])) {
prevc = c;
+ }
continue;
}
+
if (c == '(') { /* comments) */
int depth = 1;
while (i < length) {
@@ -977,7 +988,9 @@ ParseDate(const CharT* s, size_t length, ClippedTime* result)
}
continue;
}
- if ('0' <= c && c <= '9') {
+
+ // Parse a number field.
+ if (nsCRT::IsAsciiDigit(c)) {
int n = c - '0';
while (i < length && '0' <= (c = s[i]) && c <= '9') {
n = n * 10 + c - '0';