diff options
| author | Moonchild <mcwerewolf@gmail.com> | 2018-05-04 22:48:10 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-05-04 22:48:10 +0200 |
| commit | db33886e27daf66313cc77f6425f3fd784266651 (patch) | |
| tree | 55d68bf49ac0870683f5556081a4a9a05e76aab6 | |
| parent | 3b28e26d02106c31e3e2a03098ca24ea3f7e9f5d (diff) | |
| parent | 32949bf64bb7aa166913af6b91969788b403c847 (diff) | |
| download | UXP-db33886e27daf66313cc77f6425f3fd784266651.tar UXP-db33886e27daf66313cc77f6425f3fd784266651.tar.gz UXP-db33886e27daf66313cc77f6425f3fd784266651.tar.lz UXP-db33886e27daf66313cc77f6425f3fd784266651.tar.xz UXP-db33886e27daf66313cc77f6425f3fd784266651.zip | |
Merge pull request #330 from JustOff/PR_PMkit_empty_getElementById
[PMkit] Fix Empty string passed to getElementById() warning in buttons.js
| -rw-r--r-- | toolkit/jetpack/sdk/ui/buttons.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/toolkit/jetpack/sdk/ui/buttons.js b/toolkit/jetpack/sdk/ui/buttons.js index 66e0fd742..6aaed3865 100644 --- a/toolkit/jetpack/sdk/ui/buttons.js +++ b/toolkit/jetpack/sdk/ui/buttons.js @@ -50,7 +50,7 @@ function insertButton(aWindow, id, onBuild) { let toolbar = toolbarId != "" && doc.getElementById(toolbarId); if (toolbar) { - let nextItem = doc.getElementById(nextItemId); + let nextItem = nextItemId != "" && doc.getElementById(nextItemId); // If nextItem not in toolbar then retrieve it by reading currentset attribute if (!(nextItem && nextItem.parentNode && nextItem.parentNode.id == toolbarId)) { nextItem = null; |