summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMoonchild <mcwerewolf@gmail.com>2018-02-04 19:50:46 +0100
committerGitHub <noreply@github.com>2018-02-04 19:50:46 +0100
commitc0dfa1fdaa3f1135504d81507f61b3fd8dfd25e0 (patch)
treecfd55eadedcd6450ab13bfc69510ef5713eb6fd2
parentc1855eae91646bd3092660ffe193ad36d8b61287 (diff)
parent69ee28ad18c791c63de13e43c41c6794d188e8dc (diff)
downloadUXP-c0dfa1fdaa3f1135504d81507f61b3fd8dfd25e0.tar
UXP-c0dfa1fdaa3f1135504d81507f61b3fd8dfd25e0.tar.gz
UXP-c0dfa1fdaa3f1135504d81507f61b3fd8dfd25e0.tar.lz
UXP-c0dfa1fdaa3f1135504d81507f61b3fd8dfd25e0.tar.xz
UXP-c0dfa1fdaa3f1135504d81507f61b3fd8dfd25e0.zip
Merge pull request #5 from janekptacijarabaci/devtools_inspector_markupView_1
Markup View: show an ellipsis character in collapsed nodes
-rw-r--r--devtools/client/inspector/markup/views/markup-container.js2
-rw-r--r--devtools/client/themes/markup.css19
2 files changed, 20 insertions, 1 deletions
diff --git a/devtools/client/inspector/markup/views/markup-container.js b/devtools/client/inspector/markup/views/markup-container.js
index b54157242..44768b46c 100644
--- a/devtools/client/inspector/markup/views/markup-container.js
+++ b/devtools/client/inspector/markup/views/markup-container.js
@@ -211,10 +211,12 @@ MarkupContainer.prototype = {
}
if (this.showExpander) {
+ this.elt.classList.add("expandable");
this.expander.style.visibility = "visible";
// Update accessibility expanded state.
this.tagLine.setAttribute("aria-expanded", this.expanded);
} else {
+ this.elt.classList.remove("expandable");
this.expander.style.visibility = "hidden";
// No need for accessible expanded state indicator when expander is not
// shown.
diff --git a/devtools/client/themes/markup.css b/devtools/client/themes/markup.css
index 4b4cfd031..0569b7ce7 100644
--- a/devtools/client/themes/markup.css
+++ b/devtools/client/themes/markup.css
@@ -197,6 +197,22 @@ ul.children + .tag-line::before {
display: inline;
}
+.expandable.collapsed .close::before {
+ /* Display an ellipsis character in collapsed nodes that can be expanded. */
+ content: "\2026";
+ display: inline-block;
+ width: 12px;
+ height: 8px;
+ margin: 0 2px;
+ line-height: 3px;
+ color: var(--theme-body-color-inactive);
+ border-radius: 3px;
+ border-style: solid;
+ border-width: 1px;
+ text-align: center;
+ vertical-align: middle;
+}
+
/* Hide HTML void elements (img, hr, br, …) closing tag when the element is not
* expanded (it can be if it has pseudo-elements attached) */
.child.collapsed > .tag-line .void-element .close {
@@ -318,7 +334,8 @@ ul.children + .tag-line::before {
.theme-selected ~ .editor .theme-fg-color4,
.theme-selected ~ .editor .theme-fg-color5,
.theme-selected ~ .editor .theme-fg-color6,
-.theme-selected ~ .editor .theme-fg-color7 {
+.theme-selected ~ .editor .theme-fg-color7,
+.theme-selected ~ .editor .close::before {
color: var(--theme-selection-color);
}