From e1e1d99102936b419aac52974f1fdb8be835b0d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= Date: Sun, 30 Mar 2014 12:26:24 +0200 Subject: Fix java checker crash, some memory leaks --- logic/lists/JavaVersionList.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'logic/lists') diff --git a/logic/lists/JavaVersionList.cpp b/logic/lists/JavaVersionList.cpp index eb1c5650..4fd0bc19 100644 --- a/logic/lists/JavaVersionList.cpp +++ b/logic/lists/JavaVersionList.cpp @@ -160,7 +160,7 @@ void JavaVersionList::sort() // NO-OP for now } -JavaListLoadTask::JavaListLoadTask(JavaVersionList *vlist) +JavaListLoadTask::JavaListLoadTask(JavaVersionList *vlist) : Task() { m_list = vlist; m_currentRecommended = NULL; @@ -207,7 +207,6 @@ void JavaListLoadTask::checkerProgress(int current, int total) void JavaListLoadTask::javaCheckerFinished(QList results) { QList candidates; - m_job.reset(); QLOG_DEBUG() << "Found the following valid Java installations:"; for(JavaCheckResult result : results) @@ -226,14 +225,14 @@ void JavaListLoadTask::javaCheckerFinished(QList results) } QList javas_bvp; - for (auto &java : candidates) + for (auto java : candidates) { //QLOG_INFO() << java->id << java->arch << " at " << java->path; BaseVersionPtr bp_java = std::dynamic_pointer_cast(java); if (bp_java) { - javas_bvp.append(bp_java); + javas_bvp.append(java); } } -- cgit v1.2.3