From c1b6f42551f0d324f7649c78b33ba7086e2b4905 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= Date: Sun, 2 Nov 2014 11:13:18 +0100 Subject: Also block other java-related env vars, for good measure "JAVA_ARGS" "CLASSPATH" "CONFIGPATH" "JAVA_HOME" "JRE_HOME" --- logic/MinecraftProcess.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'logic/MinecraftProcess.cpp') diff --git a/logic/MinecraftProcess.cpp b/logic/MinecraftProcess.cpp index 71bf34c7..e1264abf 100644 --- a/logic/MinecraftProcess.cpp +++ b/logic/MinecraftProcess.cpp @@ -44,9 +44,17 @@ MinecraftProcess::MinecraftProcess(InstancePtr inst) : m_instance(inst) QProcessEnvironment rawenv = QProcessEnvironment::systemEnvironment(); QProcessEnvironment env; + + QStringList ignored = {"JAVA_ARGS", "CLASSPATH", "CONFIGPATH", "JAVA_HOME", "JRE_HOME"}; for(auto key: rawenv.keys()) { auto value = rawenv.value(key); + // filter out dangerous java crap + if(ignored.contains(key)) + { + QLOG_INFO() << "Env: ignoring" << key << value; + continue; + } // filter MultiMC-related things if(key.startsWith("QT_")) { -- cgit v1.2.3