From 98e17998fe4dd541143de3e1bbc4b267aadb383b Mon Sep 17 00:00:00 2001 From: Tim Flynn Date: Mon, 16 Jan 2017 16:42:22 -0500 Subject: GH-1065 Normalize usage of directory vs folder --- application/MultiMC.cpp | 4 ++-- application/pages/InstanceSettingsPage.ui | 15 +++------------ application/pages/global/ExternalToolsPage.cpp | 4 ++-- application/pages/global/JavaPage.ui | 13 ++----------- application/pages/global/MultiMCPage.cpp | 12 ++++++------ 5 files changed, 15 insertions(+), 33 deletions(-) (limited to 'application') diff --git a/application/MultiMC.cpp b/application/MultiMC.cpp index 8e924d98..6c0c4e5e 100644 --- a/application/MultiMC.cpp +++ b/application/MultiMC.cpp @@ -140,7 +140,7 @@ MultiMC::MultiMC(int &argc, char **argv) : QApplication(argc, argv) // --dir parser.addOption("dir", applicationDirPath()); parser.addShortOpt("dir", 'd'); - parser.addDocumentation("dir", "use the supplied directory as MultiMC root instead of " + parser.addDocumentation("dir", "use the supplied folder as MultiMC root instead of " "the binary location (use '.' for current)"); // --launch parser.addOption("launch"); @@ -188,7 +188,7 @@ MultiMC::MultiMC(int &argc, char **argv) : QApplication(argc, argv) QString binPath = applicationDirPath(); QString adjustedBy; QString dataPath; - // change directory + // change folder QString dirParam = args["dir"].toString(); if (!dirParam.isEmpty()) { diff --git a/application/pages/InstanceSettingsPage.ui b/application/pages/InstanceSettingsPage.ui index 4a17aa78..adc5a84f 100644 --- a/application/pages/InstanceSettingsPage.ui +++ b/application/pages/InstanceSettingsPage.ui @@ -11,16 +11,7 @@ - - 0 - - - 0 - - - 0 - - + 0 @@ -29,7 +20,7 @@ QTabWidget::Rounded - 0 + 2 @@ -413,7 +404,7 @@ - <html><head/><body><p>Pre-launch command runs before the instance launches and post-exit command runs after it exits.</p><p>Both will be run in MultiMC's working directory with extra environment variables:</p><ul style="margin-top: 0px; margin-bottom: 0px; margin-left: 0px; margin-right: 0px; -qt-list-indent: 1;"><li style=" margin-top:12px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">INST_NAME - Name of the instance</li><li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">INST_ID - ID of the instance</li><li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">INST_DIR - absolute path of the instance</li><li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">INST_MC_DIR - absolute path of minecraft</li><li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">INST_JAVA - java binary used for launch</li><li style=" margin-top:0px; margin-bottom:12px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">INST_JAVA_ARGS - command-line parameters used for launch</li></ul></body></html> + <html><head/><body><p>Pre-launch command runs before the instance launches and post-exit command runs after it exits.</p><p>Both will be run in MultiMC's working folder with extra environment variables:</p><ul style="margin-top: 0px; margin-bottom: 0px; margin-left: 0px; margin-right: 0px; -qt-list-indent: 1;"><li style=" margin-top:12px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">INST_NAME - Name of the instance</li><li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">INST_ID - ID of the instance</li><li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">INST_DIR - absolute path of the instance</li><li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">INST_MC_DIR - absolute path of minecraft</li><li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">INST_JAVA - java binary used for launch</li><li style=" margin-top:0px; margin-bottom:12px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">INST_JAVA_ARGS - command-line parameters used for launch</li></ul></body></html> Qt::AlignLeading|Qt::AlignLeft|Qt::AlignTop diff --git a/application/pages/global/ExternalToolsPage.cpp b/application/pages/global/ExternalToolsPage.cpp index 88540f7e..71de159a 100644 --- a/application/pages/global/ExternalToolsPage.cpp +++ b/application/pages/global/ExternalToolsPage.cpp @@ -86,7 +86,7 @@ void ExternalToolsPage::on_jprofilerPathBtn_clicked() QString error; do { - raw_dir = QFileDialog::getExistingDirectory(this, tr("JProfiler Directory"), raw_dir); + raw_dir = QFileDialog::getExistingDirectory(this, tr("JProfiler Folder"), raw_dir); if (raw_dir.isEmpty()) { break; @@ -164,7 +164,7 @@ void ExternalToolsPage::on_mceditPathBtn_clicked() #warning stuff raw_dir = QFileDialog::getOpenFileName(this, tr("MCEdit Application"), raw_dir); #else - raw_dir = QFileDialog::getExistingDirectory(this, tr("MCEdit Directory"), raw_dir); + raw_dir = QFileDialog::getExistingDirectory(this, tr("MCEdit Folder"), raw_dir); #endif if (raw_dir.isEmpty()) { diff --git a/application/pages/global/JavaPage.ui b/application/pages/global/JavaPage.ui index ba873d34..9023b932 100644 --- a/application/pages/global/JavaPage.ui +++ b/application/pages/global/JavaPage.ui @@ -17,16 +17,7 @@ - - 0 - - - 0 - - - 0 - - + 0 @@ -273,7 +264,7 @@ - <html><head/><body><p>Pre-launch command runs before the instance launches and post-exit command runs after it exits. Both will be run in MultiMC's working directory with INST_ID, INST_DIR, and INST_NAME as environment variables.</p><p>Wrapper command allows running java using an extra wrapper program (like 'optirun' on Linux)</p></body></html> + <html><head/><body><p>Pre-launch command runs before the instance launches and post-exit command runs after it exits. Both will be run in MultiMC's working folder with INST_ID, INST_DIR, and INST_NAME as environment variables.</p><p>Wrapper command allows running java using an extra wrapper program (like 'optirun' on Linux)</p></body></html> Qt::AlignLeading|Qt::AlignLeft|Qt::AlignTop diff --git a/application/pages/global/MultiMCPage.cpp b/application/pages/global/MultiMCPage.cpp index de28b58e..728f2dde 100644 --- a/application/pages/global/MultiMCPage.cpp +++ b/application/pages/global/MultiMCPage.cpp @@ -99,7 +99,7 @@ bool MultiMCPage::apply() void MultiMCPage::on_ftbLauncherBrowseBtn_clicked() { - QString raw_dir = QFileDialog::getExistingDirectory(this, tr("FTB Launcher Directory"), + QString raw_dir = QFileDialog::getExistingDirectory(this, tr("FTB Launcher Folder"), ui->ftbLauncherBox->text()); QString cooked_dir = FS::NormalizePath(raw_dir); @@ -112,7 +112,7 @@ void MultiMCPage::on_ftbLauncherBrowseBtn_clicked() void MultiMCPage::on_ftbBrowseBtn_clicked() { QString raw_dir = - QFileDialog::getExistingDirectory(this, tr("FTB Directory"), ui->ftbBox->text()); + QFileDialog::getExistingDirectory(this, tr("FTB Folder"), ui->ftbBox->text()); QString cooked_dir = FS::NormalizePath(raw_dir); // do not allow current dir - it's dirty. Do not allow dirs that don't exist @@ -124,7 +124,7 @@ void MultiMCPage::on_ftbBrowseBtn_clicked() void MultiMCPage::on_instDirBrowseBtn_clicked() { - QString raw_dir = QFileDialog::getExistingDirectory(this, tr("Instance Directory"), + QString raw_dir = QFileDialog::getExistingDirectory(this, tr("Instance Folder"), ui->instDirTextBox->text()); QString cooked_dir = FS::NormalizePath(raw_dir); @@ -157,7 +157,7 @@ void MultiMCPage::on_instDirBrowseBtn_clicked() void MultiMCPage::on_iconsDirBrowseBtn_clicked() { - QString raw_dir = QFileDialog::getExistingDirectory(this, tr("Icons Directory"), + QString raw_dir = QFileDialog::getExistingDirectory(this, tr("Icons Folder"), ui->iconsDirTextBox->text()); QString cooked_dir = FS::NormalizePath(raw_dir); @@ -169,7 +169,7 @@ void MultiMCPage::on_iconsDirBrowseBtn_clicked() } void MultiMCPage::on_modsDirBrowseBtn_clicked() { - QString raw_dir = QFileDialog::getExistingDirectory(this, tr("Mods Directory"), + QString raw_dir = QFileDialog::getExistingDirectory(this, tr("Mods Folder"), ui->modsDirTextBox->text()); QString cooked_dir = FS::NormalizePath(raw_dir); @@ -181,7 +181,7 @@ void MultiMCPage::on_modsDirBrowseBtn_clicked() } void MultiMCPage::on_lwjglDirBrowseBtn_clicked() { - QString raw_dir = QFileDialog::getExistingDirectory(this, tr("LWJGL Directory"), + QString raw_dir = QFileDialog::getExistingDirectory(this, tr("LWJGL Folder"), ui->lwjglDirTextBox->text()); QString cooked_dir = FS::NormalizePath(raw_dir); -- cgit v1.2.3