From 7fe94ca7b4aa191b1e79331b16724b7e9cc9f56e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= Date: Thu, 28 Jun 2018 23:18:45 +0200 Subject: NOISSUE fix all sorts of warnings, enable `Werror` and `pedantic` --- application/VersionProxyModel.cpp | 2 +- application/pages/BasePageProvider.h | 1 + application/setupwizard/AnalyticsWizardPage.h | 2 +- application/setupwizard/JavaWizardPage.h | 2 +- application/setupwizard/LanguageWizardPage.h | 2 +- 5 files changed, 5 insertions(+), 4 deletions(-) (limited to 'application') diff --git a/application/VersionProxyModel.cpp b/application/VersionProxyModel.cpp index d59fceee..990b949e 100644 --- a/application/VersionProxyModel.cpp +++ b/application/VersionProxyModel.cpp @@ -227,7 +227,7 @@ QVariant VersionProxyModel::data(const QModelIndex &index, int role) const return QVariant(); } } -}; +} QModelIndex VersionProxyModel::parent(const QModelIndex &child) const { diff --git a/application/pages/BasePageProvider.h b/application/pages/BasePageProvider.h index 1cc7458a..05c38d23 100644 --- a/application/pages/BasePageProvider.h +++ b/application/pages/BasePageProvider.h @@ -34,6 +34,7 @@ public: : m_dialogTitle(dialogTitle) { } + virtual ~GenericPageProvider() {} QList getPages() override { diff --git a/application/setupwizard/AnalyticsWizardPage.h b/application/setupwizard/AnalyticsWizardPage.h index 03de9cb0..0234f02a 100644 --- a/application/setupwizard/AnalyticsWizardPage.h +++ b/application/setupwizard/AnalyticsWizardPage.h @@ -8,7 +8,7 @@ class QCheckBox; class AnalyticsWizardPage : public BaseWizardPage { - Q_OBJECT; + Q_OBJECT public: explicit AnalyticsWizardPage(QWidget *parent = Q_NULLPTR); virtual ~AnalyticsWizardPage(); diff --git a/application/setupwizard/JavaWizardPage.h b/application/setupwizard/JavaWizardPage.h index 4ea31d24..592fa24c 100644 --- a/application/setupwizard/JavaWizardPage.h +++ b/application/setupwizard/JavaWizardPage.h @@ -6,7 +6,7 @@ class JavaSettingsWidget; class JavaWizardPage : public BaseWizardPage { - Q_OBJECT; + Q_OBJECT public: explicit JavaWizardPage(QWidget *parent = Q_NULLPTR); diff --git a/application/setupwizard/LanguageWizardPage.h b/application/setupwizard/LanguageWizardPage.h index 8b55d57f..5a9e882d 100644 --- a/application/setupwizard/LanguageWizardPage.h +++ b/application/setupwizard/LanguageWizardPage.h @@ -7,7 +7,7 @@ class QListView; class LanguageWizardPage : public BaseWizardPage { - Q_OBJECT; + Q_OBJECT public: explicit LanguageWizardPage(QWidget *parent = Q_NULLPTR); -- cgit v1.2.3