From 722896d41f15a8bc78a864f7adcfd0527648073c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= Date: Mon, 5 Dec 2016 02:29:08 +0100 Subject: NOISSUE Translations model and initial setup wizard work --- application/CMakeLists.txt | 3 - application/MainWindow.cpp | 79 +-------- application/MainWindow.h | 6 +- application/MultiMC.cpp | 70 +++----- application/MultiMC.h | 12 +- application/setupwizard/SetupWizard.cpp | 259 +++++++++++++++++++++++++++- application/setupwizard/SetupWizard.h | 11 +- application/setupwizard/SetupWizard.ui | 289 -------------------------------- 8 files changed, 300 insertions(+), 429 deletions(-) delete mode 100644 application/setupwizard/SetupWizard.ui (limited to 'application') diff --git a/application/CMakeLists.txt b/application/CMakeLists.txt index 2198e815..e51e6eb1 100644 --- a/application/CMakeLists.txt +++ b/application/CMakeLists.txt @@ -302,9 +302,6 @@ SET(MULTIMC_UIS # Widgets/other widgets/MCModInfoFrame.ui - - # The Setup Wizard - setupwizard/SetupWizard.ui ) set(MULTIMC_QRCS diff --git a/application/MainWindow.cpp b/application/MainWindow.cpp index 094eecd7..3bbe7eec 100644 --- a/application/MainWindow.cpp +++ b/application/MainWindow.cpp @@ -1429,6 +1429,15 @@ void MainWindow::closeEvent(QCloseEvent *event) QApplication::exit(); } +void MainWindow::changeEvent(QEvent* event) +{ + if (event->type() == QEvent::LanguageChange) + { + ui->retranslateUi(this); + } + QMainWindow::changeEvent(event); +} + void MainWindow::instanceActivated(QModelIndex index) { if (!index.isValid()) @@ -1552,76 +1561,6 @@ void MainWindow::selectionBad() setSelectedInstanceById(MMC->settings()->get("SelectedInstance").toString()); } -void MainWindow::checkSetDefaultJava() -{ - const QString javaHack = "IntelHack"; - bool askForJava = false; - do - { - QString currentHostName = QHostInfo::localHostName(); - QString oldHostName = MMC->settings()->get("LastHostname").toString(); - if (currentHostName != oldHostName) - { - MMC->settings()->set("LastHostname", currentHostName); - askForJava = true; - break; - } - QString currentJavaPath = MMC->settings()->get("JavaPath").toString(); - QString actualPath = FS::ResolveExecutable(currentJavaPath); - if (currentJavaPath.isNull()) - { - askForJava = true; - break; - } -#if defined Q_OS_WIN32 - QString currentHack = MMC->settings()->get("JavaDetectionHack").toString(); - if (currentHack != javaHack) - { - CustomMessageBox::selectable(this, tr("Java detection forced"), tr("Because of graphics performance issues caused by Intel drivers on Windows, " - "MultiMC java detection was forced. Please select a Java " - "version.

If you have custom java versions set for your instances, " - "make sure you use the 'javaw.exe' executable."), - QMessageBox::Warning) - ->exec(); - askForJava = true; - break; - } -#endif - } while (0); - - if (askForJava) - { - qDebug() << "Java path needs resetting, showing Java selection dialog..."; - - JavaInstallPtr java; - - VersionSelectDialog vselect(MMC->javalist().get(), tr("Select a Java version"), this, false); - vselect.setResizeOn(2); - vselect.exec(); - - if (vselect.selectedVersion()) - java = std::dynamic_pointer_cast(vselect.selectedVersion()); - else - { - CustomMessageBox::selectable(this, tr("Invalid version selected"), tr("You didn't select a valid Java version, so MultiMC will " - "select the default. " - "You can change this in the settings dialog."), - QMessageBox::Warning) - ->show(); - - JavaUtils ju; - java = ju.GetDefaultJava(); - } - if (java) - { - MMC->settings()->set("JavaPath", java->path); - MMC->settings()->set("JavaDetectionHack", javaHack); - } - else - MMC->settings()->set("JavaPath", QString("java")); - } -} - void MainWindow::checkInstancePathForProblems() { QString instanceFolder = MMC->settings()->get("InstanceDir").toString(); diff --git a/application/MainWindow.h b/application/MainWindow.h index 459c17c2..535d1163 100644 --- a/application/MainWindow.h +++ b/application/MainWindow.h @@ -48,10 +48,10 @@ public: explicit MainWindow(QWidget *parent = 0); ~MainWindow(); - virtual bool eventFilter(QObject *obj, QEvent *ev) override; - virtual void closeEvent(QCloseEvent *event) override; + bool eventFilter(QObject *obj, QEvent *ev) override; + void closeEvent(QCloseEvent *event) override; + void changeEvent(QEvent * event) override; - void checkSetDefaultJava(); void checkInstancePathForProblems(); private slots: diff --git a/application/MultiMC.cpp b/application/MultiMC.cpp index f176a64b..346c1882 100644 --- a/application/MultiMC.cpp +++ b/application/MultiMC.cpp @@ -58,7 +58,7 @@ #include "settings/INISettingsObject.h" #include "settings/Setting.h" -#include "trans/TranslationDownloader.h" +#include "translations/TranslationsModel.h" #include "minecraft/ftb/FTBPlugin.h" @@ -289,8 +289,6 @@ MultiMC::MultiMC(int &argc, char **argv) : QApplication(argc, argv) m_updateChecker.reset(new UpdateChecker(BuildConfig.CHANLIST_URL, BuildConfig.VERSION_CHANNEL, BuildConfig.VERSION_BUILD)); } - m_translationChecker.reset(new TranslationDownloader()); - initIcons(); initThemes(); // make sure we have at least some minecraft versions before we init instances @@ -299,7 +297,8 @@ MultiMC::MultiMC(int &argc, char **argv) : QApplication(argc, argv) initAccounts(); initNetwork(); - m_translationChecker->downloadTranslations(); + // now we have network, download translation updates + m_translations->downloadIndex(); //FIXME: what to do with these? m_profilers.insert("jprofiler", std::shared_ptr(new JProfilerFactory())); @@ -347,14 +346,6 @@ MultiMC::MultiMC(int &argc, char **argv) : QApplication(argc, argv) MultiMC::~MultiMC() { - if (m_mmc_translator) - { - removeTranslator(m_mmc_translator.get()); - } - if (m_qt_translator) - { - removeTranslator(m_qt_translator.get()); - } #if defined Q_OS_WIN32 if(consoleAttached) { @@ -415,43 +406,10 @@ void MultiMC::initNetwork() void MultiMC::initTranslations() { + m_translations.reset(new TranslationsModel("translations")); auto bcp47Name = m_settings->get("Language").toString(); - QLocale locale(bcp47Name); - QLocale::setDefault(locale); + m_translations->selectLanguage(bcp47Name); qDebug() << "Your language is" << bcp47Name; - // FIXME: this is likely never present. - m_qt_translator.reset(new QTranslator()); - if (m_qt_translator->load("qt_" + bcp47Name, - QLibraryInfo::location(QLibraryInfo::TranslationsPath))) - { - qDebug() << "Loading Qt Language File for" - << bcp47Name.toLocal8Bit().constData() << "..."; - if (!installTranslator(m_qt_translator.get())) - { - qCritical() << "Loading Qt Language File failed."; - m_qt_translator.reset(); - } - } - else - { - m_qt_translator.reset(); - } - - m_mmc_translator.reset(new QTranslator()); - if (m_mmc_translator->load("mmc_" + bcp47Name, FS::PathCombine(QDir::currentPath(), "translations"))) - { - qDebug() << "Loading MMC Language File for" - << bcp47Name.toLocal8Bit().constData() << "..."; - if (!installTranslator(m_mmc_translator.get())) - { - qCritical() << "Loading MMC Language File failed."; - m_mmc_translator.reset(); - } - } - else - { - m_mmc_translator.reset(); - } } void MultiMC::initIcons() @@ -520,6 +478,7 @@ void MultiMC::shutdownLogger() void MultiMC::initAnalytics() { + const int analyticsVersion = 1; if(BuildConfig.ANALYTICS_ID.isEmpty()) { return; @@ -535,11 +494,16 @@ void MultiMC::initAnalytics() clientID.remove(QLatin1Char('}')); m_settings->set("AnalyticsClientID", clientID); } - m_analytics = new GAnalytics(BuildConfig.ANALYTICS_ID, clientID, this); + m_analytics = new GAnalytics(BuildConfig.ANALYTICS_ID, clientID, analyticsVersion, this); m_analytics->setLogLevel(GAnalytics::Debug); m_analytics->setAnonymizeIPs(true); m_analytics->setNetworkAccessManager(&ENV.qnam()); + if(m_settings->get("AnalyticsSeen").toInt() < m_analytics->version()) + { + qDebug() << "Analytics info not seen by user yet (or old version)."; + return; + } if(!m_settings->get("Analytics").toBool()) { qDebug() << "Analytics disabled by user."; @@ -659,7 +623,7 @@ void MultiMC::initGlobalSettings() m_settings->registerSetting("JsonEditor", QString()); // Language - m_settings->registerSetting("Language", QLocale(QLocale::system().language()).bcp47Name()); + m_settings->registerSetting("Language", QString()); // Console m_settings->registerSetting("ShowConsole", false); @@ -695,7 +659,6 @@ void MultiMC::initGlobalSettings() m_settings->registerSetting("JavaArchitecture", ""); m_settings->registerSetting("JavaVersion", ""); m_settings->registerSetting("LastHostname", ""); - m_settings->registerSetting("JavaDetectionHack", ""); m_settings->registerSetting("JvmArgs", ""); // Minecraft launch method @@ -735,6 +698,7 @@ void MultiMC::initGlobalSettings() { // Analytics m_settings->registerSetting("Analytics", true); + m_settings->registerSetting("AnalyticsSeen", 0); m_settings->registerSetting("AnalyticsClientID", QString()); } @@ -756,6 +720,11 @@ void MultiMC::initMCEdit() m_mcedit.reset(new MCEditTool(m_settings)); } +std::shared_ptr MultiMC::translations() +{ + return m_translations; +} + std::shared_ptr MultiMC::lwjgllist() { if (!m_lwjgllist) @@ -1013,7 +982,6 @@ MainWindow* MultiMC::showMainWindow(bool minimized) m_mainWindow->show(); } - m_mainWindow->checkSetDefaultJava(); m_mainWindow->checkInstancePathForProblems(); m_openWindows++; } diff --git a/application/MultiMC.h b/application/MultiMC.h index f166a30a..50074136 100644 --- a/application/MultiMC.h +++ b/application/MultiMC.h @@ -32,7 +32,7 @@ class JavaInstallList; class UpdateChecker; class BaseProfilerFactory; class BaseDetachedToolFactory; -class TranslationDownloader; +class TranslationsModel; class ITheme; class MCEditTool; class GAnalytics; @@ -58,6 +58,11 @@ public: MultiMC(int &argc, char **argv); virtual ~MultiMC(); + GAnalytics *analytics() const + { + return m_analytics; + } + std::shared_ptr settings() const { return m_settings; @@ -87,6 +92,7 @@ public: return m_updateChecker; } + std::shared_ptr translations(); std::shared_ptr minecraftlist(); std::shared_ptr lwjgllist(); std::shared_ptr forgelist(); @@ -183,8 +189,6 @@ private: private: QDateTime startTime; - std::shared_ptr m_qt_translator; - std::shared_ptr m_mmc_translator; std::shared_ptr m_settings; std::shared_ptr m_instances; FolderInstanceProvider * m_instanceFolder = nullptr; @@ -196,7 +200,7 @@ private: std::shared_ptr m_liteloaderlist; std::shared_ptr m_minecraftlist; std::shared_ptr m_javalist; - std::shared_ptr m_translationChecker; + std::shared_ptr m_translations; std::shared_ptr m_globalSettingsProvider; std::map> m_themes; std::unique_ptr m_mcedit; diff --git a/application/setupwizard/SetupWizard.cpp b/application/setupwizard/SetupWizard.cpp index b51b34a7..af6b8c8e 100644 --- a/application/setupwizard/SetupWizard.cpp +++ b/application/setupwizard/SetupWizard.cpp @@ -1,26 +1,273 @@ #include "SetupWizard.h" +#include "translations/TranslationsModel.h" +#include +#include +#include enum Page { Language, Java, Analytics, - Themes, - Accounts + // Themes, + // Accounts }; -#include "ui_SetupWizard.h" +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include -SetupWizard::SetupWizard(QWidget *parent):QWizard(parent), ui(new Ui::SetupWizard) +class BaseWizardPage : public QWizardPage { - ui->setupUi(this); +public: + explicit BaseWizardPage(QWidget *parent = Q_NULLPTR) + : QWizardPage(parent) + { + } + virtual ~BaseWizardPage() {}; + +protected: + virtual void retranslate() = 0; + void changeEvent(QEvent * event) override + { + if (event->type() == QEvent::LanguageChange) + { + retranslate(); + } + QWizardPage::changeEvent(event); + } +}; + +class LanguageWizardPage : public BaseWizardPage +{ + Q_OBJECT; +public: + explicit LanguageWizardPage(QWidget *parent = Q_NULLPTR) + : BaseWizardPage(parent) + { + setObjectName(QStringLiteral("languagePage")); + verticalLayout = new QVBoxLayout(this); + verticalLayout->setObjectName(QStringLiteral("verticalLayout")); + languageView = new QListView(this); + languageView->setObjectName(QStringLiteral("languageView")); + verticalLayout->addWidget(languageView); + retranslate(); + + auto translations = MMC->translations(); + auto index = translations->selectedIndex(); + languageView->setModel(translations.get()); + languageView->setCurrentIndex(index); + connect(languageView->selectionModel(), &QItemSelectionModel::currentRowChanged, this, &LanguageWizardPage::languageRowChanged); + } + virtual ~LanguageWizardPage() {}; + +protected: + void retranslate() override + { + setTitle(QApplication::translate("LanguageWizardPage", "Language", Q_NULLPTR)); + setSubTitle(QApplication::translate("LanguageWizardPage", "Select the language to use in MultiMC", Q_NULLPTR)); + } + +protected slots: + void languageRowChanged(const QModelIndex ¤t, const QModelIndex &previous) + { + if (current == previous) + { + return; + } + auto translations = MMC->translations(); + QString key = translations->data(current, Qt::UserRole).toString(); + translations->selectLanguage(key); + translations->updateLanguage(key); + } + +private: + QVBoxLayout *verticalLayout = nullptr; + QListView *languageView = nullptr; +}; + +class AnalyticsWizardPage : public BaseWizardPage +{ + Q_OBJECT; +public: + explicit AnalyticsWizardPage(QWidget *parent = Q_NULLPTR) + : BaseWizardPage(parent) + { + setObjectName(QStringLiteral("analyticsPage")); + verticalLayout_3 = new QVBoxLayout(this); + verticalLayout_3->setObjectName(QStringLiteral("verticalLayout_3")); + textBrowser = new QTextBrowser(this); + textBrowser->setObjectName(QStringLiteral("textBrowser")); + textBrowser->setAcceptRichText(false); + textBrowser->setOpenExternalLinks(true); + verticalLayout_3->addWidget(textBrowser); + + checkBox = new QCheckBox(this); + checkBox->setObjectName(QStringLiteral("checkBox")); + checkBox->setChecked(true); + verticalLayout_3->addWidget(checkBox); + retranslate(); + } + virtual ~AnalyticsWizardPage() {}; + +protected: + void retranslate() override + { + setTitle(QApplication::translate("AnalyticsWizardPage", "Analytics", Q_NULLPTR)); + setSubTitle(QApplication::translate("AnalyticsWizardPage", "We track some anonymous statistics about users.", Q_NULLPTR)); + textBrowser->setHtml(QApplication::translate("AnalyticsWizardPage", + "" + "

MultiMC sends anonymous usage statistics on every start of the application. This helps us decide what platforms and issues to focus on.

" + "

The data is processed by Google Analytics, see their article on the matter.

" + "

The following data is collected:

" + "
  • A random unique ID of the MultiMC installation.
    It is stored in the application settings (multimc.cfg).
  • " + "
  • Anonymized IP address.
    Last octet is set to 0 by Google and not stored.
  • " + "
  • MultiMC version.
  • " + "
  • Operating system name, version and architecture.
  • " + "
  • CPU architecture (kernel architecture on linux).
  • " + "
  • Size of system memory.
  • " + "
  • Java version, architecture and memory settings.
" + "

The analytics will activate on next start, unless you disable them in the settings.

" + "

If we change the tracked information, analytics won't be active for the first run and you will see this page again.

", Q_NULLPTR)); + checkBox->setText(QApplication::translate("AnalyticsWizardPage", "Enable Analytics", Q_NULLPTR)); + } +private: + QVBoxLayout *verticalLayout_3 = nullptr; + QTextBrowser *textBrowser = nullptr; + QCheckBox *checkBox = nullptr; +}; + +SetupWizard::SetupWizard(QWidget *parent) : QWizard(parent) +{ + setObjectName(QStringLiteral("SetupWizard")); + resize(615, 659); + setOptions(QWizard::NoCancelButton); + if (languageIsRequired()) + { + setPage(Page::Language, new LanguageWizardPage(this)); + } + if(javaIsRequired()) + { + // set up java selection + } + else + { + removePage(Page::Java); + } + if(analyticsIsRequired()) + { + setPage(Page::Analytics, new AnalyticsWizardPage(this)); + } +} + +void SetupWizard::retranslate() +{ + setButtonText(QWizard::NextButton, tr("Next >")); + setButtonText(QWizard::BackButton, tr("< Back")); + setButtonText(QWizard::FinishButton, tr("Finish")); + setWindowTitle(QApplication::translate("SetupWizard", "MultiMC Quick Setup", Q_NULLPTR)); +} + +void SetupWizard::changeEvent(QEvent *event) +{ + if (event->type() == QEvent::LanguageChange) + { + retranslate(); + } + QWizard::changeEvent(event); } SetupWizard::~SetupWizard() { } +bool SetupWizard::languageIsRequired() +{ + auto settings = MMC->settings(); + if (settings->get("Language").toString().isEmpty()) + return true; + return false; +} + +bool SetupWizard::javaIsRequired() +{ + QString currentHostName = QHostInfo::localHostName(); + QString oldHostName = MMC->settings()->get("LastHostname").toString(); + if (currentHostName != oldHostName) + { + MMC->settings()->set("LastHostname", currentHostName); + return true; + } + QString currentJavaPath = MMC->settings()->get("JavaPath").toString(); + QString actualPath = FS::ResolveExecutable(currentJavaPath); + if (actualPath.isNull()) + { + return true; + } + return false; +} + +bool SetupWizard::analyticsIsRequired() +{ + auto settings = MMC->settings(); + auto analytics = MMC->analytics(); + if(settings->get("AnalyticsSeen").toInt() < analytics->version()) + { + return true; + } + return false; +} + bool SetupWizard::isRequired() { - return true; + if (languageIsRequired()) + return true; + if (javaIsRequired()) + return true; + if (analyticsIsRequired()) + return true; + return false; } + +/* +void MainWindow::checkSetDefaultJava() +{ + qDebug() << "Java path needs resetting, showing Java selection dialog..."; + + JavaInstallPtr java; + + VersionSelectDialog vselect(MMC->javalist().get(), tr("Select a Java version"), this, false); + vselect.setResizeOn(2); + vselect.exec(); + + if (vselect.selectedVersion()) + java = std::dynamic_pointer_cast(vselect.selectedVersion()); + else + { + CustomMessageBox::selectable(this, tr("Invalid version selected"), tr("You didn't select a valid Java version, so MultiMC will " + "select the default. " + "You can change this in the settings dialog."), + QMessageBox::Warning) + ->show(); + + JavaUtils ju; + java = ju.GetDefaultJava(); + } + if (java) + { + MMC->settings()->set("JavaPath", java->path); + } + else + MMC->settings()->set("JavaPath", QString("java")); +} +*/ + +#include "SetupWizard.moc" diff --git a/application/setupwizard/SetupWizard.h b/application/setupwizard/SetupWizard.h index 5dbe90a9..e5c8ad77 100644 --- a/application/setupwizard/SetupWizard.h +++ b/application/setupwizard/SetupWizard.h @@ -30,10 +30,15 @@ public: /* con/destructors */ explicit SetupWizard(QWidget *parent = 0); virtual ~SetupWizard(); + void changeEvent(QEvent * event) override; + public: /* methods */ -static bool isRequired(); + static bool isRequired(); + static bool javaIsRequired(); + static bool languageIsRequired(); + static bool analyticsIsRequired(); -private: /* data */ - Ui::SetupWizard *ui = nullptr; +private: /* methods */ + void retranslate(); }; diff --git a/application/setupwizard/SetupWizard.ui b/application/setupwizard/SetupWizard.ui deleted file mode 100644 index a78f3530..00000000 --- a/application/setupwizard/SetupWizard.ui +++ /dev/null @@ -1,289 +0,0 @@ - - - SetupWizard - - - - 0 - 0 - 628 - 637 - - - - MultiMC Quick Setup - - - QWizard::NoCancelButton - - - - Welcome - - - Hello and welcome the quick setup wizard! - - - Page::Language - - - - - - <html><head/><body><p>Choose your <s>adventure</s> language:</p></body></html> - - - - - - - - - - - Java - - - Your java settings need attention! - - - Page::Java - - - - - - Java Runtime - - - - - - - - - - - - Memory - - - - - - The maximum amount of memory Minecraft is allowed to use. - - - MB - - - 512 - - - 65536 - - - 128 - - - 1024 - - - - - - - Minimum memory allocation: - - - - - - - Maximum memory allocation: - - - - - - - PermGen: - - - - - - - The amount of memory available to store loaded Java classes. - - - MB - - - 64 - - - 999999999 - - - 8 - - - 64 - - - - - - - The amount of memory Minecraft is started with. - - - MB - - - 256 - - - 65536 - - - 128 - - - 256 - - - - - - - - - - - Analytics - - - We track some anonymous statistics about users. - - - Page::Analytics - - - - - - Qt::ScrollBarAlwaysOff - - - QAbstractScrollArea::AdjustToContentsOnFirstShow - - - true - - - Qt::AlignLeading|Qt::AlignLeft|Qt::AlignTop - - - - - 0 - 0 - 592 - 477 - - - - - - - <html><head/><body> -<p>MultiMC sends anonymous usage statistics on every start of the application. This helps us decide what platforms and issues to focus on.</p> -<p>The data is processed by Google Analytics, see their <a href="https://support.google.com/analytics/answer/6004245?hl=en">article on the matter</a>.</p> -<p>The following data is collected:</p> -<ul> -<li>A random unique ID of the MultiMC installation.<br />It is stored in the application settings (multimc.cfg).</li> -<li>Anonymized IP address.<br />Last octet is set to 0 by Google and not stored.</li> -<li>MultiMC version.</li> -<li>Operating system name, version and architecture.</li> -<li>CPU architecture (kernel architecture on linux).</li> -<li>Size of system memory.</li> -<li>Java version, architecture and memory settings.</li> -</ul> -<p>The analytics will activate on next start, unless you disable them in the settings.</p> -<p>If we change the tracked information, analytics won't be active for the first run and you will see this page again.</p> -</body></html> - - - true - - - Qt::AlignLeading|Qt::AlignLeft|Qt::AlignTop - - - true - - - true - - - - - - - - - - - - Themes and icons - - - Change how things look. - - - Page::Themes - - - - - 230 - 70 - 151 - 71 - - - - Put stuff here. - - - - - - Minecraft accounts - - - Add your account - or accounts. - - - Page::Accounts - - - - - 60 - 60 - 311 - 131 - - - - Put existing accounts page here. - - - - - - - -- cgit v1.2.3