From a1abbd9e05c80584d831b1d12c27c5f7d731cece Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= Date: Sat, 28 May 2016 19:54:17 +0200 Subject: NOISSUE refactor *Download into more, smaller pieces * Download is now Download. * Download uses Sink subclasses to process various events. * Validators can be used to further customize the Sink behaviour. --- application/dialogs/UpdateDialog.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'application/dialogs/UpdateDialog.cpp') diff --git a/application/dialogs/UpdateDialog.cpp b/application/dialogs/UpdateDialog.cpp index 31220e50..6e109bcb 100644 --- a/application/dialogs/UpdateDialog.cpp +++ b/application/dialogs/UpdateDialog.cpp @@ -46,8 +46,7 @@ void UpdateDialog::loadChangelog() url = QString("https://api.github.com/repos/MultiMC/MultiMC5/compare/%1...%2").arg(BuildConfig.GIT_COMMIT, channel); m_changelogType = CHANGELOG_COMMITS; } - changelogDownload = ByteArrayDownload::make(QUrl(url)); - dljob->addNetAction(changelogDownload); + dljob->addNetAction(Net::Download::makeByteArray(QUrl(url), &changelogData)); connect(dljob.get(), &NetJob::succeeded, this, &UpdateDialog::changelogLoaded); connect(dljob.get(), &NetJob::failed, this, &UpdateDialog::changelogFailed); dljob->start(); @@ -201,12 +200,13 @@ void UpdateDialog::changelogLoaded() switch(m_changelogType) { case CHANGELOG_COMMITS: - result = reprocessCommits(changelogDownload->m_data); + result = reprocessCommits(changelogData); break; case CHANGELOG_MARKDOWN: - result = reprocessMarkdown(changelogDownload->m_data); + result = reprocessMarkdown(changelogData); break; } + changelogData.clear(); ui->changelogBrowser->setHtml(result); } -- cgit v1.2.3