From 6a525db78d2f3fd9deec817bfd3fc9c5162991c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= Date: Sat, 22 Apr 2017 00:29:24 +0200 Subject: NOISSUE 'required' attribute of curse manifests is optional, libraries attribute reading --- api/logic/minecraft/curse/PackManifest.cpp | 5 ++++- api/logic/minecraft/curse/PackManifest.h | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) (limited to 'api/logic') diff --git a/api/logic/minecraft/curse/PackManifest.cpp b/api/logic/minecraft/curse/PackManifest.cpp index fd40a37c..2fde8a01 100644 --- a/api/logic/minecraft/curse/PackManifest.cpp +++ b/api/logic/minecraft/curse/PackManifest.cpp @@ -5,7 +5,8 @@ static void loadFileV1(Curse::File & f, QJsonObject & file) { f.projectId = Json::requireInteger(file, "projectID"); f.fileId = Json::requireInteger(file, "fileID"); - f.required = Json::requireBoolean(file, "required"); + // FIXME: what does this mean? + f.required = Json::ensureBoolean(file, QString("required"), true); } static void loadModloaderV1(Curse::Modloader & m, QJsonObject & modLoader) @@ -17,6 +18,8 @@ static void loadModloaderV1(Curse::Modloader & m, QJsonObject & modLoader) static void loadMinecraftV1(Curse::Minecraft & m, QJsonObject & minecraft) { m.version = Json::requireString(minecraft, "version"); + // FIXME: default unknown, assuming empty. Meaning also unknown. + m.libraries = Json::ensureString(minecraft, QString("libraries"), QString()); auto arr = Json::ensureArray(minecraft, "modLoaders", QJsonArray()); for (const auto & item : arr) { diff --git a/api/logic/minecraft/curse/PackManifest.h b/api/logic/minecraft/curse/PackManifest.h index 8b9602a4..36e05cc2 100644 --- a/api/logic/minecraft/curse/PackManifest.h +++ b/api/logic/minecraft/curse/PackManifest.h @@ -26,6 +26,7 @@ struct Modloader struct Minecraft { QString version; + QString libraries; QVector modLoaders; }; -- cgit v1.2.3