From 36f3e24cf31cfe6fad413d70ab8ad187a5251fb7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Tue, 27 Jun 2017 04:32:53 +0200
Subject: NOISSUE remove some bad code in various Task related classes

---
 api/logic/java/JavaCheckerJob.h | 29 +++++------------------------
 1 file changed, 5 insertions(+), 24 deletions(-)

(limited to 'api/logic/java/JavaCheckerJob.h')

diff --git a/api/logic/java/JavaCheckerJob.h b/api/logic/java/JavaCheckerJob.h
index c27a50c3..dc035cb2 100644
--- a/api/logic/java/JavaCheckerJob.h
+++ b/api/logic/java/JavaCheckerJob.h
@@ -22,6 +22,7 @@
 class JavaCheckerJob;
 typedef std::shared_ptr<JavaCheckerJob> JavaCheckerJobPtr;
 
+// FIXME: this just seems horribly redundant
 class JavaCheckerJob : public Task
 {
 	Q_OBJECT
@@ -31,37 +32,19 @@ public:
 	bool addJavaCheckerAction(JavaCheckerPtr base)
 	{
 		javacheckers.append(base);
-		total_progress++;
 		// if this is already running, the action needs to be started right away!
 		if (isRunning())
 		{
-			setProgress(current_progress, total_progress);
-			connect(base.get(), SIGNAL(checkFinished(JavaCheckResult)), SLOT(partFinished(JavaCheckResult)));
-
+			setProgress(num_finished, javacheckers.size());
+			connect(base.get(), &JavaChecker::checkFinished, this, &JavaCheckerJob::partFinished);
 			base->performCheck();
 		}
 		return true;
 	}
-
-	JavaCheckerPtr operator[](int index)
-	{
-		return javacheckers[index];
-	}
-	;
-	JavaCheckerPtr first()
+	QList<JavaCheckResult> getResults()
 	{
-		if (javacheckers.size())
-			return javacheckers[0];
-		return JavaCheckerPtr();
+		return javaresults;
 	}
-	int size() const
-	{
-		return javacheckers.size();
-	}
-
-signals:
-	void started();
-	void finished(QList<JavaCheckResult>);
 
 private slots:
 	void partFinished(JavaCheckResult result);
@@ -73,7 +56,5 @@ private:
 	QString m_job_name;
 	QList<JavaCheckerPtr> javacheckers;
 	QList<JavaCheckResult> javaresults;
-	qint64 current_progress = 0;
-	qint64 total_progress = 0;
 	int num_finished = 0;
 };
-- 
cgit v1.2.3