From d80382180ef14d814eb9f6d7f2bf5db362f25cc2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= Date: Mon, 4 Sep 2017 08:17:25 +0200 Subject: NOISSUE refactor pack import (extraction and paths) It now: * Doesn't extract until it knows the content format is good. * Extracts in a predictable location, not requiring to use a second path for the actual pack root. --- api/logic/InstanceCreationTask.cpp | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) (limited to 'api/logic/InstanceCreationTask.cpp') diff --git a/api/logic/InstanceCreationTask.cpp b/api/logic/InstanceCreationTask.cpp index e7b0de7c..a615d6ff 100644 --- a/api/logic/InstanceCreationTask.cpp +++ b/api/logic/InstanceCreationTask.cpp @@ -20,14 +20,6 @@ InstanceCreationTask::InstanceCreationTask(SettingsObjectPtr settings, BaseInsta void InstanceCreationTask::executeTask() { setStatus(tr("Creating instance from version %1").arg(m_version->name())); - /* - auto minecraftVersion = std::dynamic_pointer_cast(m_version); - if(!minecraftVersion) - { - emitFailed(tr("The supplied version is not a Minecraft version.")); - return ; - } - */ QString stagingPath = m_target->getStagedInstancePath(); QDir rootDir(stagingPath); @@ -41,6 +33,6 @@ void InstanceCreationTask::executeTask() inst->setName(m_instName); inst->setIconKey(m_instIcon); inst->init(); - m_target->commitStagedInstance(stagingPath, stagingPath, m_instName, m_instGroup); + m_target->commitStagedInstance(stagingPath, m_instName, m_instGroup); emitSucceeded(); } -- cgit v1.2.3