From c0c7037e18a7b4539f219c5fd8de30021d66c6d4 Mon Sep 17 00:00:00 2001 From: Anthony Parrott Date: Thu, 28 Nov 2013 14:50:04 -0500 Subject: Could reach end of rulesFromJsonV4 method without returning a QList It was possible for execution to reach the end of the rulesFromJsonV4 method without returning. This was causing a crash on OS X when parsing rules inside an instance. --- logic/OneSixRule.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/logic/OneSixRule.cpp b/logic/OneSixRule.cpp index d35be720..392b1dd1 100644 --- a/logic/OneSixRule.cpp +++ b/logic/OneSixRule.cpp @@ -56,6 +56,7 @@ QList> rulesFromJsonV4(QJsonObject &objectWithRules) // add a new OS rule rules.append(OsRule::create(action, requiredOs, versionRegex)); } + return rules; } QJsonObject ImplicitRule::toJson() -- cgit v1.2.3