From 6f2a87167a13101d80d2fbc096bbb6a5eb5ab0c9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= Date: Sun, 26 Mar 2017 20:50:31 +0200 Subject: NOISSUE remove some dead code from version related classes --- api/logic/meta/Version.h | 6 ------ api/logic/minecraft/ProfilePatch.h | 10 ---------- api/logic/minecraft/VersionFile.h | 4 ---- api/logic/minecraft/onesix/OneSixProfileStrategy.cpp | 4 ---- 4 files changed, 24 deletions(-) diff --git a/api/logic/meta/Version.h b/api/logic/meta/Version.h index 1d921035..8aac8ea1 100644 --- a/api/logic/meta/Version.h +++ b/api/logic/meta/Version.h @@ -35,12 +35,6 @@ using VersionPtr = std::shared_ptr; class MULTIMC_LOGIC_EXPORT Version : public QObject, public BaseVersion, public BaseEntity { Q_OBJECT - Q_PROPERTY(QString uid READ uid CONSTANT) - Q_PROPERTY(QString parentUid READ parentUid) - Q_PROPERTY(QString version READ version CONSTANT) - Q_PROPERTY(QString type READ type NOTIFY typeChanged) - Q_PROPERTY(QDateTime time READ time NOTIFY timeChanged) - Q_PROPERTY(QHash requires READ requires NOTIFY requiresChanged) public: /* con/des */ explicit Version(const QString &uid, const QString &version); diff --git a/api/logic/minecraft/ProfilePatch.h b/api/logic/minecraft/ProfilePatch.h index 6f63f3c4..699a38ae 100644 --- a/api/logic/minecraft/ProfilePatch.h +++ b/api/logic/minecraft/ProfilePatch.h @@ -15,14 +15,6 @@ enum ProblemSeverity PROBLEM_ERROR }; -/// where is a version from? -enum class VersionSource -{ - Builtin, //!< version loaded from the internal resources. - Local, //!< version loaded from a file in the cache. - Remote, //!< incomplete version on a remote server. -}; - class PatchProblem { public: @@ -70,8 +62,6 @@ public: virtual QString getFilename() = 0; - virtual VersionSource getVersionSource() = 0; - virtual std::shared_ptr getVersionFile() = 0; virtual const QList& getProblems() diff --git a/api/logic/minecraft/VersionFile.h b/api/logic/minecraft/VersionFile.h index 6a922d74..dad9a057 100644 --- a/api/logic/minecraft/VersionFile.h +++ b/api/logic/minecraft/VersionFile.h @@ -53,10 +53,6 @@ public: /* methods */ { return m_releaseTime; } - VersionSource getVersionSource() override - { - return VersionSource::Local; - } std::shared_ptr getVersionFile() override { diff --git a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp index 3a9b10e6..3f33dd7f 100644 --- a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp +++ b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp @@ -125,10 +125,6 @@ public: { return 0; } - VersionSource getVersionSource() override - { - return VersionSource::Local; - } bool isVersionChangeable() override { return true; -- cgit v1.2.3