From 651bed91a0d6aff551fd6880a7cdbca403064c4f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= Date: Sun, 6 Oct 2013 03:47:41 +0200 Subject: Log failure reasons of cache downloads --- logic/net/CacheDownload.cpp | 2 +- logic/net/DownloadJob.cpp | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/logic/net/CacheDownload.cpp b/logic/net/CacheDownload.cpp index 0e653e05..6a76a4ae 100644 --- a/logic/net/CacheDownload.cpp +++ b/logic/net/CacheDownload.cpp @@ -56,7 +56,7 @@ void CacheDownload::downloadProgress(qint64 bytesReceived, qint64 bytesTotal) void CacheDownload::downloadError(QNetworkReply::NetworkError error) { // error happened during download. - // TODO: log the reason why + QLOG_ERROR() << "Failed" << m_url.toString() << "with reason" << error; m_status = Job_Failed; } void CacheDownload::downloadFinished() diff --git a/logic/net/DownloadJob.cpp b/logic/net/DownloadJob.cpp index f6275b7a..fa3e655e 100644 --- a/logic/net/DownloadJob.cpp +++ b/logic/net/DownloadJob.cpp @@ -54,18 +54,18 @@ void DownloadJob::partSucceeded(int index) partProgress(index, slot.total_progress, slot.total_progress); num_succeeded++; - QLOG_INFO() << m_job_name.toLocal8Bit() << " progress: " << num_succeeded << "/" + QLOG_INFO() << m_job_name.toLocal8Bit() << "progress:" << num_succeeded << "/" << downloads.size(); if (num_failed + num_succeeded == downloads.size()) { if (num_failed) { - QLOG_ERROR() << m_job_name.toLocal8Bit() << " failed."; + QLOG_ERROR() << m_job_name.toLocal8Bit() << "failed."; emit failed(); } else { - QLOG_INFO() << m_job_name.toLocal8Bit() << " succeeded."; + QLOG_INFO() << m_job_name.toLocal8Bit() << "succeeded."; emit succeeded(); } } @@ -76,17 +76,17 @@ void DownloadJob::partFailed(int index) auto &slot = parts_progress[index]; if (slot.failures == 3) { - QLOG_ERROR() << "Part " << index << " failed 3 times (" << downloads[index]->m_url << ")"; + QLOG_ERROR() << "Part" << index << "failed 3 times (" << downloads[index]->m_url << ")"; num_failed++; if (num_failed + num_succeeded == downloads.size()) { - QLOG_ERROR() << m_job_name.toLocal8Bit() << " failed."; + QLOG_ERROR() << m_job_name.toLocal8Bit() << "failed."; emit failed(); } } else { - QLOG_ERROR() << "Part " << index << " failed, restarting (" << downloads[index]->m_url + QLOG_ERROR() << "Part" << index << "failed, restarting (" << downloads[index]->m_url << ")"; // restart the job slot.failures++; -- cgit v1.2.3