Working 1.6 modding (currently only forge)

10 files changed, 124 insertions, 86 deletions

diff --git a/gui/IconPickerDialog.cpp b/gui/IconPickerDialog.cpp
index f3947d21..8f5d8256 100644
--- a/gui/IconPickerDialog.cpp
+++ b/gui/IconPickerDialog.cpp
@@ -39,7 +39,7 @@ IconPickerDialog::IconPickerDialog(QWidget *parent) :
 	
 	contentsWidget->installEventFilter(this);
 	
-	contentsWidget->setModel(MMC->icons());
+	contentsWidget->setModel(MMC->icons().data());
 	
 	auto buttonAdd = ui->buttonBox->addButton(tr("Add Icon"),QDialogButtonBox::ResetRole);
 	auto buttonRemove = ui->buttonBox->addButton(tr("Remove Icon"),QDialogButtonBox::ResetRole);
@@ -119,7 +119,7 @@ void IconPickerDialog::selectionChanged ( QItemSelection selected, QItemSelectio
 
 int IconPickerDialog::exec ( QString selection )
 {
-	IconList * list = MMC->icons();
+	auto list = MMC->icons();
 	auto contentsWidget = ui->iconView;
 	selectedIconKey = selection;
 	
diff --git a/gui/LegacyModEditDialog.cpp b/gui/LegacyModEditDialog.cpp
index 1a1198b1..20296769 100644
--- a/gui/LegacyModEditDialog.cpp
+++ b/gui/LegacyModEditDialog.cpp
@@ -199,7 +199,7 @@ void LegacyModEditDialog::on_addCoreBtn_clicked()
 }
 void LegacyModEditDialog::on_addForgeBtn_clicked()
 {
-	VersionSelectDialog vselect(MMC->forgelist(), this);
+	VersionSelectDialog vselect(MMC->forgelist().data(), this);
 	vselect.setFilter(1, m_inst->intendedVersionId());
 	if (vselect.exec() && vselect.selectedVersion())
 	{
diff --git a/gui/OneSixModEditDialog.cpp b/gui/OneSixModEditDialog.cpp
index 7cbb9cbd..94fea933 100644
--- a/gui/OneSixModEditDialog.cpp
+++ b/gui/OneSixModEditDialog.cpp
@@ -1,9 +1,9 @@
 /* Copyright 2013 MultiMC Contributors
- * 
+ *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *     http://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
@@ -20,6 +20,7 @@
 #include "logic/OneSixVersion.h"
 #include "logic/EnabledItemFilter.h"
 #include "logic/lists/ForgeVersionList.h"
+#include <logic/ForgeInstaller.h>
 #include "gui/versionselectdialog.h"
 #include "ProgressDialog.h"
 
@@ -30,30 +31,33 @@
 #include <QEvent>
 #include <QKeyEvent>
 
-OneSixModEditDialog::OneSixModEditDialog(OneSixInstance * inst, QWidget *parent):
-	m_inst(inst),
-	QDialog(parent),
-	ui(new Ui::OneSixModEditDialog)
+OneSixModEditDialog::OneSixModEditDialog(OneSixInstance *inst, QWidget *parent)
+	: m_inst(inst), QDialog(parent), ui(new Ui::OneSixModEditDialog)
 {
 	ui->setupUi(this);
-	//libraries!
+	// libraries!
+
+	m_version = m_inst->getFullVersion();
+	if (m_version)
 	{
-		m_version = m_inst->getFullVersion();
-		
 		main_model = new EnabledItemFilter(this);
 		main_model->setActive(true);
 		main_model->setSourceModel(m_version.data());
 		ui->libraryTreeView->setModel(main_model);
-		ui->libraryTreeView->installEventFilter( this );
+		ui->libraryTreeView->installEventFilter(this);
 		ui->mainClassEdit->setText(m_version->mainClass);
-		updateButtons();
+		updateVersionControls();
+	}
+	else
+	{
+		disableVersionControls();
 	}
 	// Loader mods
 	{
 		ensureFolderPathExists(m_inst->loaderModsDir());
 		m_mods = m_inst->loaderModList();
 		ui->loaderModTreeView->setModel(m_mods.data());
-		ui->loaderModTreeView->installEventFilter( this );
+		ui->loaderModTreeView->installEventFilter(this);
 		m_mods->startWatching();
 	}
 	// resource packs
@@ -61,7 +65,7 @@ OneSixModEditDialog::OneSixModEditDialog(OneSixInstance * inst, QWidget *parent)
 		ensureFolderPathExists(m_inst->resourcePacksDir());
 		m_resourcepacks = m_inst->resourcePackList();
 		ui->resPackTreeView->setModel(m_resourcepacks.data());
-		ui->resPackTreeView->installEventFilter( this );
+		ui->resPackTreeView->installEventFilter(this);
 		m_resourcepacks->startWatching();
 	}
 }
@@ -73,48 +77,62 @@ OneSixModEditDialog::~OneSixModEditDialog()
 	delete ui;
 }
 
-void OneSixModEditDialog::updateButtons()
+void OneSixModEditDialog::updateVersionControls()
 {
 	bool customVersion = m_inst->versionIsCustom();
 	ui->customizeBtn->setEnabled(!customVersion);
 	ui->revertBtn->setEnabled(customVersion);
+	ui->forgeBtn->setEnabled(true);
 }
 
+void OneSixModEditDialog::disableVersionControls()
+{
+	ui->customizeBtn->setEnabled(false);
+	ui->revertBtn->setEnabled(false);
+	ui->forgeBtn->setEnabled(false);
+}
 
 void OneSixModEditDialog::on_customizeBtn_clicked()
 {
-	if(m_inst->customizeVersion())
+	if (m_inst->customizeVersion())
 	{
 		m_version = m_inst->getFullVersion();
 		main_model->setSourceModel(m_version.data());
-		updateButtons();
+		updateVersionControls();
 	}
 }
 
 void OneSixModEditDialog::on_revertBtn_clicked()
 {
-	auto reply = QMessageBox::question(this, tr("Revert?"), tr("Do you want to revert the version of this instance to its original configuration?"),QMessageBox::Yes|QMessageBox::No);
+	auto reply = QMessageBox::question(
+		this, tr("Revert?"), tr("Do you want to revert the "
+								"version of this instance to its original configuration?"),
+		QMessageBox::Yes | QMessageBox::No);
 	if (reply == QMessageBox::Yes)
 	{
-		if(m_inst->revertCustomVersion())
+		if (m_inst->revertCustomVersion())
 		{
 			m_version = m_inst->getFullVersion();
 			main_model->setSourceModel(m_version.data());
-			updateButtons();
+			updateVersionControls();
 		}
 	}
 }
 
-
 void OneSixModEditDialog::on_forgeBtn_clicked()
 {
-	VersionSelectDialog vselect(MMC->forgelist(), this);
+	VersionSelectDialog vselect(MMC->forgelist().data(), this);
 	vselect.setFilter(1, m_inst->currentVersionId());
 	if (vselect.exec() && vselect.selectedVersion())
 	{
-		if(m_inst->versionIsCustom())
+		if (m_inst->versionIsCustom())
 		{
-			auto reply = QMessageBox::question(this, tr("Revert?"), tr("This will revert any changes you did to the version up to this point. Is that OK?"),QMessageBox::Yes|QMessageBox::No);
+			auto reply = QMessageBox::question(
+				this, tr("Revert?"),
+				tr("This will revert any "
+				   "changes you did to the version up to this point. Is that "
+				   "OK?"),
+				QMessageBox::Yes | QMessageBox::No);
 			if (reply == QMessageBox::Yes)
 			{
 				m_inst->revertCustomVersion();
@@ -122,24 +140,38 @@ void OneSixModEditDialog::on_forgeBtn_clicked()
 				{
 					m_version = m_inst->getFullVersion();
 					main_model->setSourceModel(m_version.data());
-					updateButtons();
+					updateVersionControls();
 				}
 			}
-			else return;
+			else
+				return;
+		}
+		else
+		{
+			m_inst->customizeVersion();
+			m_version = m_inst->getFullVersion();
+			main_model->setSourceModel(m_version.data());
+			updateVersionControls();
 		}
-		ForgeVersionPtr forge = vselect.selectedVersion().dynamicCast<ForgeVersion>();
-		if(!forge)
+		ForgeVersionPtr forgeVersion = vselect.selectedVersion().dynamicCast<ForgeVersion>();
+		if (!forgeVersion)
 			return;
-		auto entry = MMC->metacache()->resolveEntry("minecraftforge", forge->filename);
-		if(entry->stale)
+		auto entry = MMC->metacache()->resolveEntry("minecraftforge", forgeVersion->filename);
+		if (entry->stale)
 		{
-			DownloadJob * fjob = new DownloadJob("Forge download");
-			fjob->add(forge->universal_url, entry);
+			DownloadJob *fjob = new DownloadJob("Forge download");
+			fjob->add(forgeVersion->installer_url, entry);
 			ProgressDialog dlg(this);
 			dlg.exec(fjob);
-			if(dlg.result() == QDialog::Accepted)
+			if (dlg.result() == QDialog::Accepted)
 			{
 				// install
+				QString forgePath = entry->getFullPath();
+				ForgeInstaller forge(forgePath, forgeVersion->universal_url);
+				if (!forge.apply(m_version))
+				{
+					// failure notice
+				}
 			}
 			else
 			{
@@ -149,55 +181,60 @@ void OneSixModEditDialog::on_forgeBtn_clicked()
 		else
 		{
 			// install
+			QString forgePath = entry->getFullPath();
+			ForgeInstaller forge(forgePath, forgeVersion->universal_url);
+			if (!forge.apply(m_version))
+			{
+				// failure notice
+			}
 		}
 	}
 }
 
-bool OneSixModEditDialog::loaderListFilter ( QKeyEvent* keyEvent )
+bool OneSixModEditDialog::loaderListFilter(QKeyEvent *keyEvent)
 {
-	switch(keyEvent->key())
+	switch (keyEvent->key())
 	{
-		case Qt::Key_Delete:
-			on_rmModBtn_clicked();
-			return true;
-		case Qt::Key_Plus:
-			on_addModBtn_clicked();
-			return true;
-		default:
-			break;
+	case Qt::Key_Delete:
+		on_rmModBtn_clicked();
+		return true;
+	case Qt::Key_Plus:
+		on_addModBtn_clicked();
+		return true;
+	default:
+		break;
 	}
-	return QDialog::eventFilter( ui->loaderModTreeView, keyEvent );
+	return QDialog::eventFilter(ui->loaderModTreeView, keyEvent);
 }
 
-bool OneSixModEditDialog::resourcePackListFilter ( QKeyEvent* keyEvent )
+bool OneSixModEditDialog::resourcePackListFilter(QKeyEvent *keyEvent)
 {
-	switch(keyEvent->key())
+	switch (keyEvent->key())
 	{
-		case Qt::Key_Delete:
-			on_rmResPackBtn_clicked();
-			return true;
-		case Qt::Key_Plus:
-			on_addResPackBtn_clicked();
-			return true;
-		default:
-			break;
+	case Qt::Key_Delete:
+		on_rmResPackBtn_clicked();
+		return true;
+	case Qt::Key_Plus:
+		on_addResPackBtn_clicked();
+		return true;
+	default:
+		break;
 	}
-	return QDialog::eventFilter( ui->resPackTreeView, keyEvent );
+	return QDialog::eventFilter(ui->resPackTreeView, keyEvent);
 }
 
-
-bool OneSixModEditDialog::eventFilter ( QObject* obj, QEvent* ev )
+bool OneSixModEditDialog::eventFilter(QObject *obj, QEvent *ev)
 {
 	if (ev->type() != QEvent::KeyPress)
 	{
-		return QDialog::eventFilter( obj, ev );
+		return QDialog::eventFilter(obj, ev);
 	}
-	QKeyEvent *keyEvent = static_cast<QKeyEvent*>(ev);
-	if(obj == ui->loaderModTreeView)
+	QKeyEvent *keyEvent = static_cast<QKeyEvent *>(ev);
+	if (obj == ui->loaderModTreeView)
 		return loaderListFilter(keyEvent);
-	if(obj == ui->resPackTreeView)
+	if (obj == ui->resPackTreeView)
 		return resourcePackListFilter(keyEvent);
-	return QDialog::eventFilter( obj, ev );
+	return QDialog::eventFilter(obj, ev);
 }
 
 void OneSixModEditDialog::on_buttonBox_rejected()
@@ -207,8 +244,9 @@ void OneSixModEditDialog::on_buttonBox_rejected()
 
 void OneSixModEditDialog::on_addModBtn_clicked()
 {
-	QStringList fileNames = QFileDialog::getOpenFileNames(this, QApplication::translate("LegacyModEditDialog", "Select Loader Mods"));
-	for(auto filename:fileNames)
+	QStringList fileNames = QFileDialog::getOpenFileNames(
+		this, QApplication::translate("LegacyModEditDialog", "Select Loader Mods"));
+	for (auto filename : fileNames)
 	{
 		m_mods->stopWatching();
 		m_mods->installMod(QFileInfo(filename));
@@ -219,8 +257,8 @@ void OneSixModEditDialog::on_rmModBtn_clicked()
 {
 	int first, last;
 	auto list = ui->loaderModTreeView->selectionModel()->selectedRows();
-	
-	if(!lastfirst(list, first, last))
+
+	if (!lastfirst(list, first, last))
 		return;
 	m_mods->stopWatching();
 	m_mods->deleteMods(first, last);
@@ -231,11 +269,11 @@ void OneSixModEditDialog::on_viewModBtn_clicked()
 	openDirInDefaultProgram(m_inst->loaderModsDir(), true);
 }
 
-
 void OneSixModEditDialog::on_addResPackBtn_clicked()
 {
-	QStringList fileNames = QFileDialog::getOpenFileNames(this, QApplication::translate("LegacyModEditDialog", "Select Resource Packs"));
-	for(auto filename:fileNames)
+	QStringList fileNames = QFileDialog::getOpenFileNames(
+		this, QApplication::translate("LegacyModEditDialog", "Select Resource Packs"));
+	for (auto filename : fileNames)
 	{
 		m_resourcepacks->stopWatching();
 		m_resourcepacks->installMod(QFileInfo(filename));
@@ -246,8 +284,8 @@ void OneSixModEditDialog::on_rmResPackBtn_clicked()
 {
 	int first, last;
 	auto list = ui->resPackTreeView->selectionModel()->selectedRows();
-	
-	if(!lastfirst(list, first, last))
+
+	if (!lastfirst(list, first, last))
 		return;
 	m_resourcepacks->stopWatching();
 	m_resourcepacks->deleteMods(first, last);
@@ -257,4 +295,3 @@ void OneSixModEditDialog::on_viewResPackBtn_clicked()
 {
 	openDirInDefaultProgram(m_inst->resourcePacksDir(), true);
 }
-
diff --git a/gui/OneSixModEditDialog.h b/gui/OneSixModEditDialog.h
index 714c911a..e70bd73f 100644
--- a/gui/OneSixModEditDialog.h
+++ b/gui/OneSixModEditDialog.h
@@ -44,7 +44,8 @@ private slots:
 	void on_forgeBtn_clicked();
 	void on_customizeBtn_clicked();
 	void on_revertBtn_clicked();
-    void updateButtons();
+    void updateVersionControls();
+	void disableVersionControls();
 protected:
 	bool eventFilter(QObject *obj, QEvent *ev);
 	bool loaderListFilter( QKeyEvent* ev );
diff --git a/gui/instancedelegate.h b/gui/instancedelegate.h
index c80f95a5..56bc34ba 100644
--- a/gui/instancedelegate.h
+++ b/gui/instancedelegate.h
@@ -9,4 +9,4 @@ public:
 protected:
 	void paint ( QPainter* painter, const QStyleOptionViewItem& option, const QModelIndex& index ) const;
 	QSize sizeHint ( const QStyleOptionViewItem & option, const QModelIndex & index ) const;
-};
\ No newline at end of file
+};
diff --git a/gui/lwjglselectdialog.cpp b/gui/lwjglselectdialog.cpp
index 7c424a6c..e48bb975 100644
--- a/gui/lwjglselectdialog.cpp
+++ b/gui/lwjglselectdialog.cpp
@@ -26,10 +26,10 @@ LWJGLSelectDialog::LWJGLSelectDialog(QWidget *parent) :
 	ui->setupUi(this);
 	ui->labelStatus->setVisible(false);
 	auto lwjgllist = MMC->lwjgllist();
-	ui->lwjglListView->setModel(lwjgllist);
+	ui->lwjglListView->setModel(lwjgllist.data());
 	
-	connect(lwjgllist, SIGNAL(loadingStateUpdated(bool)), SLOT(loadingStateUpdated(bool)));
-	connect(lwjgllist, SIGNAL(loadListFailed(QString)), SLOT(loadingFailed(QString)));
+	connect(lwjgllist.data(), SIGNAL(loadingStateUpdated(bool)), SLOT(loadingStateUpdated(bool)));
+	connect(lwjgllist.data(), SIGNAL(loadListFailed(QString)), SLOT(loadingFailed(QString)));
 	loadingStateUpdated(lwjgllist->isLoading());
 }
 
diff --git a/gui/mainwindow.cpp b/gui/mainwindow.cpp
index 6f707236..d3b167fa 100644
--- a/gui/mainwindow.cpp
+++ b/gui/mainwindow.cpp
@@ -124,7 +124,7 @@ MainWindow::MainWindow ( QWidget *parent )
 		//proxymodel->setDynamicSortFilter ( true );
 		
 		// FIXME: instList should be global-ish, or at least not tied to the main window... maybe the application itself?
-		proxymodel->setSourceModel ( MMC->instances() );
+		proxymodel->setSourceModel ( MMC->instances().data() );
 		proxymodel->sort ( 0 );
 		view->setFrameShape ( QFrame::NoFrame );
 		view->setModel ( proxymodel );
@@ -149,7 +149,7 @@ MainWindow::MainWindow ( QWidget *parent )
 	       );
 	// model reset -> selection is invalid. All the instance pointers are wrong.
 	// FIXME: stop using POINTERS everywhere
-	connect(MMC->instances() ,SIGNAL(dataIsInvalid()),SLOT(selectionBad()));
+	connect(MMC->instances().data() ,SIGNAL(dataIsInvalid()),SLOT(selectionBad()));
 	
 	// run the things that load and download other things... FIXME: this is NOT the place
 	// FIXME: invisible actions in the background = NOPE.
@@ -601,7 +601,7 @@ void MainWindow::on_actionChangeInstMCVersion_triggered()
 	if (view->selectionModel()->selectedIndexes().count() < 1)
 		return;
 	
-	VersionSelectDialog vselect(m_selectedInstance->versionList(), this);
+	VersionSelectDialog vselect(m_selectedInstance->versionList().data(), this);
 	if (vselect.exec() && vselect.selectedVersion())
 	{
 		m_selectedInstance->setIntendedVersionId(vselect.selectedVersion()->descriptor());
diff --git a/gui/mainwindow.ui b/gui/mainwindow.ui
index 4360f5f6..1cda7a34 100644
--- a/gui/mainwindow.ui
+++ b/gui/mainwindow.ui
@@ -440,7 +440,7 @@
     <string>Meow</string>
    </property>
    <property name="toolTip">
-    <string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p align=&quot;center&quot;&gt;&lt;span style=&quot; font-weight:600; color:#ff0004;&quot;&gt;Catnatok!&lt;/span&gt;&lt;/p&gt;&lt;p align=&quot;center&quot;&gt;Or just a cat with a ball of yarn?&lt;/p&gt;&lt;p align=&quot;center&quot;&gt;&lt;span style=&quot; font-style:italic;&quot;&gt;WHO KNOWS?!&lt;/span&gt;&lt;/p&gt;&lt;p align=&quot;center&quot;&gt;&lt;img src=&quot;:/icons/instances/tnt&quot;/&gt;&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
+    <string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p align=&quot;center&quot;&gt;&lt;span style=&quot; font-weight:600; color:#ff0004;&quot;&gt;Catnarok!&lt;/span&gt;&lt;/p&gt;&lt;p align=&quot;center&quot;&gt;Or just a cat with a ball of yarn?&lt;/p&gt;&lt;p align=&quot;center&quot;&gt;&lt;span style=&quot; font-style:italic;&quot;&gt;WHO KNOWS?!&lt;/span&gt;&lt;/p&gt;&lt;p align=&quot;center&quot;&gt;&lt;img src=&quot;:/icons/instances/tnt&quot;/&gt;&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
    </property>
   </action>
  </widget>
diff --git a/gui/newinstancedialog.cpp b/gui/newinstancedialog.cpp
index 6604d03b..859077d9 100644
--- a/gui/newinstancedialog.cpp
+++ b/gui/newinstancedialog.cpp
@@ -96,7 +96,7 @@ BaseVersionPtr NewInstanceDialog::selectedVersion() const
 
 void NewInstanceDialog::on_btnChangeVersion_clicked()
 {
-	VersionSelectDialog vselect(MMC->minecraftlist(), this);
+	VersionSelectDialog vselect(MMC->minecraftlist().data(), this);
 	vselect.exec();
 	if (vselect.result() == QDialog::Accepted)
 	{
diff --git a/gui/settingsdialog.cpp b/gui/settingsdialog.cpp
index a5283b36..9736c1c7 100644
--- a/gui/settingsdialog.cpp
+++ b/gui/settingsdialog.cpp
@@ -27,7 +27,7 @@ SettingsDialog::SettingsDialog(QWidget *parent) :
 {
 	ui->setupUi(this);
 	
-	loadSettings(MMC->settings());
+	loadSettings(MMC->settings().data());
 	updateCheckboxStuff();
 }
 
@@ -85,7 +85,7 @@ void SettingsDialog::on_maximizedCheckBox_clicked(bool checked)
 
 void SettingsDialog::on_buttonBox_accepted()
 {
-	applySettings(MMC->settings());
+	applySettings(MMC->settings().data());
 }
 
 void SettingsDialog::applySettings(SettingsObject *s)