Rework the settings dialog. Rework all of it. Thoroughly.

Also introduces the ColumnResizer from:
https://github.com/agateau/columnresizer/

1 files changed, 7 insertions, 5 deletions

diff --git a/gui/pages/global/ExternalToolsPage.h b/gui/pages/global/ExternalToolsPage.h
index 1b35a92b..027e164e 100644
--- a/gui/pages/global/ExternalToolsPage.h
+++ b/gui/pages/global/ExternalToolsPage.h
@@ -17,13 +17,13 @@
 
 #include <QWidget>
 
-#include "BaseSettingsPage.h"
+#include "gui/pages/BasePage.h"
 
 namespace Ui {
 class ExternalToolsPage;
 }
 
-class ExternalToolsPage : public QWidget, public BaseSettingsPage
+class ExternalToolsPage : public QWidget, public BasePage
 {
 	Q_OBJECT
 
@@ -47,10 +47,11 @@ public:
 	{
 		return "External-tools";
 	}
+	virtual bool apply();
 
-protected:
-	void loadSettings(SettingsObject *object) override;
-	void applySettings(SettingsObject *object) override;
+private:
+	void loadSettings();
+	void applySettings();
 
 private:
 	Ui::ExternalToolsPage *ui;
@@ -63,4 +64,5 @@ slots:
 	void on_jvisualvmCheckBtn_clicked();
 	void on_mceditPathBtn_clicked();
 	void on_mceditCheckBtn_clicked();
+	void on_jsonEditorBrowseBtn_clicked();
 };