NOISSUE do not keep downloads in memory, add (some) missing virtual dtors

5 files changed, 11 insertions, 0 deletions

diff --git a/api/logic/minecraft/update/AssetUpdateTask.cpp b/api/logic/minecraft/update/AssetUpdateTask.cpp
index 2ad2b5b2..905c5b3d 100644
--- a/api/logic/minecraft/update/AssetUpdateTask.cpp
+++ b/api/logic/minecraft/update/AssetUpdateTask.cpp
@@ -9,6 +9,11 @@ AssetUpdateTask::AssetUpdateTask(MinecraftInstance * inst)
 {
 	m_inst = inst;
 }
+
+AssetUpdateTask::~AssetUpdateTask()
+{
+}
+
 void AssetUpdateTask::executeTask()
 {
 	setStatus(tr("Updating assets index..."));
diff --git a/api/logic/minecraft/update/AssetUpdateTask.h b/api/logic/minecraft/update/AssetUpdateTask.h
index c666faa6..870cede5 100644
--- a/api/logic/minecraft/update/AssetUpdateTask.h
+++ b/api/logic/minecraft/update/AssetUpdateTask.h
@@ -8,6 +8,8 @@ class AssetUpdateTask : public Task
 	Q_OBJECT
 public:
 	AssetUpdateTask(MinecraftInstance * inst);
+	virtual ~AssetUpdateTask();
+
 	void executeTask() override;
 
 	bool canAbort() const override;
diff --git a/api/logic/minecraft/update/FMLLibrariesTask.h b/api/logic/minecraft/update/FMLLibrariesTask.h
index 85f45468..f281890d 100644
--- a/api/logic/minecraft/update/FMLLibrariesTask.h
+++ b/api/logic/minecraft/update/FMLLibrariesTask.h
@@ -10,6 +10,7 @@ class FMLLibrariesTask : public Task
 	Q_OBJECT
 public:
 	FMLLibrariesTask(MinecraftInstance * inst);
+	virtual ~FMLLibrariesTask() {};
 
 	void executeTask() override;
 
diff --git a/api/logic/minecraft/update/FoldersTask.h b/api/logic/minecraft/update/FoldersTask.h
index 6e669b1e..e0781ad8 100644
--- a/api/logic/minecraft/update/FoldersTask.h
+++ b/api/logic/minecraft/update/FoldersTask.h
@@ -8,6 +8,8 @@ class FoldersTask : public Task
 	Q_OBJECT
 public:
 	FoldersTask(MinecraftInstance * inst);
+	virtual ~FoldersTask() {};
+
 	void executeTask() override;
 private:
 	MinecraftInstance *m_inst;
diff --git a/api/logic/minecraft/update/LibrariesTask.h b/api/logic/minecraft/update/LibrariesTask.h
index d06a5037..cb9babc3 100644
--- a/api/logic/minecraft/update/LibrariesTask.h
+++ b/api/logic/minecraft/update/LibrariesTask.h
@@ -8,6 +8,7 @@ class LibrariesTask : public Task
 	Q_OBJECT
 public:
 	LibrariesTask(MinecraftInstance * inst);
+	virtual ~LibrariesTask() {};
 
 	void executeTask() override;