NOISSUE fix Windows kernel numbers and add unit test for them

3 files changed, 29 insertions, 0 deletions

diff --git a/libraries/ganalytics/CMakeLists.txt b/libraries/ganalytics/CMakeLists.txt
index 1f2ff4e2..9d218c6d 100644
--- a/libraries/ganalytics/CMakeLists.txt
+++ b/libraries/ganalytics/CMakeLists.txt
@@ -25,3 +25,9 @@ endif()
 add_library(ganalytics STATIC ${ganalytics_SOURCES})
 qt5_use_modules(ganalytics Core Gui Network)
 target_include_directories(ganalytics PUBLIC include)
+
+include (UnitTest)
+add_unit_test(sys
+	SOURCES src/sys_test.cpp
+	LIBS ganalytics
+)
diff --git a/libraries/ganalytics/src/sys_test.cpp b/libraries/ganalytics/src/sys_test.cpp
new file mode 100644
index 00000000..6221da45
--- /dev/null
+++ b/libraries/ganalytics/src/sys_test.cpp
@@ -0,0 +1,22 @@
+#include <QTest>
+#include "TestUtil.h"
+
+#include <sys.h>
+
+class SysTest : public QObject
+{
+	Q_OBJECT
+private
+slots:
+
+	void test_kernelNotNull()
+	{
+		auto kinfo = Sys::getKernelInfo();
+		QVERIFY(!kinfo.kernelName.isEmpty());
+		QVERIFY(kinfo.kernelVersion != "0.0");
+	}
+};
+
+QTEST_GUILESS_MAIN(SysTest)
+
+#include "sys_test.moc"
diff --git a/libraries/ganalytics/src/sys_win32.cpp b/libraries/ganalytics/src/sys_win32.cpp
index 4d43169b..502b980d 100644
--- a/libraries/ganalytics/src/sys_win32.cpp
+++ b/libraries/ganalytics/src/sys_win32.cpp
@@ -8,6 +8,7 @@ Sys::KernelInfo Sys::getKernelInfo()
 	out.kernelName = "Windows";
 	OSVERSIONINFOW osvi;
 	ZeroMemory(&osvi, sizeof(OSVERSIONINFOW));
+	osvi.dwOSVersionInfoSize = sizeof(OSVERSIONINFOW);
 	GetVersionExW(&osvi);
 	out.kernelVersion = QString("%1.%2").arg(osvi.dwMajorVersion).arg(osvi.dwMinorVersion);
 	return out;