From 7406d488b363588be8f677f698be11ea478f377b Mon Sep 17 00:00:00 2001 From: "Matt A. Tobin" Date: Mon, 11 Nov 2019 02:08:59 -0500 Subject: Bug 1584473 - Fix several issues * Fix undefined HRESULT codes in class CMapiApi in MapiApi.cpp. * Fix doubled up sub-expressions in MIME and MAPI. * Remove broken/unused morkRowCellCursor::MakeCell() Tag #1273 --- mailnews/import/outlook/src/MapiApi.cpp | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'mailnews/import') diff --git a/mailnews/import/outlook/src/MapiApi.cpp b/mailnews/import/outlook/src/MapiApi.cpp index d6a159754..d23b44dd1 100644 --- a/mailnews/import/outlook/src/MapiApi.cpp +++ b/mailnews/import/outlook/src/MapiApi.cpp @@ -887,7 +887,7 @@ BOOL CMapiApi::IterateStores(CMapiFolderList& stores) if (!m_lpSession) { MAPI_TRACE0("IterateStores called before session is open\n"); - m_lastError = -1; + m_lastError = E_UNEXPECTED; return FALSE; } @@ -1124,7 +1124,7 @@ CMsgStore * CMapiApi::FindMessageStore(ULONG cbEid, LPENTRYID lpEid) { if (!m_lpSession) { MAPI_TRACE0("FindMessageStore called before session is open\n"); - m_lastError = -1; + m_lastError = E_UNEXPECTED; return NULL; } @@ -1409,9 +1409,6 @@ void CMapiApi::ReportLongProp(const char *pTag, LPSPropValue pVal) else if (pVal && (PROP_TYPE(pVal->ulPropTag) == PT_ERROR)) { MAPI_TRACE1("%s {Error retrieving property}\n", pTag); } - else if (pVal && (PROP_TYPE(pVal->ulPropTag) == PT_ERROR)) { - MAPI_TRACE1("%s {Error retrieving property}\n", pTag); - } else { MAPI_TRACE1("%s invalid value, expecting long\n", pTag); } @@ -1843,7 +1840,7 @@ BOOL CMapiFolderContents::SetUpIter(void) } if (ulObjType != MAPI_FOLDER) { - m_lastError = -1; + m_lastError = E_UNEXPECTED; MAPI_TRACE0("CMapiFolderContents - bad object type, not a folder.\n"); return FALSE; } -- cgit v1.2.3