From 201683afe4596ae32f7b1ea12dfca52995d59f9d Mon Sep 17 00:00:00 2001 From: "Matt A. Tobin" Date: Sun, 10 Nov 2019 19:11:03 -0500 Subject: Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors * Part 1: make conversion CTORs explicit. Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors. * Part 2: fix a couple of double-mRefCnt declaration errors. * Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16(). Tag #1273 --- mailnews/import/text/src/nsTextImport.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mailnews/import/text/src') diff --git a/mailnews/import/text/src/nsTextImport.cpp b/mailnews/import/text/src/nsTextImport.cpp index 61615e4d7..0b99e652b 100644 --- a/mailnews/import/text/src/nsTextImport.cpp +++ b/mailnews/import/text/src/nsTextImport.cpp @@ -51,7 +51,7 @@ PRLogModuleInfo* TEXTIMPORTLOGMODULE; class ImportAddressImpl final : public nsIImportAddressBooks { public: - ImportAddressImpl(nsIStringBundle* aStringBundle); + explicit ImportAddressImpl(nsIStringBundle* aStringBundle); static nsresult Create(nsIImportAddressBooks** aImport, nsIStringBundle *aStringBundle); -- cgit v1.2.3