From 201683afe4596ae32f7b1ea12dfca52995d59f9d Mon Sep 17 00:00:00 2001 From: "Matt A. Tobin" Date: Sun, 10 Nov 2019 19:11:03 -0500 Subject: Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors * Part 1: make conversion CTORs explicit. Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors. * Part 2: fix a couple of double-mRefCnt declaration errors. * Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16(). Tag #1273 --- mailnews/base/util/nsMsgKeySet.h | 2 +- mailnews/base/util/nsMsgLineBuffer.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'mailnews/base/util') diff --git a/mailnews/base/util/nsMsgKeySet.h b/mailnews/base/util/nsMsgKeySet.h index c33306ad8..f38dbd013 100644 --- a/mailnews/base/util/nsMsgKeySet.h +++ b/mailnews/base/util/nsMsgKeySet.h @@ -80,7 +80,7 @@ public: protected: nsMsgKeySet(/* MSG_NewsHost* host */); - nsMsgKeySet(const char* /* , MSG_NewsHost* host */); + explicit nsMsgKeySet(const char* /* , MSG_NewsHost* host */); bool Grow(); bool Optimize(); diff --git a/mailnews/base/util/nsMsgLineBuffer.h b/mailnews/base/util/nsMsgLineBuffer.h index 0383b2d43..eff3f7c7e 100644 --- a/mailnews/base/util/nsMsgLineBuffer.h +++ b/mailnews/base/util/nsMsgLineBuffer.h @@ -50,7 +50,7 @@ public: // flush last line, though it won't be CRLF terminated. virtual nsresult FlushLastLine(); protected: - nsMsgLineBuffer(bool convertNewlinesP); + explicit nsMsgLineBuffer(bool convertNewlinesP); nsresult ConvertAndSendBuffer(); void SetLookingForCRLF(bool b); -- cgit v1.2.3