From 232f987cf45aad65d20e79d283f14c72771c9bc8 Mon Sep 17 00:00:00 2001
From: Andy <webmaster@RealityRipple.com>
Date: Fri, 31 Jul 2020 13:01:18 -0700
Subject: Issue #1619 - Convert Intrinsic Ratio to Float

https://bugzilla.mozilla.org/show_bug.cgi?id=1547792

Aspect Ratio handling simplified by using floating point integers:
- Multiplication of value (or inverse value) to a known side for Scaling
- No unequal equal values such as "4/3" vs "8/6" vs "20/15"
- Truly "Empty" aspect ratios, even if one dimension is not 0
---
 layout/svg/nsSVGOuterSVGFrame.cpp | 44 +++++++++++++++++++--------------------
 layout/svg/nsSVGOuterSVGFrame.h   |  2 +-
 2 files changed, 23 insertions(+), 23 deletions(-)

(limited to 'layout/svg')

diff --git a/layout/svg/nsSVGOuterSVGFrame.cpp b/layout/svg/nsSVGOuterSVGFrame.cpp
index 16dfc2b37..d8cd2cb77 100644
--- a/layout/svg/nsSVGOuterSVGFrame.cpp
+++ b/layout/svg/nsSVGOuterSVGFrame.cpp
@@ -232,28 +232,38 @@ nsSVGOuterSVGFrame::GetIntrinsicSize()
   return intrinsicSize;
 }
 
-/* virtual */ nsSize
+/* virtual */ AspectRatio
 nsSVGOuterSVGFrame::GetIntrinsicRatio()
 {
+  // 2020-07-14 (RealityRipple) Firefox Uses a new IsReplacedAndContainSize(this)
+  // function call [Line 96-99 on trunk].
+/*
+  static inline bool IsReplacedAndContainSize(const nsSVGOuterSVGFrame* aFrame) {
+    return aFrame->GetContent->GetParent() &&
+           aFrame->StyleDisplay()->IsContainSize();
+  }
+ */
+  // but since contain: size doesn't exist in Pale Moon yet...
+/*
+  if (IsReplacedAndContainSize(this)) {
+    return AspectRatio();
+  }
+ */
+  
   // We only have an intrinsic size/ratio if our width and height attributes
   // are both specified and set to non-percentage values, or we have a viewBox
   // rect: http://www.w3.org/TR/SVGMobile12/coords.html#IntrinsicSizing
+  // Unfortunately we have to return the ratio as two nscoords whereas what
+  // we have are two floats. Using app units allows for some floating point
+  // values to work but really small or large numbers will fail.
 
   SVGSVGElement *content = static_cast<SVGSVGElement*>(mContent);
   nsSVGLength2 &width  = content->mLengthAttributes[SVGSVGElement::ATTR_WIDTH];
   nsSVGLength2 &height = content->mLengthAttributes[SVGSVGElement::ATTR_HEIGHT];
 
   if (!width.IsPercentage() && !height.IsPercentage()) {
-    nsSize ratio(
-      nsPresContext::CSSPixelsToAppUnits(width.GetAnimValue(content)),
-      nsPresContext::CSSPixelsToAppUnits(height.GetAnimValue(content)));
-    if (ratio.width < 0) {
-      ratio.width = 0;
-    }
-    if (ratio.height < 0) {
-      ratio.height = 0;
-    }
-    return ratio;
+    return AspectRatio::FromSize(width.GetAnimValue(content),
+                                 height.GetAnimValue(content));
   }
 
   SVGViewElement* viewElement = content->GetCurrentViewElement();
@@ -267,17 +277,7 @@ nsSVGOuterSVGFrame::GetIntrinsicRatio()
   }
 
   if (viewbox) {
-    float viewBoxWidth = viewbox->width;
-    float viewBoxHeight = viewbox->height;
-
-    if (viewBoxWidth < 0.0f) {
-      viewBoxWidth = 0.0f;
-    }
-    if (viewBoxHeight < 0.0f) {
-      viewBoxHeight = 0.0f;
-    }
-    return nsSize(nsPresContext::CSSPixelsToAppUnits(viewBoxWidth),
-                  nsPresContext::CSSPixelsToAppUnits(viewBoxHeight));
+    return AspectRatio::FromSize(viewbox->width, viewbox->height);
   }
 
   return nsSVGDisplayContainerFrame::GetIntrinsicRatio();
diff --git a/layout/svg/nsSVGOuterSVGFrame.h b/layout/svg/nsSVGOuterSVGFrame.h
index ee59b7d1c..4705b6ebe 100644
--- a/layout/svg/nsSVGOuterSVGFrame.h
+++ b/layout/svg/nsSVGOuterSVGFrame.h
@@ -42,7 +42,7 @@ public:
   virtual nscoord GetPrefISize(nsRenderingContext *aRenderingContext) override;
 
   virtual mozilla::IntrinsicSize GetIntrinsicSize() override;
-  virtual nsSize  GetIntrinsicRatio() override;
+  virtual mozilla::AspectRatio GetIntrinsicRatio() override;
 
   virtual mozilla::LogicalSize
   ComputeSize(nsRenderingContext *aRenderingContext,
-- 
cgit v1.2.3


From 644f617e6612b3a147e50b06c244fcc9362c9605 Mon Sep 17 00:00:00 2001
From: Andy <webmaster@RealityRipple.com>
Date: Fri, 7 Aug 2020 14:29:41 -0700
Subject: Issue #1620 - Remove Development Comments

---
 layout/svg/nsSVGOuterSVGFrame.cpp | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

(limited to 'layout/svg')

diff --git a/layout/svg/nsSVGOuterSVGFrame.cpp b/layout/svg/nsSVGOuterSVGFrame.cpp
index d8cd2cb77..3f68245e2 100644
--- a/layout/svg/nsSVGOuterSVGFrame.cpp
+++ b/layout/svg/nsSVGOuterSVGFrame.cpp
@@ -234,22 +234,14 @@ nsSVGOuterSVGFrame::GetIntrinsicSize()
 
 /* virtual */ AspectRatio
 nsSVGOuterSVGFrame::GetIntrinsicRatio()
-{
-  // 2020-07-14 (RealityRipple) Firefox Uses a new IsReplacedAndContainSize(this)
-  // function call [Line 96-99 on trunk].
+{ 
+ // When 'contain: size' is implemented, make sure to check for it.
 /*
-  static inline bool IsReplacedAndContainSize(const nsSVGOuterSVGFrame* aFrame) {
-    return aFrame->GetContent->GetParent() &&
-           aFrame->StyleDisplay()->IsContainSize();
-  }
- */
-  // but since contain: size doesn't exist in Pale Moon yet...
-/*
-  if (IsReplacedAndContainSize(this)) {
+  if (this->GetContent->GetParent() && this->StyleDisplay()->IsContainSize()) {
     return AspectRatio();
   }
  */
-  
+
   // We only have an intrinsic size/ratio if our width and height attributes
   // are both specified and set to non-percentage values, or we have a viewBox
   // rect: http://www.w3.org/TR/SVGMobile12/coords.html#IntrinsicSizing
-- 
cgit v1.2.3