From b45f5c435eff41ac12d234f31432463e87c58bb9 Mon Sep 17 00:00:00 2001 From: wolfbeast Date: Fri, 13 Mar 2020 11:28:54 +0100 Subject: Issue #1485 - Fix incorrect grid cell sizing to min/max space. There were actually two separate logical errors in this method: The first part is that "origSizes.isSome()" is simply a bogus requirement for applying min/max-sizes here. I'm still keeping the optimization of not needlessly copying the mSizes array (as originally intended) since it's a quite common case. The second bug is that min/max-sizes were only applied under the "if (fr != 0.0f)" block. This is bogus since the calculated 'fr' value depends on 'aAvailableSize' which might change by applying min/max-sizes and thus 'fr' could become non-zero in the second round. To fix, this patch just moves "applyMinMax" block out one level. --- .../css-grid/grid-max-sizing-flex-007.html | 24 ++++++++++++++++++++++ 1 file changed, 24 insertions(+) (limited to 'layout/reftests/css-grid/grid-max-sizing-flex-007.html') diff --git a/layout/reftests/css-grid/grid-max-sizing-flex-007.html b/layout/reftests/css-grid/grid-max-sizing-flex-007.html index ac9dcc77c..a2f39e95b 100644 --- a/layout/reftests/css-grid/grid-max-sizing-flex-007.html +++ b/layout/reftests/css-grid/grid-max-sizing-flex-007.html @@ -105,4 +105,28 @@
+
The first 6 grids should look the same:
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ -- cgit v1.2.3