From e7fa5e7cb16bd39b0983386d36a88c6c3cac1bbb Mon Sep 17 00:00:00 2001 From: trav90 Date: Fri, 10 Aug 2018 15:04:21 -0500 Subject: Remove the const to fix the -Wignored-qualifiers warning with GCC 8 --- dom/bindings/ErrorResult.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'dom/bindings') diff --git a/dom/bindings/ErrorResult.h b/dom/bindings/ErrorResult.h index 7c3fc9e2f..da7ec30e7 100644 --- a/dom/bindings/ErrorResult.h +++ b/dom/bindings/ErrorResult.h @@ -75,7 +75,7 @@ template inline bool ThrowErrorMessage(JSContext* aCx, const ErrNum aErrorNumber, Ts&&... aArgs) { - binding_detail::ThrowErrorMessage(aCx, static_cast(aErrorNumber), + binding_detail::ThrowErrorMessage(aCx, static_cast(aErrorNumber), mozilla::Forward(aArgs)...); return false; } -- cgit v1.2.3 From 9b48c3fa58c4926341e1668fdfec131ada3147a1 Mon Sep 17 00:00:00 2001 From: trav90 Date: Fri, 10 Aug 2018 15:21:45 -0500 Subject: Remove the const to fix the -Wignored-qualifiers warning with GCC 8 (Part 2) --- dom/bindings/BindingUtils.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'dom/bindings') diff --git a/dom/bindings/BindingUtils.cpp b/dom/bindings/BindingUtils.cpp index 7056658a7..323feca52 100644 --- a/dom/bindings/BindingUtils.cpp +++ b/dom/bindings/BindingUtils.cpp @@ -119,7 +119,7 @@ ThrowInvalidThis(JSContext* aCx, const JS::CallArgs& aArgs, MSG_METHOD_THIS_DOES_NOT_IMPLEMENT_INTERFACE; MOZ_RELEASE_ASSERT(GetErrorArgCount(errorNumber) <= 2); JS_ReportErrorNumberUC(aCx, GetErrorMessage, nullptr, - static_cast(errorNumber), + static_cast(errorNumber), funcNameStr.get(), ifaceName.get()); return false; } @@ -226,7 +226,7 @@ TErrorResult::SetPendingExceptionWithMessage(JSContext* aCx) args[argCount] = nullptr; JS_ReportErrorNumberUCArray(aCx, dom::GetErrorMessage, nullptr, - static_cast(message->mErrorNumber), + static_cast(message->mErrorNumber), argCount > 0 ? args : nullptr); ClearMessage(); -- cgit v1.2.3 From f0a708834dfb189058dd90b67765fda7687f5039 Mon Sep 17 00:00:00 2001 From: trav90 Date: Sat, 18 Aug 2018 15:12:00 -0500 Subject: memset only the underlying vector from the Array container --- dom/bindings/BindingUtils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'dom/bindings') diff --git a/dom/bindings/BindingUtils.h b/dom/bindings/BindingUtils.h index 3e58390c9..24b47a545 100644 --- a/dom/bindings/BindingUtils.h +++ b/dom/bindings/BindingUtils.h @@ -515,7 +515,7 @@ class ProtoAndIfaceCache { public: PageTableCache() { - memset(&mPages, 0, sizeof(mPages)); + memset(mPages.begin(), 0, sizeof(mPages)); } ~PageTableCache() { -- cgit v1.2.3