From 4dda3f6039c4432a3545986ebc698a725c6c057c Mon Sep 17 00:00:00 2001 From: Gaming4JC Date: Sun, 5 Jan 2020 18:38:55 -0500 Subject: Bug 1406297 - Fix Document.createElement must report an exception. Tag UXP Issue #1344 --- dom/base/CustomElementRegistry.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'dom/base') diff --git a/dom/base/CustomElementRegistry.cpp b/dom/base/CustomElementRegistry.cpp index bad100cf5..7fd295201 100644 --- a/dom/base/CustomElementRegistry.cpp +++ b/dom/base/CustomElementRegistry.cpp @@ -111,13 +111,11 @@ CustomElementConstructor::Construct(const char* aExecutionReason, JS::Rooted result(cx); JS::Rooted constructor(cx, JS::ObjectValue(*mCallback)); if (!JS::Construct(cx, constructor, JS::HandleValueArray::empty(), &result)) { - aRv.Throw(NS_ERROR_DOM_INVALID_STATE_ERR); return nullptr; } RefPtr element; if (NS_FAILED(UNWRAP_OBJECT(Element, &result, element))) { - aRv.Throw(NS_ERROR_DOM_INVALID_STATE_ERR); return nullptr; } @@ -894,7 +892,7 @@ DoUpgrade(Element* aElement, return; } - if (constructResult.get() != aElement) { + if (!constructResult || constructResult.get() != aElement) { aRv.Throw(NS_ERROR_DOM_INVALID_STATE_ERR); return; } -- cgit v1.2.3