From b109b14de63500ab07c478723d4851b345139bdd Mon Sep 17 00:00:00 2001 From: Ascrod <32915892+Ascrod@users.noreply.github.com> Date: Fri, 25 May 2018 06:53:37 -0400 Subject: Remove UITour and customize tips. --- browser/modules/BrowserUITelemetry.jsm | 7 ------- browser/modules/SelfSupportBackend.jsm | 10 +--------- 2 files changed, 1 insertion(+), 16 deletions(-) (limited to 'browser/modules') diff --git a/browser/modules/BrowserUITelemetry.jsm b/browser/modules/BrowserUITelemetry.jsm index 2ad319f1a..2b7cc8c20 100644 --- a/browser/modules/BrowserUITelemetry.jsm +++ b/browser/modules/BrowserUITelemetry.jsm @@ -17,8 +17,6 @@ XPCOMUtils.defineLazyModuleGetter(this, "RecentWindow", "resource:///modules/RecentWindow.jsm"); XPCOMUtils.defineLazyModuleGetter(this, "CustomizableUI", "resource:///modules/CustomizableUI.jsm"); -XPCOMUtils.defineLazyModuleGetter(this, "UITour", - "resource:///modules/UITour.jsm"); XPCOMUtils.defineLazyGetter(this, "Timer", function() { let timer = {}; Cu.import("resource://gre/modules/Timer.jsm", timer); @@ -174,11 +172,6 @@ this.BrowserUITelemetry = { this.getToolbarMeasures.bind(this)); UITelemetry.addSimpleMeasureFunction("contextmenu", this.getContextMenuInfo.bind(this)); - // Ensure that UITour.jsm remains lazy-loaded, yet always registers its - // simple measure function with UITelemetry. - UITelemetry.addSimpleMeasureFunction("UITour", - () => UITour.getTelemetry()); - UITelemetry.addSimpleMeasureFunction("syncstate", this.getSyncState.bind(this)); diff --git a/browser/modules/SelfSupportBackend.jsm b/browser/modules/SelfSupportBackend.jsm index 3a3f8cb8b..961a2af0a 100644 --- a/browser/modules/SelfSupportBackend.jsm +++ b/browser/modules/SelfSupportBackend.jsm @@ -25,8 +25,6 @@ const PREF_ENABLED = "browser.selfsupport.enabled"; const PREF_URL = "browser.selfsupport.url"; // Unified Telemetry status. const PREF_TELEMETRY_UNIFIED = "toolkit.telemetry.unified"; -// UITour status. -const PREF_UITOUR_ENABLED = "browser.uitour.enabled"; // Controls the interval at which the self support page tries to reload in case of // errors. @@ -44,8 +42,6 @@ const PREF_LOG_DUMP = PREF_BRANCH_LOG + "dump"; const HTML_NS = "http://www.w3.org/1999/xhtml"; const XUL_NS = "http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"; -const UITOUR_FRAME_SCRIPT = "chrome://browser/content/content-UITour.js"; - // Whether the FHR/Telemetry unification features are enabled. // Changing this pref requires a restart. const IS_UNIFIED_TELEMETRY = Preferences.get(PREF_TELEMETRY_UNIFIED, false); @@ -90,8 +86,7 @@ var SelfSupportBackendInternal = { } // Make sure UITour is enabled. - let uiTourEnabled = Preferences.get(PREF_UITOUR_ENABLED, false); - if (!uiTourEnabled) { + if (true) { this._log.config("init - Disabling SelfSupport because UITour is disabled."); return; } @@ -253,9 +248,6 @@ var SelfSupportBackendInternal = { // Create the hidden browser. this._makeHiddenBrowser(url).then(() => { - // Load UITour frame script. - this._browser.messageManager.loadFrameScript(UITOUR_FRAME_SCRIPT, true); - // We need to watch for load errors as well and, in case, try to reload // the self support page. const webFlags = Ci.nsIWebProgress.NOTIFY_STATE_WINDOW | -- cgit v1.2.3 From 04f7940bc24918a14b0c5fac72d1b60d4497dd0e Mon Sep 17 00:00:00 2001 From: Ascrod <32915892+Ascrod@users.noreply.github.com> Date: Fri, 1 Jun 2018 08:21:25 -0400 Subject: Remove unneeded if condition from SelfSupportBackend module. --- browser/modules/SelfSupportBackend.jsm | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'browser/modules') diff --git a/browser/modules/SelfSupportBackend.jsm b/browser/modules/SelfSupportBackend.jsm index 961a2af0a..0f34d813c 100644 --- a/browser/modules/SelfSupportBackend.jsm +++ b/browser/modules/SelfSupportBackend.jsm @@ -85,11 +85,8 @@ var SelfSupportBackendInternal = { return; } - // Make sure UITour is enabled. - if (true) { - this._log.config("init - Disabling SelfSupport because UITour is disabled."); - return; - } + this._log.config("init - Disabling SelfSupport because UITour is disabled."); + return; // Check the preferences to see if we want this to be active. if (!Preferences.get(PREF_ENABLED, true)) { -- cgit v1.2.3 From d38e7b77846e346130acae2fe842dc91b1749556 Mon Sep 17 00:00:00 2001 From: Ascrod <32915892+Ascrod@users.noreply.github.com> Date: Fri, 1 Jun 2018 15:40:33 -0400 Subject: Remove unused code from SelfSupportBackend module. --- browser/modules/SelfSupportBackend.jsm | 8 -------- 1 file changed, 8 deletions(-) (limited to 'browser/modules') diff --git a/browser/modules/SelfSupportBackend.jsm b/browser/modules/SelfSupportBackend.jsm index 0f34d813c..27072732e 100644 --- a/browser/modules/SelfSupportBackend.jsm +++ b/browser/modules/SelfSupportBackend.jsm @@ -87,14 +87,6 @@ var SelfSupportBackendInternal = { this._log.config("init - Disabling SelfSupport because UITour is disabled."); return; - - // Check the preferences to see if we want this to be active. - if (!Preferences.get(PREF_ENABLED, true)) { - this._log.config("init - SelfSupport is disabled."); - return; - } - - Services.obs.addObserver(this, "sessionstore-windows-restored", false); }, /** -- cgit v1.2.3