summaryrefslogtreecommitdiffstats
path: root/layout
Commit message (Collapse)AuthorAgeLines
* Issue #1355 - Better way to create display items for column backgroundswin7-72020-04-14-830/+1054
| | | | | | | | | | | | | | | | | | | | | | Part 1: Remove current table item, as it's never set. Part 2: Get rid of generic table painting code, and handle each class separately. Part 4: Hoist outline skipping into col(group) frame code. Part 5: Skip box-shadow for table column and column groups. Part 6: Store column and column group backgrounds separately, and then append them before the rest of the table contents. Part 7: Pass rects in display list coordinates to AppendBackgroundItemsToTop. Part 8: Create column and column group background display items as part of the cell's BuildDisplayList. Part 9: Used cached values instead of calling nsDisplayListBuilder::ToReferenceFrame when possible, since it can be expensive when the requested frame isn't the builder's current frame. Part 10: Make sure we build display items for table parts where only the normal position is visible, since we may need to create background items for ancestors at that position. Part 11: Create an AutoBuildingDisplayList when we create background items for table columns and column groups, so that we initialize the invalidation state correctly.
* Issue #1355 - Make nsTableCellFrame::GetColIndex/GetRowIndex fasterwin7-72020-04-14-123/+77
| | | | We can devirtualize it, remove some branches.
* [CSS] Only emit non-GC chrome wrapped XUL box warnings in debug builds.wolfbeast2020-04-14-0/+2
|
* Fix a whitespace issue in nsComputedDOMStyle.cppwolfbeast2020-04-14-3/+3
|
* [CSS] Add stub for font-variation-settingswolfbeast2020-04-14-0/+42
| | | | | | | | | | | | This stub is added because websites insist on considering this very hardware-dependent and O.S.-variable low-level font-control as a "critical feature" which it isn't as there is 0 guarantee that font variation settings are supported or honored by any operating system used by the client. On top this is a WD status feature that sites shouldn't be using, and the feature itself is strongly discouraged for use in favor of standard CSS font manipulation keywords like `font-weight`.
* Issue #1355 - Do less work for columns not in the desired set in ↵win7-72020-04-14-12/+26
| | | | | | | | | | PaintRowGroupBackgroundByColIdx Do less work in PaintRowGroupBackgroundByColIdx for cells that are not in our desired set of columns. crash fix: Guard against empty column groups when building a display list for a table.
* fix whitespacewin7-72020-04-14-1/+1
| | | | fix whitespace.
* Issue #1386 - Devirtualize GetRowSpan/GetColSpanwin7-72020-04-14-61/+24
| | | | It's at ~1.5% on the perf log for the Netflix use case, which seems a bit too much.
* Issue #1395 - Remove FlyWeb ServiceMatt A. Tobin2020-04-14-11/+0
|
* Issue #1390 - Get rid of the Presentation APIMatt A. Tobin2020-04-14-31/+0
|
* Issue #1355 - Hit testing in large tables has become extremely slowwin7-72020-04-14-7/+30
| | | | Add dirty rect intersection checks so that we don't build unnecessary table part display items.
* Revert "Issue #1355 - Hit testing in large tables has become extremely slow"wolfbeast2020-04-14-29/+7
| | | | This reverts commit f7b2f0a66536e8e74a0b2dc071a098b7693acecb.
* Issue #1355 - Hit testing in large tables has become extremely slowwin7-72020-04-14-7/+29
| | | | Add dirty rect intersection checks so that we don't build unnecessary table part display items.
* Issue #1378 - Follow-up: make sure background items remain table-aligned.wolfbeast2020-04-14-1/+1
|
* Issue #1378 - Align the drawing of table cell backgrounds with the spec.wolfbeast2020-04-14-55/+105
|
* Issue #1355 - Speed up the traversal of a table row frame's child cellswin7-72020-04-14-28/+27
| | | | Speed up getting the first cellframe in a row and the next cellframe after the given one
* Issue #1356 - Remove -moz-user-input disabled to improve event handling.athenian2002020-04-14-35/+29
|
* Issue #1360 - Part 2: Update tests for changed preferences.wolfbeast2020-04-14-7/+3
|
* Bug 1322938 - Basic implementation of HTMLDialogElement.Gaming4JC2020-01-07-0/+21
| | | | Tag #1343
* Issue #1345 - Implement non-standard legacy CSSStyleSheet rulesJustOff2020-01-07-0/+29
|
* Issue #1118 - Part 6: Fix various tests that are no longer correct.wolfbeast2019-12-22-1/+0
| | | | | The behavior change of document.open() requires these tests to be changed to account for the new spec behavior.
* Issue #1118 - Part 5: Change the way document.open() workswolfbeast2019-12-22-0/+5
| | | | | | | | | | | | This changes the work we do for document.open() in the following ways: - We no longer create a new Window when doing document.open(). We use the same Window but remove all the event listeners on the existing DOM tree and Window before removing the document's existing children to provide a clean slate document to use for .write(). - We no longer create a session history entry (previously would be a wyciwyg URI). We now replace the current one, effectively losing the entry for the original document. - We now support document.open() on windowless documents.
* Issue #1219 - Align computed DOM styles with mainstream behvior.wolfbeast2019-12-20-37/+42
| | | | | | | | | This updates our behavior for computed DOM styling to no longer return null on elements that have no display, but return a 0-length (empty) style instead and don't throw. For this we stop looking at having a presentation for the style and just look at the document instead. This resolves #1219
* Issue #1328 - Part 3: Add fuzz to reftests and fix misc other tests.Chris Peterson2019-12-18-4/+4
|
* Check if we're already at the end of the frame's content.Jonathan Kew2019-12-06-1/+2
|
* Issue #1309 - Fix handling of display rows where the elements are notwolfbeast2019-12-01-13/+11
| | | | | | | | | | | | | forming a monotonically increasing sequence (e.g. with position:sticky) Relative positioning can cause table parts to move, which can cause issues with the cursor position to know which rows can be skipped. To make this work, use the max difference between the frame's rect and the union of the frame's "normal" position and the overflow rect to cover the area of relatively positioned elements even if they are out of order. This resolves #1309.
* Issue #1308 - Create nsDisplayTableBackgroundColor to avoid displaywolfbeast2019-12-01-3/+37
| | | | | | | | list collisions when processing the background color of a table. This is effectively #146 Part 3c to go along with the other 2 there. This resolves #1308.
* Remove unnecessary calls to ReparentFloatsForInlineChild inMats Palmgren2019-11-29-45/+10
| | | | nsInlineFrame.
* Simplify the overflow child frame reparenting inMats Palmgren2019-11-29-7/+2
| | | | nsInlineFrame::DestroyFrom.
* Issue #1288 - Part 4: Update the OpenType Sanitizer component to 8.0.0wolfbeast2019-11-14-0/+0
|
* Issue #1288 - Part 1a: Update brotli to 1.0.7wolfbeast2019-11-14-5/+5
| | | | | This also reorganizes the exports in the build system to use `brotli/` as include directory.
* Merge branch 'table-sticky-work'wolfbeast2019-11-04-1464/+443
|\ | | | | | | This resolves #146.
| * Issue #146 - Part 7: Remove no longer relevant reftest.wolfbeast2019-11-03-62/+0
| |
| * Issue #146 - Part 6: Allow `position: sticky` on table elements.wolfbeast2019-11-03-20/+7
| |
| * Issue #146 - Part 5: Treat table row groups as containing blocks.wolfbeast2019-11-03-0/+11
| | | | | | | | This aligns our behavior with Gecko/Blink.
| * Issue #146 - Part 4: Adjust tests for fixes.wolfbeast2019-11-03-4/+41
| | | | | | | | | | | | This also adds a reftest for border radius on collapsed borders (should be ignored according to the CSS3 standard). We didn't do this before, except on internal elements.
| * Issue #146 - Part 3: Create nsDisplayTableBackgroundImage to avoidwolfbeast2019-11-03-7/+75
| | | | | | | | display list collisions when processing the background image of a table.
| * Issue #146 - Part 3: Create nsDisplayTableFixedPosition to avoid displaywolfbeast2019-11-03-8/+108
| | | | | | | | list collisions when processing the background image of a table.
| * Issue #146 - Part 2: Remove custom table painting component.wolfbeast2019-11-02-1162/+0
| | | | | | | | | | | | Since we're now putting table borders and backgrounds properly in the display lists, we no longer need this custom component to do this work for us.
| * Issue #146 - Part 1: Draw each table's background on their own displaywolfbeast2019-11-02-223/+223
| | | | | | | | | | | | | | | | | | | | | | | | | | | | list items. This patch does the following things: 1. Creates nsDisplayTableBorderCollapse that draws all collapse border of tables. 2. Stops the use of nsDisplayTableBorderBackground. 3. Lets column and column group frames generate display items. 4. When traversing the table, also traverses the column and column group frames. 5. For each type of table frame (col group, col, row group, row and cell), draws their own background.
* | MoonchildProductions#1251 - Part 1: Restore initial Solaris support, fixed up.athenian2002019-10-21-0/+3
|/ | | | | | | | | | | | | | Compared with what Pale Moon had for Solaris originally, this is mostly the same zero point I started patching from, but I've made the following changes here after reviewing all this initial code I never looked at closely before. 1. In package-manifest.in for both Basilisk and Pale Moon, I've made the SPARC code for libfreebl not interefere with the x86 code, use the proper build flags, and also updated it to allow a SPARC64 build which is more likely to be used than the 32-bit SPARC code we had there. 2. See Mozilla bug #832272 and the old rules.mk patch from around Firefox 30 in oracle/solaris-userland. I believe they screwed up NSINSTALL on Solaris when they were trying to streamline the NSS buildsystem, because they started having unexplained issues with it around that time after Firefox 22 that they never properly resolved until Mozilla began building NSS with gyp files. I'm actually not even sure how relevant the thing they broke actually is to Solaris at this point, bug 665509 is so old it predates Firefox itself and goes back to the Mozilla suite days. I believe $(INSTALL) -t was wrong, and they meant $(NSINSTALL) -t because that makes more sense and is closer to what was there originally. It's what they have for WINNT, and it's possible a fix more like that could serve for Solaris as well. Alternatively, we could get rid of all these half-broken Makefiles and start building NSS with gyp files like Mozilla did. 3. I've completely cut out support for the Sun compiler and taken into account the reality that everyone builds Firefox (and therefore its forks) with GCC now on Solaris. This alone helped clean up a lot of the uglier parts of the code. 4. I've updated all remaining SOLARIS build flags to the newer XP_SOLARIS, because the SOLARIS flag is no longer set when building Solaris. 5. I've confirmed the workaround in gtxFontconfigFonts.cpp is no longer necessary. The Solaris people got impatient about implementing a half-baked patch for a fontconfig feature that wasn't ready yet back in 2009, and somehow convinced Mozilla to patch their software to work around it when really they should have just fixed or removed their broken fontconfig patch. The feature they wanted has since been implemented properly, and no version of Solaris still uses the broken patch that required this fix. If anyone had ever properly audited this code, it would have been removed a long time ago.
* Issue #1230 - Part 3: Update ReftestsGaming4JC2019-09-28-122/+143
| | | | | Ref: 1434478 part 7 - Update tests and enable some previously temporarily disabled Grid reftests from bug 1427608.
* Issue #1230 - Part 1: Fix Back-computing percentages for intrinsic sizing in ↵Gaming4JC2019-09-28-319/+240
| | | | | | | | | | | | | | | | | | | | | | Layout CSS-Grid List of relevant patches applied: 1398537 part 2 - [css-multicol] Implement percentages for 'column-gap' (Gecko part). 1434478 part 1 - [css-grid] Stop back-computing percentage grid gaps when the percentage basis is indefinite. Treat them as zero sized instead. 1434478 part 2 - Stop back-computing percentage padding/margin when the percentage basis is indefinite. Treat them as zero sized instead. 1434478 part 3 - Remove IntrinsicISizeOffsetData::hPctPadding/hPctMargin members since they are now unused. 1434478 part 4 - Factor out constants like NS_UNCONSTRAINEDSIZE so they can be used in headers without needing nsIFrame.h (idempotent patch). 1434478 part 5 - Create nsLayoutUtils::ResolveToLength for resolving CSS <length-percentage> (idempotent patch). 1434478 part 6 - Propagate a percentage basis to nsIFrame::IntrinsicISizeOffsets for resolving padding/margin. This is needed only for CSS Grid since in other cases we're only using IntrinsicISizeOffsets in the inline-axis and the percentage basis is always indefinite for *intrinsic sizing*. When calculating the intrinsic size of grid items in the grid container's block axis however, we do have a definite size for the grid area in the inline-axis and it should be used per: https://drafts.csswg.org/css-grid/#algo-overview "2. Next, the track sizing algorithm resolves the sizes of the grid rows, using the grid column sizes calculated in the previous step." (Percentage padding/margin for grid items is always resolved against the grid area's inline-size nowadays.)
* Issue #1233 - Part 2: Update ReftestsGaming4JC2019-09-28-142/+3988
| | | | | | | | | | | | | | | | | | List of relevant patches applied: 1425599 part 15 - [css-grid] Test reference fixes + more tests. 1373678 Part 3: Add line number checks to test_grid_implicit.html. 1416350 - Part 3: Add test to verify line numbers of grids with leading implicit tracks. 1416350 - Part 4: Add a reftest of repeat:auto-fit grids with leading implicit tracks. 1417711 - [css-grid] An abs.pos. grid container child that only covers removed 'auto-fit' tracks should not span to the end padding edge. 1416350 - Part 5: Correct the expected results for grids that have leading implicit tracks. 1418727 part 3 - [css-grid] Reftest updates.
* Issue #1233 - Part 1: Fix grid overflow and rendering issues by improving ↵Gaming4JC2019-09-28-278/+383
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Layout CSS-Grid API List of relevant patches applied: 1425599 part 1 - [css-grid] Change the track sizing algorithm for spanning items so that it accumulates individual item contributions to the plan by max() rather than incrementing the planned size directly. Also, fix a bug when copying back the planned limits after updating it for the first span group. It should only copy back track sizes that were actaully spanned by those items, other content-sized tracks' limits should remain at "infinity". 1425599 part 2 - [css-grid] Factor out the min-sizing parts of the track sizing for spanned items to a templated method (idempotent change). 1425599 part 3 - [css-grid] Factor out most of the max-sizing parts of the track sizing for spanned items to a templated method (idempotent change). 1425599 part 4 - [css-grid] Factor out the starting base/limit size to a templated method (idempotent change). 1425599 part 5 - [css-grid] Make CollectGrowable a templated method so that it works with either base/limit sizes (idempotent change). 1425599 part 6 - [css-grid] Make the size distribution methods templated with the intent of merging them in a later patch (idempotent change). This patch also introduces an eInfinitelyGrowable bit to help get rid of the 'limits' temporary track sizes in the next patch. 1425599 part 7 - [css-grid] Remove the 'limits' copy of track sizes since they are no longer needed (idempotent change). 1425599 part 8 - [css-grid] Factor out the fit-content clamping function from DistributeToTrackLimits and pass it as a param instead (idempotent change). 1425599 part 9 - [css-grid] Merge DistributeToTrackLimits/Bases (idempotent change). 1425599 part 10 - [css-grid] Make MarkExcludedTracks a static method since it doesn't use 'this' (idempotent change). 1425599 part 11 - [css-grid] Hoist the marking of excluded tracks out from GrowSelectedTracksUnlimited to a separate method (idempotent change). 1425599 part 12 - [css-grid] Merge CopyPlanToBase/Limits into a templated method instead (idempotent change). 1425599 part 13 - [css-grid] Merge Grow[Base|Limits]ForSpanningItems into a templated method instead (idempotent change). 1425599 part 14 - [css-grid] Use iterators instead of an array + start/end index for the item data (idempotent change). 1425599 part 16 - [css-grid] Make SizeContributionForPhase a template. 1425599 - [css-grid] Follow-up bustage fix for stupid compiler warnings. 1378481 - Assign 'roundingError' in the default branch too, to avoid a maybe-uninitialized compiler warning. 1423292 - [css-grid] Add a couple of ItemState bits to Dump(), and make an ItemState assertion stricter (DEBUG-only changes). 1373678 Part 1: Reduce grid line numbers by count of leading implicit lines, minimum 0. 1416350 - Part 1: Correctly account for removed 'auto-fit' tracks also when there are leading implicit tracks. 1416350 - Part 2: Correct logic for Grid API line numbering with leading implicit tracks. 1418727 part 1 - [css-grid] Introduce StateBitsForRange() that collects the union of the state bits for a range of tracks (idempotent change). 1418727 part 2 - [css-grid] Require that an item spans at least one track with an 'auto' min sizing function for Automatic Minimum Size to apply.
* Issue #438: Revert incorrect changes to w3c-css reftestswolfbeast2019-08-14-4/+4
|
* Issue #438: Add reftests.wolfbeast2019-08-14-0/+27
|
* Issue #438: Make the nsSVGOuterSVGAnonChildFrame a reference frame.wolfbeast2019-08-14-23/+33
| | | | | This causes transforms of the <svg> contents to be unaffected by scrolling / offset changes of the <svg> element.
* Issue #438: Check for non-rectilinear transformswolfbeast2019-08-14-0/+3
|
* Issue #438: Rename coord/coords to originValue/transformOrigin.wolfbeast2019-08-14-13/+13
| | | | For clarity and to prevent typoes.