summaryrefslogtreecommitdiffstats
path: root/js/src
Commit message (Collapse)AuthorAgeLines
* MoonchildProductions#1251 - Part 23: Allow AMD64 build to work.athenian2002019-10-21-2/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Compiling_32-bit_Firefox_on_a_Linux_64-bit_OS Setting this up turned out to be easier than I thought it would be. All I had to do was apply these instructions in reverse and add the following to my .mozconfig file: CC="gcc -m64" CXX="g++ -m64" AS="gas --64" ac_add_options --target=x86_64-pc-solaris2.11 export PKG_CONFIG_PATH=/usr/lib/amd64/pkgconfig ac_add_options --libdir=/usr/lib/amd64 ac_add_options --x-libraries=/usr/lib/amd64 Most of these changes were fairly trivial, just requiring me to make a few of the changes I made earlier conditional on a 32-bit build. The biggest challenge was figuring out why the JavaScript engine triggered a segfault everytime it tried to allocate memory. But this patch fixes it: https://github.com/OpenIndiana/oi-userland/blob/oi/hipster/components/web/firefox/patches/patch-js_src_gc_Memory.cpp.patch Turns out that Solaris on AMD64 handles memory management in a fairly unusual way with a segmented memory model, but it's not that different from what we see on other 64-bit processors. In fact, I saw a SPARC crash for a similar reason, and noticed that it looked just like mine except the numbers in the first segment were reversed. Having played around with hex editors before, I had a feeling I might be dealing with a little-endian version of a big-endian problem, but I didn't expect that knowledge to actually yield an easy solution. https://bugzilla.mozilla.org/show_bug.cgi?id=577056 https://www.oracle.com/technetwork/server-storage/solaris10/solaris-memory-135224.html As far as I can tell, this was the last barrier to an AMD64 Solaris build of Pale Moon.
* Fix a bunch of dumb typos and omissions.athenian2002019-10-21-1/+2
|
* MoonchildProductions#1251 - Part 17: All the libffi and libxul.so issues, ↵athenian2002019-10-21-6/+22
| | | | | | | | | | | | | resolved. https://bugzilla.mozilla.org/show_bug.cgi?id=1185424 http://www.mindfruit.co.uk/2012/06/relocations-relocations.html The libxul.so fix was implemented by Mozilla in Firefox 57 and personally recommended to me by an Oracle employee on the OpenIndiana mailing list. It can easily be made ifdef XP_SOLARIS, but it seems like the new way is considered a better solution overall by the original author of the code that had it use that null pointer hack to begin with. I can't link where I found the fix for libffi because I came up with it myself while looking at the way sysv.S does things. Something clicked in my brain while reading that mindfruit link above, though, and gave me enough of a sense of what was going on to be able to fix libffi. The libffi fix looks a bit hairy because of all the FDE_ENCODE statements, but if you examine the code closely, you should find that it does exactly what it did before on all platforms besides Solaris. I later discovered that people who originally ported Firefox to Solaris never figured this out during the Firefox 52 era and had to use GNU LD for linking libxul.so while using the Sun LD for the rest of the build to make it work. For whatever reason, it works for me now without the GNU LD trick.
* MoonchildProductions#1251 - Part 12: Add Solaris/illumos support to ↵athenian2002019-10-21-2/+7
| | | | | | | WasmSignalHandlers. https://www.illumos.org/issues/5876 https://bugzilla.mozilla.org/show_bug.cgi?id=135050
* MoonchildProductions#1251 - Part 9: Look for hypot in the math library (libm).athenian2002019-10-21-1/+1
| | | | | | | | | | | | | | | https://bugzilla.mozilla.org/show_bug.cgi?id=1351309 https://bugzilla.mozilla.org/show_bug.cgi?id=1309157 I assess this change to be low-risk for the following reasons: 1. It has been in Firefox since version 55 without issues. 2. It's nearly identical to the fix for bug 1309157 which is already in our tree, so that one would be causing problems if this one were going to. 3. Linux, Windows, and BSD are known to have a hypot function in their math libraries. 4. Even if it does break something, it should only break a test and not critical functionality.
* MoonchildProductions#1251 - Part 8: Align pointer for char_16t.athenian2002019-10-21-2/+17
| | | | | | | | https://bugzilla.mozilla.org/show_bug.cgi?id=1352449 Mozilla patch that's been in the code since Firefox 55. Seems like there have been no ill effects from implementing it, and it would only increase the portability of the UXP code. All the Solaris Firefox repos I've seen implement some variation on the jsexn patch, and this seems to be the cleanest version of it. I can add ifdefs if needed or there are performance concerns associated with this patch, but I get the impression this alignment backlog issue might affect a few platforms other than Solaris, though none were named. Otherwise I think they wouldn't have used "platforms that need it" in plural form or failed to ifdef it.
* MoonchildProductions#1251 - Part 7: All the posix_m* memory-related stuff, ↵athenian2002019-10-21-1/+5
| | | | | | | | | | gathered together. https://bugzilla.mozilla.org/show_bug.cgi?id=1158445 https://bugzilla.mozilla.org/show_bug.cgi?id=963983 https://bugzilla.mozilla.org/show_bug.cgi?id=1542758 Solaris madvise and malign don't perfectly map to their POSIX counterparts, and some Linux versions (especially Android) don't define the POSIX counterparts at all, so options are limited. Ideally posix_madvise and posix_malign should be the safer and more portable options for all platforms.
* MoonchildProductions#1251 - Part 1: Restore initial Solaris support, fixed up.athenian2002019-10-21-1/+52
| | | | | | | | | | | | | | Compared with what Pale Moon had for Solaris originally, this is mostly the same zero point I started patching from, but I've made the following changes here after reviewing all this initial code I never looked at closely before. 1. In package-manifest.in for both Basilisk and Pale Moon, I've made the SPARC code for libfreebl not interefere with the x86 code, use the proper build flags, and also updated it to allow a SPARC64 build which is more likely to be used than the 32-bit SPARC code we had there. 2. See Mozilla bug #832272 and the old rules.mk patch from around Firefox 30 in oracle/solaris-userland. I believe they screwed up NSINSTALL on Solaris when they were trying to streamline the NSS buildsystem, because they started having unexplained issues with it around that time after Firefox 22 that they never properly resolved until Mozilla began building NSS with gyp files. I'm actually not even sure how relevant the thing they broke actually is to Solaris at this point, bug 665509 is so old it predates Firefox itself and goes back to the Mozilla suite days. I believe $(INSTALL) -t was wrong, and they meant $(NSINSTALL) -t because that makes more sense and is closer to what was there originally. It's what they have for WINNT, and it's possible a fix more like that could serve for Solaris as well. Alternatively, we could get rid of all these half-broken Makefiles and start building NSS with gyp files like Mozilla did. 3. I've completely cut out support for the Sun compiler and taken into account the reality that everyone builds Firefox (and therefore its forks) with GCC now on Solaris. This alone helped clean up a lot of the uglier parts of the code. 4. I've updated all remaining SOLARIS build flags to the newer XP_SOLARIS, because the SOLARIS flag is no longer set when building Solaris. 5. I've confirmed the workaround in gtxFontconfigFonts.cpp is no longer necessary. The Solaris people got impatient about implementing a half-baked patch for a fontconfig feature that wasn't ready yet back in 2009, and somehow convinced Mozilla to patch their software to work around it when really they should have just fixed or removed their broken fontconfig patch. The feature they wanted has since been implemented properly, and no version of Solaris still uses the broken patch that required this fix. If anyone had ever properly audited this code, it would have been removed a long time ago.
* Merge branch 'master' of https://github.com/MoonchildProductions/UXPMatt A. Tobin2019-10-16-2/+2
|\
| * Replace calls to undefined functions isMarkable() and toMarkablePointer()Dmitry Grigoryev2019-10-10-2/+2
| |
* | Fix build errors with newer glibc versionsMatt A. Tobin2019-10-16-5/+1
|/
* No issue - Update TZ data to 2019cwolfbeast2019-10-02-5/+5
|
* Use the correct group for JIT constraints.wolfbeast2019-09-05-18/+164
| | | | | | | This fixes a rare crash/CTD in JS. This adds information about the constraints to a new RAII class so we can finish all constraints at the end. Based on changes in BZ 1568397
* Fix a crash in IndexedDB.wolfbeast2019-09-04-0/+25
|
* Merge pull request #1196 from g4jc/feed_spidermonkeyMoonchild2019-07-22-6/+6
|\ | | | | Issue #1195 - Fix errant use of JSContext in ErrorNotes
| * Issue #1195 - Fix errant use of JSContext in ErrorNotesGaming4JC2019-07-21-6/+6
| | | | | | | | We want to ensure that ErrorNotes stays on the main thread to prevent a race condition that was introduced in 1283712 - Part 1. This fixes #1195.
* | Remove unused checking function for unboxed types.wolfbeast2019-07-22-34/+0
|/ | | | Tag #1030
* Merge pull request #1192 from g4jc/parser_tuneupMoonchild2019-07-20-3373/+7693
|\ | | | | Issues #816 / #802 - SpiderMonkey Tuneup
| * Fix order of OwnProperty check for rest parameters.Moonchild2019-07-19-1/+1
| | | | | | This was a small mistake when converting from the `hasOwn()` function format (swapped parameters). Fixing this properly makes rest parameters exclude the parameters that are defined (which is the whole point of `...rest`
| * 1353691 - Report SyntaxError when arrow function has await-identifier in ↵Gaming4JC2019-07-18-25/+128
| | | | | | | | async function context.
| * 1344334 - Make DoTypeUpdateFallback infallible.Gaming4JC2019-07-18-1/+22
| |
| * 1339395 - Part 8: Add separate variables for wasm debugger test.Gaming4JC2019-07-18-0/+26
| |
| * 1339395 - Part 7: Remove no longer needed check for jsid strings which are ↵Gaming4JC2019-07-18-42/+4
| | | | | | | | indices from frontend.
| * 1339395 - Part 6: Update jit-tests now that object rest/spread properties ↵Gaming4JC2019-07-18-3/+3
| | | | | | | | are a thing.
| * 1339395 - Part 5: Add Reflect.parse tests for object rest and spread properties.Gaming4JC2019-07-18-0/+74
| |
| * 1339395 - Part 3: Add BytecodeEmitter support for object rest and spread ↵Gaming4JC2019-07-18-45/+339
| | | | | | | | properties.
| * 1339395 - Part 2: Add parser support for rest and spread object properties.Gaming4JC2019-07-18-6/+73
| |
| * Refactor Token& nextTokenGaming4JC2019-07-18-4/+5
| |
| * 1339395 - Part 1: Align parse method for object literals to match array ↵Gaming4JC2019-07-18-183/+199
| | | | | | | | literals.
| * 1344477 - Part 2: Optimize Array.prototype.splice with JSOP_NORVCALL.Gaming4JC2019-07-18-149/+28
| |
| * 1344477 - Part 1: Add JSOP_CALL_IGNORES_RV for function call that ignores ↵Gaming4JC2019-07-18-87/+226
| | | | | | | | return value.
| * Refactor abortIfSyntaxParser after destructringGaming4JC2019-07-18-9/+9
| |
| * 1303703 - Part 3: Syntax parse destructuring assignment patterns.Gaming4JC2019-07-18-198/+202
| |
| * 1303703 - Part 2: Clean-up bits of destructuring parsing which are no longer ↵Gaming4JC2019-07-18-116/+54
| | | | | | | | needed.
| * 1303703 - Part 1: Separate binding pattern parsing from object/array literal ↵Gaming4JC2019-07-18-97/+331
| | | | | | | | parsing.
| * 420857 - Part 4: Report the position of opening bracket for missing bracket ↵Gaming4JC2019-07-18-4/+14
| | | | | | | | error in array literal.
| * 420857 - Part 3: Report the position of opening brace for missing brace ↵Gaming4JC2019-07-18-1/+10
| | | | | | | | error in object literal.
| * 420857 - Part 2: Report the position of opening brace for missing brace ↵Gaming4JC2019-07-18-15/+75
| | | | | | | | error in block.
| * 420857 - Part 1: Report the position of opening brace for missing brace ↵Gaming4JC2019-07-18-6/+71
| | | | | | | | error in function body.
| * 1367204 - Generate "[sourceless code]" for class constructors when ↵Gaming4JC2019-07-18-5/+14
| | | | | | | | sourceIsLazy and no source hook is set.
| * 1357506 - Remove assert that constructorBox can only be set once when ↵Gaming4JC2019-07-18-33/+14
| | | | | | | | | | | | | | parsing classes. Both asm.js and syntax parsing can abort and rewind parsing of an inner function. The bookkeeping to make sure that a class's constructor FunctionBox is only set once is not worth it -- duplicate constructor definitions already throw an early error.
| * 1359622 - Fix assert for calling Function.toString on class constructors ↵Gaming4JC2019-07-18-2/+8
| | | | | | | | when the compartment has had source discarded.
| * Bug 1364573 - Don't relazify class default constructors.Gaming4JC2019-07-18-0/+1
| | | | | | | | | | Because of the wacko way we handle toString offsets for class default constructors, those offsets cannot be recovered if we relazify the functions. Luckily there's no reason to relazify them, their JSScripts are very small: either a single 'retrval' for non-derived, and still fairly small for derived.
| * 1357483 - Stop changing the end position of parenthesized expression ParseNodes.Gaming4JC2019-07-18-1/+8
| |
| * 1216630 - Rename preludeStart and postludeEnd to toStringStart and ↵Gaming4JC2019-07-18-129/+151
| | | | | | | | toStringEnd and misc fixes.
| * 1216630 - Print class source when calling toString on the constructor.Gaming4JC2019-07-18-74/+248
| | | | | | | | | | | | | | | | | | | | This is accomplished in the following ways. LazyScripts and JSScripts now have 4 offsets: - Source begin and end for the actual source. This is used for lazy parsing. - toString begin and end for toString. Some kinds of functions, like async, only have a different begin offset. Class constructors have different offsets for both begin and end. For syntactically present (i.e. non-default) constructors, the class source span is remembered directly on the LazyScript or JSScript. The toString implementation then splices out the substring directly. For default constructors, a new SRC_CLASS SrcNote type is added. It's binary and has as its arguments the begin and end offsets of the class expression or statement. MakeDefaultConstructor reads the note and overrides the cloned self-hosted function's source object. This is probably the least intrusive way to accomplish this.
| * 1340148 - Disallow function redeclarations at module top level.Gaming4JC2019-07-18-5/+121
| |
| * 104442 - Part 1: Report the position and the kind of previous declaration ↵Gaming4JC2019-07-18-35/+330
| | | | | | | | for redeclaration error.
| * 1342273 - Improve frontend tracelogging. [PARTIAL] Only implemented const to ↵Gaming4JC2019-07-18-16/+18
| | | | | | | | rvalue changes, no tracelogging
| * 1339963 - Part 3: Check IdentifierName in ExportClause without from.Gaming4JC2019-07-18-2/+77
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-11 09:07:09 +0000