| Commit message (Collapse) | Author | Age | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In fact, this is a security threat.
This function calls 'arc4random_addrandom', which was removed from the
reference implementation 7 years go [1], on the ground that this was in fact an
internal interface which is almost impossible to use correctly. This update has
since then been propagated to other implementations (e.g., FreeBSD, IllumOS,
Android).
Do this for all platforms, since 'evutil_secure_rng_add_bytes' is not even used
in the current tree, and for the reason stated above, should never be.
Related bugs at Mozilla and libevent: Links [2] and [3] below.
[1] http://marc.info/?l=openbsd-cvs&m=138238762705209&w=2
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=931354
[3] https://sourceforge.net/p/levent/bugs/320/
|
| |
|
|
|
|
| |
Removing the vim line unintentionally broke the comment leading to build failure, this restores the comment.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Since these are just interpreted comments, there's 0 impact on actual code.
This removes all lines that match /* vim: set(.*)tw=80: */ with S&R -- there are
a few others scattered around which will be removed manually in a second part.
|
|
|
|
| |
Tag: #1542
|
|
|
|
|
|
| |
ipc/testshell/XPCShellEnvironment.cpp
.. correctly
|
|
|
|
|
|
| |
ipc/testshell/XPCShellEnvironment.cpp"
This reverts commit d4afddfadab3108c26c8cab274d2cb32847c4d95.
|
|
|
|
| |
ipc/testshell/XPCShellEnvironment.cpp
|
|
|
|
|
| |
Correct various pre-processor defines for sparc64 and in mozjemalloc use the JS arm64 allocator on Linux/sparc64.
This corrects build problems opn Linux sparc64 and is in line with bugzilla bug #1275204.
|
|
|
|
| |
This reverts commit 6a3d5769d01ec1a8dd56ea79aec2df91b801ce02.
|
| |
|
|
|
|
| |
This does not include android in the imported chromium code as specific research needs done on defines and logic.
|
|
|
|
|
|
| |
This adds an addition to the environment set up for child processes
(plugin container) so that it may still be able to pass the omni
parameters there as-needed.
|
| |
|
|
|
|
| |
ipc/chromium/moz.build
|
|
|
|
| |
I made a typo in commit 687a789 when updating the ifdef style I used to comply with UXP standards. The typo I made resulted in a compiler warning I failed to notice, so I was asked to tag issue #457 when submitting the PR. I also fixed some trailing whitespace I apparently left behind in the file.
|
|
|
|
| |
I hope this addresses everything.
|
|
|
|
| |
This should do it for all the commits to files I changed, but while I'm in here I could probably go ahead and turn ALL the singular if defined statements into ifdef statements by using grep/find on the tree. On the other hand, perhaps we should do that as a separate issue so that this doesn't become a case of scope creep.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Compiling_32-bit_Firefox_on_a_Linux_64-bit_OS
Setting this up turned out to be easier than I thought it would be. All I had to do was apply these instructions in reverse and add the following to my .mozconfig file:
CC="gcc -m64"
CXX="g++ -m64"
AS="gas --64"
ac_add_options --target=x86_64-pc-solaris2.11
export PKG_CONFIG_PATH=/usr/lib/amd64/pkgconfig
ac_add_options --libdir=/usr/lib/amd64
ac_add_options --x-libraries=/usr/lib/amd64
Most of these changes were fairly trivial, just requiring me to make a few of the changes I made earlier conditional on a 32-bit build. The biggest challenge was figuring out why the JavaScript engine triggered a segfault everytime it tried to allocate memory. But this patch fixes it:
https://github.com/OpenIndiana/oi-userland/blob/oi/hipster/components/web/firefox/patches/patch-js_src_gc_Memory.cpp.patch
Turns out that Solaris on AMD64 handles memory management in a fairly unusual way with a segmented memory model, but it's not that different from what we see on other 64-bit processors. In fact, I saw a SPARC crash for a similar reason, and noticed that it looked just like mine except the numbers in the first segment were reversed. Having played around with hex editors before, I had a feeling I might be dealing with a little-endian version of a big-endian problem, but I didn't expect that knowledge to actually yield an easy solution.
https://bugzilla.mozilla.org/show_bug.cgi?id=577056
https://www.oracle.com/technetwork/server-storage/solaris10/solaris-memory-135224.html
As far as I can tell, this was the last barrier to an AMD64 Solaris build of Pale Moon.
|
|
|
|
|
|
|
|
|
|
| |
from IPC process_util.
https://bugzilla.mozilla.org/show_bug.cgi?id=1397928
Was looking into that _POSIX_PATH_MAX/NAME_MAX issue earlier because it didn't make a lot of sense and I was thinking of other approaches besides char arrays, and I wanted to make sure it didn't cause problems after they did it. Turns out that one commit after this was added, Mozilla determined the code I was working on fixing to be dead code as of Firefox 58. I don't know if it's dead code in Pale Moon as well, but given that it compiles fine without it and I can't find any other references to szExeFile in the IPC code, that seems like a safe bet.
Besides, I determined config/pathsub.c already seems to do what this code looks like it's trying to do, and implements the solution of just defining NAME_MAX to 256 and having done with it that I nearly adopted after realizing that even OS/2 and BeOS, let alone Unix/Linux systems, all basically use that value and there's just disagreement on which system header to check for it.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugzilla.mozilla.org/show_bug.cgi?id=1345102
I assess this change to be low-risk for the following reasons:
1. It has been in Firefox since version 55 without issues.
2. The current behavior is not POSIX compliant, and is retained in the one instance where the new functionality causes issues.
3. It makes safer assumptions about implementation details than what we have now.
|
|
|
|
| |
Current versions of libcubeb already have a Sun audio implementation, but in Firefox 52 and earlier, this was all they had. I'm not completely happy with this implementation because it has issues like video freezing if the soundcard isn't working, but I think fixing this or pulling in a newer libcubeb would be going too far for too little gain.
|
|
|
|
|
|
|
|
| |
process_util.h.
https://bugzilla.mozilla.org/show_bug.cgi?id=1364865
Solaris doesn't define NAME_MAX because if you read the current POSIX standard literally, no system that supports multiple file systems or networking should be defining it. It's a pedantic choice given that they USED to define NAME_MAX, but Solaris always did take POSIX compliance seriously, for better or worse.
|
|
|
|
|
|
|
|
| |
libevent/IPC junk.
This is mostly ifdefs, but as you can see, Solaris is actually a lot like Linux. They're both more SysV than BSD at core, and most of the differences have more to do with Solaris not using glibc than anything else.
I still need to audit a lot of these changes and understand why they're needed and what the alternative approaches are. After this patch, most of the core functionality needed to build Solaris is here.
|
|
|
|
| |
Resolves #20
|
|
|
|
| |
Tag #20
|
| |
|
| |
|
| |
|
|
|
|
|
| |
This creates a number of stubs and leaves some surrounding code that may be irrelevant (eg. recorded time stamps, status variables).
Stub resolution/removal should be a follow-up to this.
|
|
|
|
| |
Follow-up to a930db1c9e8444ed89754c5a79085d59c7295952
|
| |
|
|
|
|
| |
Roll-up of bugs 1442722, 1455071, 1433642, 1456604 and 1458320.
|
| |
|
|
|
|
| |
Tag #20.
|
|
|
|
| |
Tag #288.
|
|
|
|
| |
Tag #288
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
tests)
https://github.com/MoonchildProductions/moebius/pull/230
|
|
|
|
|
|
| |
tests)
https://github.com/MoonchildProductions/moebius/pull/226
|
| |
|
| |
|
| |
|