summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
* MoonchildProductions#1251 - Part 15: fdlibm should provide definition for ↵athenian2002019-10-21-2/+6
| | | | | | | | | | | | | | | | u_int32_t and u_int64_t. https://bugzilla.mozilla.org/show_bug.cgi?id=1350355 u_int32_t is not an stdint.h type. Windows already requires this, Solaris needs it too. If someone has a nit with this approach, the alternatives include: 1. Just replacing every instance of u_int32_t with uint32_t. 2. Including <sys/types.h> for Solaris only, which does define this. 3. Changing the original ifdef to be WIN32 || XP_SOLARIS But it really doesn't matter how you solve this problem, all of the approaches are functionally equivalent, and this one has been used in Firefox since version 55. As far as I can tell, all it does is apply a fix that was being done for Windows already to any platform that needs it.
* MoonchildProductions#1251 - Part 14: libstagefright build should avoid ↵athenian2002019-10-21-1/+1
| | | | | | | | _GLIBCXX_OS_DEFINES. https://bugzilla.mozilla.org/show_bug.cgi?id=1367775 Windows already requires this ifdef, Solaris needs it too. Not much more to say, but I can do research and follow up on this if asked.
* MoonchildProductions#1251 - Part 13: Redefining abort in C++ requires extern "C"athenian2002019-10-21-1/+1
| | | | | | | | https://bugzilla.mozilla.org/show_bug.cgi?id=1375467 I would ifdef this, but it's been in Firefox since version of 56, and Petr Sumbara's explanation as to why it's wrong in the first place is so detailed that it's pretty obvious the code wasn't technically doing things properly to begin with. Basically, they tried to redefine a system function after including the header file that declares it, and it caused problems on Solaris because libc functions are imported into the C++ std namespace in a different way that also complies with standards. So the existing implementation is technically bad code on all platforms, the Solaris implementation just uncovered the lack of standards compliance in the Mozilla code.
* MoonchildProductions#1251 - Part 12: Add Solaris/illumos support to ↵athenian2002019-10-21-2/+7
| | | | | | | WasmSignalHandlers. https://www.illumos.org/issues/5876 https://bugzilla.mozilla.org/show_bug.cgi?id=135050
* MoonchildProductions#1251 - Part 11: libpng uses C89 now to avoid buffer ↵athenian2002019-10-21-1/+4
| | | | | | | | | overflows. https://bugzilla.mozilla.org/show_bug.cgi?id=1371266 https://github.com/glennrp/libpng/commit/12e63e91af1378225993b36e25ce3252b54e751a This sounds absurd, and the fact that we had to change a C++ comment to a C-style comment on account of this may seem hilarious and inconsequential, but this isapparently not a joke and leaving it as it is now may be a bad idea.
* MoonchildProductions#1251 - Part 10: ipc_channel_posix.cc should use IOV_MAX.athenian2002019-10-21-1/+10
| | | | | | | | | | | | https://bugzilla.mozilla.org/show_bug.cgi?id=1345102 I assess this change to be low-risk for the following reasons: 1. It has been in Firefox since version 55 without issues. 2. The current behavior is not POSIX compliant, and is retained in the one instance where the new functionality causes issues. 3. It makes safer assumptions about implementation details than what we have now.
* MoonchildProductions#1251 - Part 9: Look for hypot in the math library (libm).athenian2002019-10-21-1/+1
| | | | | | | | | | | | | | | https://bugzilla.mozilla.org/show_bug.cgi?id=1351309 https://bugzilla.mozilla.org/show_bug.cgi?id=1309157 I assess this change to be low-risk for the following reasons: 1. It has been in Firefox since version 55 without issues. 2. It's nearly identical to the fix for bug 1309157 which is already in our tree, so that one would be causing problems if this one were going to. 3. Linux, Windows, and BSD are known to have a hypot function in their math libraries. 4. Even if it does break something, it should only break a test and not critical functionality.
* MoonchildProductions#1251 - Part 8: Align pointer for char_16t.athenian2002019-10-21-2/+17
| | | | | | | | https://bugzilla.mozilla.org/show_bug.cgi?id=1352449 Mozilla patch that's been in the code since Firefox 55. Seems like there have been no ill effects from implementing it, and it would only increase the portability of the UXP code. All the Solaris Firefox repos I've seen implement some variation on the jsexn patch, and this seems to be the cleanest version of it. I can add ifdefs if needed or there are performance concerns associated with this patch, but I get the impression this alignment backlog issue might affect a few platforms other than Solaris, though none were named. Otherwise I think they wouldn't have used "platforms that need it" in plural form or failed to ifdef it.
* MoonchildProductions#1251 - Part 7: All the posix_m* memory-related stuff, ↵athenian2002019-10-21-6/+33
| | | | | | | | | | gathered together. https://bugzilla.mozilla.org/show_bug.cgi?id=1158445 https://bugzilla.mozilla.org/show_bug.cgi?id=963983 https://bugzilla.mozilla.org/show_bug.cgi?id=1542758 Solaris madvise and malign don't perfectly map to their POSIX counterparts, and some Linux versions (especially Android) don't define the POSIX counterparts at all, so options are limited. Ideally posix_madvise and posix_malign should be the safer and more portable options for all platforms.
* MoonchildProductions#1251 - Part 6: Solaris needs an audio implementation.athenian2002019-10-21-0/+520
| | | | Current versions of libcubeb already have a Sun audio implementation, but in Firefox 52 and earlier, this was all they had. I'm not completely happy with this implementation because it has issues like video freezing if the soundcard isn't working, but I think fixing this or pulling in a newer libcubeb would be going too far for too little gain.
* MoonchildProductions#1251 - Part 5: Fix POSIX compliance issue in ↵athenian2002019-10-21-1/+3
| | | | | | | | process_util.h. https://bugzilla.mozilla.org/show_bug.cgi?id=1364865 Solaris doesn't define NAME_MAX because if you read the current POSIX standard literally, no system that supports multiple file systems or networking should be defining it. It's a pedantic choice given that they USED to define NAME_MAX, but Solaris always did take POSIX compliance seriously, for better or worse.
* MoonchildProductions#1251 - Part 4: Core build system changes, lots of ↵athenian2002019-10-21-32/+682
| | | | | | | | libevent/IPC junk. This is mostly ifdefs, but as you can see, Solaris is actually a lot like Linux. They're both more SysV than BSD at core, and most of the differences have more to do with Solaris not using glibc than anything else. I still need to audit a lot of these changes and understand why they're needed and what the alternative approaches are. After this patch, most of the core functionality needed to build Solaris is here.
* MoonchildProductions#1251 - Part 3: Finally end the long tradition of ↵athenian2002019-10-21-1/+15
| | | | | | | | | | | casting getpid() to int. https://bugzilla.mozilla.org/show_bug.cgi?id=535106 https://bugzilla.mozilla.org/show_bug.cgi?id=1359841 Like many parts of the busted Solaris support, this one has its origins in the pre-Firefox days. Bug 535106, another Mozilla suite bug. It keeps coming up because the core issue is never addressed, the fact that nsTSubstring doesn't know how to handle pid_t. I think the explicit cast to int is a band-aid they use because they know if they touch that substring header file to make it handle pid_t, they'll probably be asked to fix all the other problems with it. I honestly think it just works by accident on other platforms because it's implicitly cast to signed or unsigned int, even though the POSIX standard says pid_t can be either long or int, and work as either a signed or unsigned integer. Whatever the case may be, it's handled better on Solaris now than it was. Ironically enough, the main point of having pid_t rather than just having pids be int or something is to hide this little implementation detail so you can just use pid_t for the return type in portable code without having to worry about what it is on a specific platform. The unfortunate way Mozilla implemented string functions turns that on its head and makes the good things about pid_t into liabilities rather than assets.
* MoonchildProductions#1251 - Part 2: Make the mozconfig loader POSIX-compliant.athenian2002019-10-21-20/+18
| | | | | | https://bugzilla.mozilla.org/show_bug.cgi?id=1360571 Solaris uses ksh as the default shell, and furthermore bash doesn't seem to support the 'local' keyword feature when invoked as sh on OpenIndiana. We could just change the script to use bash (it is an option even on Solaris), but this fix is available and Mozilla has been using it since Firefox 55 with no issues on any other platforms. It was specfically done this way to avoid any need to change existing mozconfig files, so I feel confident saying the change is totally benign and if anything the way it is now is technically a POSIX compliance issue inherited from Mozilla that we'll hit if we ever try to compile this on any Unix platform where bash isn't sh.
* MoonchildProductions#1251 - Part 1: Restore initial Solaris support, fixed up.athenian2002019-10-21-21/+945
| | | | | | | | | | | | | | Compared with what Pale Moon had for Solaris originally, this is mostly the same zero point I started patching from, but I've made the following changes here after reviewing all this initial code I never looked at closely before. 1. In package-manifest.in for both Basilisk and Pale Moon, I've made the SPARC code for libfreebl not interefere with the x86 code, use the proper build flags, and also updated it to allow a SPARC64 build which is more likely to be used than the 32-bit SPARC code we had there. 2. See Mozilla bug #832272 and the old rules.mk patch from around Firefox 30 in oracle/solaris-userland. I believe they screwed up NSINSTALL on Solaris when they were trying to streamline the NSS buildsystem, because they started having unexplained issues with it around that time after Firefox 22 that they never properly resolved until Mozilla began building NSS with gyp files. I'm actually not even sure how relevant the thing they broke actually is to Solaris at this point, bug 665509 is so old it predates Firefox itself and goes back to the Mozilla suite days. I believe $(INSTALL) -t was wrong, and they meant $(NSINSTALL) -t because that makes more sense and is closer to what was there originally. It's what they have for WINNT, and it's possible a fix more like that could serve for Solaris as well. Alternatively, we could get rid of all these half-broken Makefiles and start building NSS with gyp files like Mozilla did. 3. I've completely cut out support for the Sun compiler and taken into account the reality that everyone builds Firefox (and therefore its forks) with GCC now on Solaris. This alone helped clean up a lot of the uglier parts of the code. 4. I've updated all remaining SOLARIS build flags to the newer XP_SOLARIS, because the SOLARIS flag is no longer set when building Solaris. 5. I've confirmed the workaround in gtxFontconfigFonts.cpp is no longer necessary. The Solaris people got impatient about implementing a half-baked patch for a fontconfig feature that wasn't ready yet back in 2009, and somehow convinced Mozilla to patch their software to work around it when really they should have just fixed or removed their broken fontconfig patch. The feature they wanted has since been implemented properly, and no version of Solaris still uses the broken patch that required this fix. If anyone had ever properly audited this code, it would have been removed a long time ago.
* Issue #1229 - Remove fallback for $INSTDIRwolfbeast2019-10-21-15/+0
| | | | This resolves #1229
* Issue #1231 - Correct defines for Mac and keep universal prefs generic.wolfbeast2019-10-21-6/+6
|
* Merge pull request #1249 from g4jc/nss_exportsNew Tobin Paradigm2019-10-18-0/+2
|\ | | | | Issue #1243 - Update List of NSS Exported Symbols
| * Issue #1243 - Update List of NSS Exported SymbolsGaming4JC2019-10-17-0/+2
|/ | | | Add NSS_CMSSignedData_GetDigestAlgs and NSS_CMSSignedData_hasDigests which are required for security patches in mailnews applications. Ref: m-c bug 1526473
* Merge branch 'master' of https://github.com/MoonchildProductions/UXPMatt A. Tobin2019-10-16-3/+3
|\
| * Merge pull request #1246 from dimag0g/masterMoonchild2019-10-12-2/+2
| |\ | | | | | | Replace calls to undefined functions isMarkable() and toMarkablePointer()
| | * Replace calls to undefined functions isMarkable() and toMarkablePointer()Dmitry Grigoryev2019-10-10-2/+2
| |/
| * No Issue - Expand HWA over RDP to Windows 8.1 and 10.wolfbeast2019-10-08-1/+1
| | | | | | | | | | | | | | When Mozilla implemented this initially, only Windows 8 existed. Because of the strict equal check, 8.1 and 10 didn't get HWA over RDP while they are perfectly capable of doing so with RemoteFX. This change allows any version of Windows from 8.0 onwards to use HWA over RDP.
* | Don't treat format warnings as errors in xpconnectMatt A. Tobin2019-10-16-1/+1
| | | | | | | | GCC 9 compiler does not like the way we have it in XPCWrappedNative.cpp
* | Fix build errors with newer glibc versionsMatt A. Tobin2019-10-16-14/+4
|/
* Merge pull request #1244 from dimag0g/masterMoonchild2019-10-06-0/+3
|\ | | | | Added missing libwebp files to update.sh
| * Added missing libwebp files to update.shDmitry Grigoryev2019-10-04-0/+3
|/
* No issue - Update TZ data to 2019cwolfbeast2019-10-02-106/+103
|
* Merge pull request #1238 from dimag0g/masterMoonchild2019-09-30-0/+814
|\ | | | | Add libwebp NEON-specific files
| * Merge branch 'master' of https://github.com/dimag0g/UXPDmitry Grigoryev2019-09-28-1/+11
| |\
| * | Added missing libwebp NEON filesDmitry Grigoryev2019-09-28-0/+814
| | |
* | | Merge pull request #1237 from g4jc/css-workMoonchild2019-09-29-881/+4947
|\ \ \ | |_|/ |/| | CSS Grid Improvements
| * | Issue #1230 - Part 3: Update ReftestsGaming4JC2019-09-28-122/+143
| | | | | | | | | | | | | | | Ref: 1434478 part 7 - Update tests and enable some previously temporarily disabled Grid reftests from bug 1427608.
| * | Issue #1230 - Part 2: Align devtools to the changes in css-gridGaming4JC2019-09-28-2/+4
| | | | | | | | | | | | | | | Ref: 1398537 part 4 - [css-multicol] Implement percentages for 'column-gap' (automated update of devtools).
| * | Issue #1230 - Part 1: Fix Back-computing percentages for intrinsic sizing in ↵Gaming4JC2019-09-28-319/+240
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Layout CSS-Grid List of relevant patches applied: 1398537 part 2 - [css-multicol] Implement percentages for 'column-gap' (Gecko part). 1434478 part 1 - [css-grid] Stop back-computing percentage grid gaps when the percentage basis is indefinite. Treat them as zero sized instead. 1434478 part 2 - Stop back-computing percentage padding/margin when the percentage basis is indefinite. Treat them as zero sized instead. 1434478 part 3 - Remove IntrinsicISizeOffsetData::hPctPadding/hPctMargin members since they are now unused. 1434478 part 4 - Factor out constants like NS_UNCONSTRAINEDSIZE so they can be used in headers without needing nsIFrame.h (idempotent patch). 1434478 part 5 - Create nsLayoutUtils::ResolveToLength for resolving CSS <length-percentage> (idempotent patch). 1434478 part 6 - Propagate a percentage basis to nsIFrame::IntrinsicISizeOffsets for resolving padding/margin. This is needed only for CSS Grid since in other cases we're only using IntrinsicISizeOffsets in the inline-axis and the percentage basis is always indefinite for *intrinsic sizing*. When calculating the intrinsic size of grid items in the grid container's block axis however, we do have a definite size for the grid area in the inline-axis and it should be used per: https://drafts.csswg.org/css-grid/#algo-overview "2. Next, the track sizing algorithm resolves the sizes of the grid rows, using the grid column sizes calculated in the previous step." (Percentage padding/margin for grid items is always resolved against the grid area's inline-size nowadays.)
| * | Issue #1233 - Part 2: Update ReftestsGaming4JC2019-09-28-145/+4150
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | List of relevant patches applied: 1425599 part 15 - [css-grid] Test reference fixes + more tests. 1373678 Part 3: Add line number checks to test_grid_implicit.html. 1416350 - Part 3: Add test to verify line numbers of grids with leading implicit tracks. 1416350 - Part 4: Add a reftest of repeat:auto-fit grids with leading implicit tracks. 1417711 - [css-grid] An abs.pos. grid container child that only covers removed 'auto-fit' tracks should not span to the end padding edge. 1416350 - Part 5: Correct the expected results for grids that have leading implicit tracks. 1418727 part 3 - [css-grid] Reftest updates.
| * | Issue #1233 - Part 1: Fix grid overflow and rendering issues by improving ↵Gaming4JC2019-09-28-293/+410
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Layout CSS-Grid API List of relevant patches applied: 1425599 part 1 - [css-grid] Change the track sizing algorithm for spanning items so that it accumulates individual item contributions to the plan by max() rather than incrementing the planned size directly. Also, fix a bug when copying back the planned limits after updating it for the first span group. It should only copy back track sizes that were actaully spanned by those items, other content-sized tracks' limits should remain at "infinity". 1425599 part 2 - [css-grid] Factor out the min-sizing parts of the track sizing for spanned items to a templated method (idempotent change). 1425599 part 3 - [css-grid] Factor out most of the max-sizing parts of the track sizing for spanned items to a templated method (idempotent change). 1425599 part 4 - [css-grid] Factor out the starting base/limit size to a templated method (idempotent change). 1425599 part 5 - [css-grid] Make CollectGrowable a templated method so that it works with either base/limit sizes (idempotent change). 1425599 part 6 - [css-grid] Make the size distribution methods templated with the intent of merging them in a later patch (idempotent change). This patch also introduces an eInfinitelyGrowable bit to help get rid of the 'limits' temporary track sizes in the next patch. 1425599 part 7 - [css-grid] Remove the 'limits' copy of track sizes since they are no longer needed (idempotent change). 1425599 part 8 - [css-grid] Factor out the fit-content clamping function from DistributeToTrackLimits and pass it as a param instead (idempotent change). 1425599 part 9 - [css-grid] Merge DistributeToTrackLimits/Bases (idempotent change). 1425599 part 10 - [css-grid] Make MarkExcludedTracks a static method since it doesn't use 'this' (idempotent change). 1425599 part 11 - [css-grid] Hoist the marking of excluded tracks out from GrowSelectedTracksUnlimited to a separate method (idempotent change). 1425599 part 12 - [css-grid] Merge CopyPlanToBase/Limits into a templated method instead (idempotent change). 1425599 part 13 - [css-grid] Merge Grow[Base|Limits]ForSpanningItems into a templated method instead (idempotent change). 1425599 part 14 - [css-grid] Use iterators instead of an array + start/end index for the item data (idempotent change). 1425599 part 16 - [css-grid] Make SizeContributionForPhase a template. 1425599 - [css-grid] Follow-up bustage fix for stupid compiler warnings. 1378481 - Assign 'roundingError' in the default branch too, to avoid a maybe-uninitialized compiler warning. 1423292 - [css-grid] Add a couple of ItemState bits to Dump(), and make an ItemState assertion stricter (DEBUG-only changes). 1373678 Part 1: Reduce grid line numbers by count of leading implicit lines, minimum 0. 1416350 - Part 1: Correctly account for removed 'auto-fit' tracks also when there are leading implicit tracks. 1416350 - Part 2: Correct logic for Grid API line numbering with leading implicit tracks. 1418727 part 1 - [css-grid] Introduce StateBitsForRange() that collects the union of the state bits for a range of tracks (idempotent change). 1418727 part 2 - [css-grid] Require that an item spans at least one track with an 'auto' min sizing function for Automatic Minimum Size to apply.
* | Merge pull request #1232 from adeshkp/disable-color-mgmt-linuxMoonchild2019-09-24-1/+8
|\ \ | | | | | | Issue #1231 - Stop using ICC profiles on Linux.
| * | Issue #1231 - Stop using ICC profiles on Linux.adeshkp2019-09-24-1/+8
|/ / | | | | | | | | General consensus seems to be that color management on Linux desktops is not mature enough to enable by default.
* / No issue - Add 360 Safeguard to DLL blocklistMoonchild2019-09-17-0/+3
|/ | | | | 360 Safeguard/360 Total Security (Qihoo) causes crashes in a11y components. This adds the offending dll to the injection blocklist. See BZ bug 1536227 for details.
* Issue #1226 - Explicitly enable sse2 on x86_64 also.wolfbeast2019-09-10-1/+1
| | | | | | Although it's enabled by default in gcc (should be, anyway!), we're being explicit here for 64-bit x86 platforms here also. This matches the old behavior.
* Don't assume Intel architecture for compiler optimizations on Linux/gcc.wolfbeast2019-09-10-2/+7
| | | | | This only adds SSE2 flags when the CPU architecture is correct for it. Resolves #1226
* Fix whitelisting of JavaScript-uris by CSP hash.wolfbeast2019-09-05-2/+13
|
* Properly implement various HSTS states.wolfbeast2019-09-05-16/+27
| | | | | | | | Previously, HSTS preload list values could be overridden temporarily due to counter-intuitive behavior of the API's removeState function. This adds an explicit flag to the API for writing knockout values to the Site Security Service, with the default resetting to whatever the preload list state is.
* Use the correct group for JIT constraints.wolfbeast2019-09-05-18/+164
| | | | | | | This fixes a rare crash/CTD in JS. This adds information about the constraints to a new RAII class so we can finish all constraints at the end. Based on changes in BZ 1568397
* Ensure the right body element is used throughout the method call.Olli Pettay2019-09-05-3/+3
|
* Add checks to respect CSP-wildcard + Ports.Sebastian Streich2019-09-05-14/+18
|
* Fix a crash in IndexedDB.wolfbeast2019-09-04-39/+102
|
* Kill newly-spawned threads if we're shutting down.Nathan Froyd2019-09-04-1/+3
|
* Remove HTML5 parser java docs and generation code.wolfbeast2019-09-04-20210/+0
| | | | | java->C++ automated translation is not something we want to deal with now or in the future.
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-03 14:09:04 +0000