summaryrefslogtreecommitdiffstats
path: root/netwerk
diff options
context:
space:
mode:
Diffstat (limited to 'netwerk')
-rw-r--r--netwerk/base/nsIOService.cpp31
-rw-r--r--netwerk/base/nsSocketTransportService2.cpp176
-rw-r--r--netwerk/base/nsSocketTransportService2.h38
-rw-r--r--netwerk/protocol/http/nsHttpHandler.cpp32
4 files changed, 183 insertions, 94 deletions
diff --git a/netwerk/base/nsIOService.cpp b/netwerk/base/nsIOService.cpp
index 314f2aeff..a953dc78c 100644
--- a/netwerk/base/nsIOService.cpp
+++ b/netwerk/base/nsIOService.cpp
@@ -108,6 +108,7 @@ int16_t gBadPortList[] = {
42, // name
43, // nicname
53, // domain
+ 69, // TFTP
77, // priv-rjs
79, // finger
87, // ttylink
@@ -125,8 +126,10 @@ int16_t gBadPortList[] = {
119, // nntp
123, // NTP
135, // loc-srv / epmap
+ 137, // netbios
139, // netbios
143, // imap2
+ 161, // SNMP
179, // BGP
389, // ldap
465, // smtp+ssl
@@ -138,24 +141,32 @@ int16_t gBadPortList[] = {
530, // courier
531, // Chat
532, // netnews
- 540, // uucp
+ 540, // uucp
+ 554, // rtsp
556, // remotefs
563, // nntp+ssl
- 587, //
- 601, //
+ 587, // smtp (outgoing)
+ 601, // syslog-conn
636, // ldap+ssl
993, // imap+ssl
995, // pop3+ssl
+ 1719, // h323 (RAS)
+ 1720, // h323 (hostcall)
+ 1723, // pptp
2049, // nfs
- 3659, // apple-sasl / PasswordServer
+ 3659, // apple-sasl / PasswordServer
4045, // lockd
+ 5060, // sip
+ 5061, // sips
6000, // x11
- 6665, // Alternate IRC [Apple addition]
- 6666, // Alternate IRC [Apple addition]
- 6667, // Standard IRC [Apple addition]
- 6668, // Alternate IRC [Apple addition]
- 6669, // Alternate IRC [Apple addition]
- 0, // This MUST be zero so that we can populating the array
+ 6566, // SANE
+ 6665, // Alternate IRC [Apple addition]
+ 6666, // Alternate IRC [Apple addition]
+ 6667, // Standard IRC [Apple addition]
+ 6668, // Alternate IRC [Apple addition]
+ 6669, // Alternate IRC [Apple addition]
+ 10080,// Amanda
+ 0, // Sentinel value: This MUST be zero
};
static const char kProfileChangeNetTeardownTopic[] = "profile-change-net-teardown";
diff --git a/netwerk/base/nsSocketTransportService2.cpp b/netwerk/base/nsSocketTransportService2.cpp
index 4a8d80eed..956332953 100644
--- a/netwerk/base/nsSocketTransportService2.cpp
+++ b/netwerk/base/nsSocketTransportService2.cpp
@@ -1,4 +1,3 @@
-// vim:set sw=4 sts=4 et cin:
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
@@ -43,6 +42,7 @@ Atomic<PRThread*, Relaxed> gSocketThread;
#define KEEPALIVE_PROBE_COUNT_PREF "network.tcp.keepalive.probe_count"
#define SOCKET_LIMIT_TARGET 1000U
#define SOCKET_LIMIT_MIN 50U
+#define SOCKET_CLAMP_PREF "network.websocket.timeout.clamped"
#define BLIP_INTERVAL_PREF "network.activity.blipIntervalMilliseconds"
#define MAX_TIME_BETWEEN_TWO_POLLS "network.sts.max_time_for_events_between_two_polls"
#define MAX_TIME_FOR_PR_CLOSE_DURING_SHUTDOWN "network.sts.max_time_for_pr_close_during_shutdown"
@@ -53,6 +53,51 @@ uint32_t nsSocketTransportService::gMaxCount;
PRCallOnceType nsSocketTransportService::gMaxCountInitOnce;
//-----------------------------------------------------------------------------
+bool
+nsSocketTransportService::SocketContext::IsTimedOut(PRIntervalTime now) const
+{
+ return TimeoutIn(now) == 0;
+}
+
+void
+nsSocketTransportService::SocketContext::StartTimeout(PRIntervalTime now)
+{
+ if (!mPollStartEpoch) {
+ mPollStartEpoch = now;
+ }
+}
+
+void
+nsSocketTransportService::SocketContext::StopTimeout()
+{
+ mPollStartEpoch = 0;
+}
+
+void
+nsSocketTransportService::SocketContext::ResetTimeout()
+{
+ if (mPollStartEpoch && mHandler->mPollTimeout == UINT16_MAX) {
+ mPollStartEpoch = 0;
+ }
+}
+
+PRIntervalTime
+nsSocketTransportService::SocketContext::TimeoutIn(PRIntervalTime now) const
+{
+ if (mHandler->mPollTimeout == UINT16_MAX || !mPollStartEpoch) {
+ return NS_SOCKET_POLL_TIMEOUT;
+ }
+
+ PRIntervalTime elapsed = (now - mPollStartEpoch);
+ PRIntervalTime timeout = PR_SecondsToInterval(mHandler->mPollTimeout);
+
+ if (elapsed >= timeout) {
+ return 0;
+ }
+ return timeout - elapsed;
+}
+
+//-----------------------------------------------------------------------------
// ctor/dtor (called on the main/UI thread by the service manager)
nsSocketTransportService::nsSocketTransportService()
@@ -76,6 +121,7 @@ nsSocketTransportService::nsSocketTransportService()
, mKeepaliveEnabledPref(false)
, mServingPendingQueue(false)
, mMaxTimePerPollIter(100)
+ , mClampSocketTimeout(false)
, mMaxTimeForPrClosePref(PR_SecondsToInterval(5))
, mProbedMaxCount(false)
#if defined(XP_WIN)
@@ -189,7 +235,7 @@ nsSocketTransportService::AttachSocket(PRFileDesc *fd, nsASocketHandler *handler
SocketContext sock;
sock.mFD = fd;
sock.mHandler = handler;
- sock.mElapsedTime = 0;
+ sock.mPollStartEpoch = 0;
nsresult rv = AddToIdleList(&sock);
if (NS_SUCCEEDED(rv))
@@ -275,6 +321,8 @@ nsSocketTransportService::AddToPollList(SocketContext *sock)
PodMove(mPollList + newSocketIndex + 2, mPollList + newSocketIndex + 1,
mActiveCount - newSocketIndex);
}
+
+ sock->StartTimeout(PR_IntervalNow());
mActiveList[newSocketIndex] = *sock;
mActiveCount++;
@@ -399,34 +447,32 @@ nsSocketTransportService::GrowIdleList()
}
PRIntervalTime
-nsSocketTransportService::PollTimeout()
+nsSocketTransportService::PollTimeout(PRIntervalTime now)
{
- if (mActiveCount == 0)
+ if (mActiveCount == 0) {
return NS_SOCKET_POLL_TIMEOUT;
+ }
// compute minimum time before any socket timeout expires.
- uint32_t minR = UINT16_MAX;
+ PRIntervalTime minR = NS_SOCKET_POLL_TIMEOUT;
for (uint32_t i=0; i<mActiveCount; ++i) {
const SocketContext &s = mActiveList[i];
- // mPollTimeout could be less than mElapsedTime if setTimeout
- // was called with a value smaller than mElapsedTime.
- uint32_t r = (s.mElapsedTime < s.mHandler->mPollTimeout)
- ? s.mHandler->mPollTimeout - s.mElapsedTime
- : 0;
- if (r < minR)
+ PRIntervalTime r = s.TimeoutIn(now);
+ if (r < minR) {
minR = r;
+ }
}
- // nsASocketHandler defines UINT16_MAX as do not timeout
- if (minR == UINT16_MAX) {
+
+ if (minR == NS_SOCKET_POLL_TIMEOUT) {
SOCKET_LOG(("poll timeout: none\n"));
return NS_SOCKET_POLL_TIMEOUT;
}
- SOCKET_LOG(("poll timeout: %lu\n", minR));
- return PR_SecondsToInterval(minR);
+ SOCKET_LOG(("poll timeout: %lu seconds\n", PR_IntervalToSeconds(minR)));
+ return minR;
}
int32_t
-nsSocketTransportService::Poll(uint32_t *interval)
+nsSocketTransportService::Poll(PRIntervalTime ts)
{
PRPollDesc *pollList;
uint32_t pollCount;
@@ -436,12 +482,16 @@ nsSocketTransportService::Poll(uint32_t *interval)
// DoPollIteration() should service the network without blocking.
bool pendingEvents = false;
mRawThread->HasPendingEvents(&pendingEvents);
-
+
if (mPollList[0].fd) {
mPollList[0].out_flags = 0;
pollList = mPollList;
pollCount = mActiveCount + 1;
- pollTimeout = pendingEvents ? PR_INTERVAL_NO_WAIT : PollTimeout();
+ pollTimeout = IsSocketTimeoutClamped() ?
+ PR_MillisecondsToInterval(100) :
+ pendingEvents ?
+ PR_INTERVAL_NO_WAIT :
+ PollTimeout(ts);
}
else {
// no pollable event, so busy wait...
@@ -450,22 +500,21 @@ nsSocketTransportService::Poll(uint32_t *interval)
pollList = &mPollList[1];
else
pollList = nullptr;
- pollTimeout =
- pendingEvents ? PR_INTERVAL_NO_WAIT : PR_MillisecondsToInterval(25);
+ pollTimeout = IsSocketTimeoutClamped() ?
+ PR_MillisecondsToInterval(25) :
+ pendingEvents ?
+ PR_INTERVAL_NO_WAIT :
+ PR_MillisecondsToInterval(25);
}
- PRIntervalTime ts = PR_IntervalNow();
-
SOCKET_LOG((" timeout = %i milliseconds\n",
PR_IntervalToMilliseconds(pollTimeout)));
- int32_t rv = PR_Poll(pollList, pollCount, pollTimeout);
- PRIntervalTime passedInterval = PR_IntervalNow() - ts;
+ int32_t rv = PR_Poll(pollList, pollCount, pollTimeout);
SOCKET_LOG((" ...returned after %i milliseconds\n",
- PR_IntervalToMilliseconds(passedInterval)));
+ PR_IntervalToMilliseconds(PR_IntervalNow() - ts)));
- *interval = PR_IntervalToSeconds(passedInterval);
return rv;
}
@@ -514,6 +563,7 @@ nsSocketTransportService::Init()
tmpPrefService->AddObserver(KEEPALIVE_RETRY_INTERVAL_PREF, this, false);
tmpPrefService->AddObserver(KEEPALIVE_PROBE_COUNT_PREF, this, false);
tmpPrefService->AddObserver(MAX_TIME_BETWEEN_TWO_POLLS, this, false);
+ tmpPrefService->AddObserver(SOCKET_CLAMP_PREF, this, false);
tmpPrefService->AddObserver(MAX_TIME_FOR_PR_CLOSE_DURING_SHUTDOWN, this, false);
}
UpdatePrefs();
@@ -811,13 +861,8 @@ nsSocketTransportService::Run()
// make sure the pseudo random number generator is seeded on this thread
srand(static_cast<unsigned>(PR_Now()));
- int numberOfPendingEvents;
-
- // If there is too many pending events queued, we will run some poll()
- // between them.
for (;;) {
bool pendingEvents = false;
- numberOfPendingEvents = 0;
do {
DoPollIteration();
@@ -838,7 +883,6 @@ nsSocketTransportService::Run()
TimeStamp eventQueueStart = TimeStamp::NowLoRes();
do {
NS_ProcessNextEvent(mRawThread);
- numberOfPendingEvents++;
pendingEvents = false;
mRawThread->HasPendingEvents(&pendingEvents);
} while (pendingEvents && mServingPendingQueue &&
@@ -915,6 +959,9 @@ nsSocketTransportService::DoPollIteration()
{
SOCKET_LOG(("STS poll iter\n"));
+ // Freeze "now" for list updates and polling.
+ PRIntervalTime now = PR_IntervalNow();
+
int32_t i, count;
//
// poll loop
@@ -932,16 +979,18 @@ nsSocketTransportService::DoPollIteration()
mActiveList[i].mHandler->mCondition,
mActiveList[i].mHandler->mPollFlags));
//---
- if (NS_FAILED(mActiveList[i].mHandler->mCondition))
+ if (NS_FAILED(mActiveList[i].mHandler->mCondition)) {
DetachSocket(mActiveList, &mActiveList[i]);
- else {
+ } else {
uint16_t in_flags = mActiveList[i].mHandler->mPollFlags;
- if (in_flags == 0)
+ if (in_flags == 0) {
MoveToIdleList(&mActiveList[i]);
- else {
+ } else {
// update poll flags
mPollList[i+1].in_flags = in_flags;
mPollList[i+1].out_flags = 0;
+ // Active polling entry; start timeout.
+ mActiveList[i].StartTimeout(now);
}
}
}
@@ -952,10 +1001,11 @@ nsSocketTransportService::DoPollIteration()
mIdleList[i].mHandler->mCondition,
mIdleList[i].mHandler->mPollFlags));
//---
- if (NS_FAILED(mIdleList[i].mHandler->mCondition))
+ if (NS_FAILED(mIdleList[i].mHandler->mCondition)) {
DetachSocket(mIdleList, &mIdleList[i]);
- else if (mIdleList[i].mHandler->mPollFlags != 0)
+ } else if (mIdleList[i].mHandler->mPollFlags != 0) {
MoveToPollList(&mIdleList[i]);
+ }
}
SOCKET_LOG((" calling PR_Poll [active=%u idle=%u]\n", mActiveCount, mIdleCount));
@@ -969,55 +1019,44 @@ nsSocketTransportService::DoPollIteration()
#endif
// Measures seconds spent while blocked on PR_Poll
- uint32_t pollInterval = 0;
int32_t n = 0;
+
if (!gIOService->IsNetTearingDown()) {
// Let's not do polling during shutdown.
#if defined(XP_WIN)
StartPolling();
#endif
- n = Poll(&pollInterval);
+ n = Poll(now);
#if defined(XP_WIN)
EndPolling();
#endif
}
+
+ // Refresh when "now" is for following checks.
+ now = PR_IntervalNow();
if (n < 0) {
SOCKET_LOG((" PR_Poll error [%d] os error [%d]\n", PR_GetError(),
PR_GetOSError()));
- }
- else {
+ } else {
//
// service "active" sockets...
//
- uint32_t numberOfOnSocketReadyCalls = 0;
for (i=0; i<int32_t(mActiveCount); ++i) {
PRPollDesc &desc = mPollList[i+1];
SocketContext &s = mActiveList[i];
if (n > 0 && desc.out_flags != 0) {
- s.mElapsedTime = 0;
+ s.StopTimeout();
s.mHandler->OnSocketReady(desc.fd, desc.out_flags);
- numberOfOnSocketReadyCalls++;
- }
- // check for timeout errors unless disabled...
- else if (s.mHandler->mPollTimeout != UINT16_MAX) {
- // update elapsed time counter
- // (NOTE: We explicitly cast UINT16_MAX to be an unsigned value
- // here -- otherwise, some compilers will treat it as signed,
- // which makes them fire signed/unsigned-comparison build
- // warnings for the comparison against 'pollInterval'.)
- if (MOZ_UNLIKELY(pollInterval >
- static_cast<uint32_t>(UINT16_MAX) -
- s.mElapsedTime))
- s.mElapsedTime = UINT16_MAX;
- else
- s.mElapsedTime += uint16_t(pollInterval);
- // check for timeout expiration
- if (s.mElapsedTime >= s.mHandler->mPollTimeout) {
- s.mElapsedTime = 0;
- s.mHandler->OnSocketReady(desc.fd, -1);
- numberOfOnSocketReadyCalls++;
- }
+ } else if (s.IsTimedOut(now)) {
+ // Socket timed out; disengage.
+ s.StopTimeout();
+ s.mHandler->OnSocketReady(desc.fd, -1);
+ } else {
+ // We may have recorded a timeout start on a socket and subsequently
+ // set it to not time out. Check the socket and reset the timestamp
+ // in this case to keep our states predictable.
+ s.ResetTimeout();
}
}
@@ -1121,6 +1160,13 @@ nsSocketTransportService::UpdatePrefs()
if (NS_SUCCEEDED(rv) && maxTimePref >= 0) {
mMaxTimePerPollIter = maxTimePref;
}
+
+ bool socketTimeoutClamped = false;
+ rv = tmpPrefService->GetBoolPref(SOCKET_CLAMP_PREF,
+ &socketTimeoutClamped);
+ if (NS_SUCCEEDED(rv)) {
+ mClampSocketTimeout = socketTimeoutClamped;
+ }
int32_t maxTimeForPrClosePref;
rv = tmpPrefService->GetIntPref(MAX_TIME_FOR_PR_CLOSE_DURING_SHUTDOWN,
diff --git a/netwerk/base/nsSocketTransportService2.h b/netwerk/base/nsSocketTransportService2.h
index 0b88a6535..9360dd905 100644
--- a/netwerk/base/nsSocketTransportService2.h
+++ b/netwerk/base/nsSocketTransportService2.h
@@ -19,7 +19,6 @@
#include "mozilla/Mutex.h"
#include "mozilla/net/DashboardTypes.h"
#include "mozilla/Atomics.h"
-#include "mozilla/TimeStamp.h"
#include "nsITimer.h"
#include "mozilla/UniquePtr.h"
#include "PollableEvent.h"
@@ -117,6 +116,9 @@ public:
// Returns true if keepalives are enabled in prefs.
bool IsKeepaliveEnabled() { return mKeepaliveEnabledPref; }
+
+ // Returns true if socket timeout clamping is enabled in prefs.
+ bool IsSocketTimeoutClamped() { return mClampSocketTimeout; }
PRIntervalTime MaxTimeForPrClosePref() {return mMaxTimeForPrClosePref; }
protected:
@@ -167,7 +169,33 @@ private:
{
PRFileDesc *mFD;
nsASocketHandler *mHandler;
- uint16_t mElapsedTime; // time elapsed w/o activity
+ PRIntervalTime mPollStartEpoch; // Epoch timestamp when we started to poll this socket
+
+ public:
+ // Helper functions implementing a timeout mechanism.
+
+ // Returns true if the socket has not been signalled in more than the desired
+ // timeout for this socket (mHandler->mPollTimeout).
+ bool IsTimedOut(PRIntervalTime now) const;
+
+ // Records the epoch timestamp we started polling this socket. If the epoch is already
+ // recorded, then it does nothing (i.e. does not re-arm) so it's safe to call whenever
+ // this socket is put into the active polling list.
+ void StartTimeout(PRIntervalTime now);
+
+ // Turns off the timout calculation.
+ void StopTimeout();
+
+ // Returns the number of intervals from "now" after which this socket will timeout,
+ // or 0 (zero) when it has already timed out. Returns NS_SOCKET_POLL_TIMEOUT
+ // when there is no timeout set on the socket.
+ PRIntervalTime TimeoutIn(PRIntervalTime now) const;
+
+ // When a socket timeout is set to not time out and later set again to time out, it
+ // is possible that mPollStartEpoch is not reset in-between. We have to manually
+ // call this on every iteration over sockets to ensure the epoch timestamp is reset
+ // and our socket bookkeeping remains accurate.
+ void ResetTimeout();
};
SocketContext *mActiveList; /* mListSize entries */
@@ -203,10 +231,10 @@ private:
PRPollDesc *mPollList; /* mListSize + 1 entries */
- PRIntervalTime PollTimeout(); // computes ideal poll timeout
+ PRIntervalTime PollTimeout(PRIntervalTime now); // computes ideal poll timeout
nsresult DoPollIteration();
// perfoms a single poll iteration
- int32_t Poll(uint32_t *interval);
+ int32_t Poll(PRIntervalTime now);
// calls PR_Poll. the out param
// interval indicates the poll
// duration in seconds.
@@ -228,6 +256,8 @@ private:
int32_t mKeepaliveProbeCount;
// True if TCP keepalive is enabled globally.
bool mKeepaliveEnabledPref;
+ // True if socket polling should be clamped.
+ bool mClampSocketTimeout;
Atomic<bool> mServingPendingQueue;
Atomic<int32_t, Relaxed> mMaxTimePerPollIter;
diff --git a/netwerk/protocol/http/nsHttpHandler.cpp b/netwerk/protocol/http/nsHttpHandler.cpp
index 7a29e041b..0de572914 100644
--- a/netwerk/protocol/http/nsHttpHandler.cpp
+++ b/netwerk/protocol/http/nsHttpHandler.cpp
@@ -80,7 +80,8 @@
#include "mozilla/net/HttpChannelChild.h"
-#define UA_PREF_PREFIX "general.useragent."
+#define UA_PREF_PREFIX "useragent."
+#define GENERAL_UA_PREF_PREFIX "general.useragent."
#ifdef XP_WIN
#define UA_SPARE_PLATFORM
#endif
@@ -95,7 +96,8 @@
#define SECURITY_PREFIX "security."
#define NEW_TAB_REMOTE_MODE "browser.newtabpage.remote.mode"
-#define UA_PREF(_pref) UA_PREF_PREFIX _pref
+#define GUA_PREF(_pref) GENERAL_UA_PREF_PREFIX _pref
+#define UA_PREF(_pref) HTTP_PREF_PREFIX UA_PREF_PREFIX _pref
#define HTTP_PREF(_pref) HTTP_PREF_PREFIX _pref
#define BROWSER_PREF(_pref) BROWSER_PREF_PREFIX _pref
@@ -686,7 +688,7 @@ const nsAFlatCString &
nsHttpHandler::UserAgent()
{
if (mUserAgentOverride) {
- LOG(("using general.useragent.override : %s\n", mUserAgentOverride.get()));
+ LOG(("Using user-agent override : %s\n", mUserAgentOverride.get()));
return mUserAgentOverride;
}
@@ -843,8 +845,8 @@ nsHttpHandler::InitUserAgentComponents()
#elif defined(__i386__) || defined(__x86_64__)
mOscpu.AssignLiteral("Intel Mac OS X");
#endif
- SInt32 majorVersion = nsCocoaFeatures::OSXVersionMajor();
- SInt32 minorVersion = nsCocoaFeatures::OSXVersionMinor();
+ SInt32 majorVersion = nsCocoaFeatures::macOSVersionMajor();
+ SInt32 minorVersion = nsCocoaFeatures::macOSVersionMinor();
mOscpu += nsPrintfCString(" %d.%d", majorVersion, minorVersion);
#elif defined (XP_UNIX)
struct utsname name;
@@ -931,8 +933,8 @@ nsHttpHandler::PrefsChanged(nsIPrefBranch *prefs, const char *pref)
bool cVar = false;
- if (PREF_CHANGED(UA_PREF("appVersionIsBuildID"))) {
- rv = prefs->GetBoolPref(UA_PREF("appVersionIsBuildID"), &cVar);
+ if (PREF_CHANGED(GUA_PREF("appVersionIsBuildID"))) {
+ rv = prefs->GetBoolPref(GUA_PREF("appVersionIsBuildID"), &cVar);
mAppVersionIsBuildID = (NS_SUCCEEDED(rv) && cVar);
// Rebuild application version string.
@@ -941,8 +943,8 @@ nsHttpHandler::PrefsChanged(nsIPrefBranch *prefs, const char *pref)
mUserAgentIsDirty = true;
}
- if (PREF_CHANGED(UA_PREF("compatMode.gecko"))) {
- rv = prefs->GetBoolPref(UA_PREF("compatMode.gecko"), &cVar);
+ if (PREF_CHANGED(GUA_PREF("compatMode.gecko"))) {
+ rv = prefs->GetBoolPref(GUA_PREF("compatMode.gecko"), &cVar);
mCompatGeckoEnabled = (NS_SUCCEEDED(rv) && cVar);
// Rebuild rv: and Goanna slice version
@@ -965,8 +967,8 @@ nsHttpHandler::PrefsChanged(nsIPrefBranch *prefs, const char *pref)
mUserAgentIsDirty = true;
}
- if (PREF_CHANGED(UA_PREF("compatMode.firefox"))) {
- rv = prefs->GetBoolPref(UA_PREF("compatMode.firefox"), &cVar);
+ if (PREF_CHANGED(GUA_PREF("compatMode.firefox"))) {
+ rv = prefs->GetBoolPref(GUA_PREF("compatMode.firefox"), &cVar);
mCompatFirefoxEnabled = (NS_SUCCEEDED(rv) && cVar);
mUserAgentIsDirty = true;
}
@@ -974,8 +976,8 @@ nsHttpHandler::PrefsChanged(nsIPrefBranch *prefs, const char *pref)
// general.useragent.compatMode.version
// This is the version number used in rv: for Gecko compatibility
// and in the Firefox/nn.nn slice when compatMode.firefox is enabled.
- if (PREF_CHANGED(UA_PREF("compatMode.version"))) {
- prefs->GetCharPref(UA_PREF("compatMode.version"),
+ if (PREF_CHANGED(GUA_PREF("compatMode.version"))) {
+ prefs->GetCharPref(GUA_PREF("compatMode.version"),
getter_Copies(mCompatFirefoxVersion));
// rebuild mMisc and compatMode slice
@@ -992,8 +994,8 @@ nsHttpHandler::PrefsChanged(nsIPrefBranch *prefs, const char *pref)
}
// general.useragent.override
- if (PREF_CHANGED(UA_PREF("override"))) {
- prefs->GetCharPref(UA_PREF("override"),
+ if (PREF_CHANGED(UA_PREF("global_override"))) {
+ prefs->GetCharPref(UA_PREF("global_override"),
getter_Copies(mUserAgentOverride));
mUserAgentIsDirty = true;
}
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-25 20:05:04 +0000