diff options
| author | Matt A. Tobin <email@mattatobin.com> | 2019-11-10 19:11:03 -0500 |
|---|---|---|
| committer | Matt A. Tobin <email@mattatobin.com> | 2019-11-10 19:11:03 -0500 |
| commit | 201683afe4596ae32f7b1ea12dfca52995d59f9d (patch) | |
| tree | 8632173f59a85d1c3bf679653de7957a59c96eae /mailnews/mime | |
| parent | 4db1ae892bad565e8e59ec6034b4c98946077248 (diff) | |
| download | UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.gz UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.lz UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.xz UXP-201683afe4596ae32f7b1ea12dfca52995d59f9d.zip | |
Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors
* Part 1: make conversion CTORs explicit.
Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors.
* Part 2: fix a couple of double-mRefCnt declaration errors.
* Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16().
Tag #1273
Diffstat (limited to 'mailnews/mime')
| -rw-r--r-- | mailnews/mime/public/MimeHeaderParser.h | 2 | ||||
| -rw-r--r-- | mailnews/mime/src/nsCMS.h | 2 | ||||
| -rw-r--r-- | mailnews/mime/src/nsSimpleMimeConverterStub.cpp | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/mailnews/mime/public/MimeHeaderParser.h b/mailnews/mime/public/MimeHeaderParser.h index 429e759b1..fe9bf59d3 100644 --- a/mailnews/mime/public/MimeHeaderParser.h +++ b/mailnews/mime/public/MimeHeaderParser.h @@ -47,7 +47,7 @@ template <uint32_t N = 5> class UTF16ArrayAdapter { public: - UTF16ArrayAdapter(nsTArray<nsCString> &aUTF8Array) + explicit UTF16ArrayAdapter(nsTArray<nsCString> &aUTF8Array) : mUTF8Array(aUTF8Array) {} ~UTF16ArrayAdapter() { detail::DoConversion(mUTF16Array, mUTF8Array); } operator nsTArray<nsString>&() { return mUTF16Array; } diff --git a/mailnews/mime/src/nsCMS.h b/mailnews/mime/src/nsCMS.h index e8f2fdd4b..7c862eb46 100644 --- a/mailnews/mime/src/nsCMS.h +++ b/mailnews/mime/src/nsCMS.h @@ -32,7 +32,7 @@ public: NS_DECL_NSICMSMESSAGE2 nsCMSMessage(); - nsCMSMessage(NSSCMSMessage* aCMSMsg); + explicit nsCMSMessage(NSSCMSMessage* aCMSMsg); nsresult Init(); void referenceContext(nsIInterfaceRequestor* aContext) {m_ctx = aContext;} diff --git a/mailnews/mime/src/nsSimpleMimeConverterStub.cpp b/mailnews/mime/src/nsSimpleMimeConverterStub.cpp index 50dcf27fd..ca608b54c 100644 --- a/mailnews/mime/src/nsSimpleMimeConverterStub.cpp +++ b/mailnews/mime/src/nsSimpleMimeConverterStub.cpp @@ -164,7 +164,7 @@ MimeSimpleStubClassInitialize(MimeSimpleStubClass *clazz) class nsSimpleMimeConverterStub : public nsIMimeContentTypeHandler { public: - nsSimpleMimeConverterStub(const char *aContentType) : mContentType(aContentType) { } + explicit nsSimpleMimeConverterStub(const char *aContentType) : mContentType(aContentType) { } NS_DECL_ISUPPORTS |