diff options
| author | janekptacijarabaci <janekptacijarabaci@seznam.cz> | 2018-04-24 21:39:13 +0200 |
|---|---|---|
| committer | janekptacijarabaci <janekptacijarabaci@seznam.cz> | 2018-04-24 21:39:13 +0200 |
| commit | eae8d21428acdb3fb842df091ded0eb276bcaaaa (patch) | |
| tree | 8fcdb943e19ec1ca33bec3b39636311dcddd38f0 /dom/base/nsINode.cpp | |
| parent | d0e748cadabba2b7cbf7407c4bca665315bf00fe (diff) | |
| download | UXP-eae8d21428acdb3fb842df091ded0eb276bcaaaa.tar UXP-eae8d21428acdb3fb842df091ded0eb276bcaaaa.tar.gz UXP-eae8d21428acdb3fb842df091ded0eb276bcaaaa.tar.lz UXP-eae8d21428acdb3fb842df091ded0eb276bcaaaa.tar.xz UXP-eae8d21428acdb3fb842df091ded0eb276bcaaaa.zip | |
moebius#138: Optimize operations on root of deeply-nested frame tree
https://github.com/MoonchildProductions/moebius/pull/138
Diffstat (limited to 'dom/base/nsINode.cpp')
| -rw-r--r-- | dom/base/nsINode.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/dom/base/nsINode.cpp b/dom/base/nsINode.cpp index 3a649a61d..715ca93ea 100644 --- a/dom/base/nsINode.cpp +++ b/dom/base/nsINode.cpp @@ -1907,6 +1907,10 @@ void nsINode::doRemoveChildAt(uint32_t aIndex, bool aNotify, nsIContent* aKid, nsAttrAndChildArray& aChildArray) { + // NOTE: This function must not trigger any calls to + // nsIDocument::GetRootElement() calls until *after* it has removed aKid from + // aChildArray. Any calls before then could potentially restore a stale + // value for our cached root element, per note in nsDocument::RemoveChildAt(). NS_PRECONDITION(aKid && aKid->GetParentNode() == this && aKid == GetChildAt(aIndex) && IndexOf(aKid) == (int32_t)aIndex, "Bogus aKid"); |