diff options
author | wicknix <39230578+wicknix@users.noreply.github.com> | 2019-04-15 18:58:07 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-04-15 18:58:07 -0500 |
commit | 5a1843c9f9e323627f9c35529e6a8c853d4dbb0d (patch) | |
tree | 62de3cd7cb8a6f75e568863bb73ca2deb80d87a9 /devtools | |
parent | 065f6f9e5ebc1ed6cfaadaf7851b6021fa94a013 (diff) | |
parent | 095ea556855b38138e39e713f482eb440f7da9b2 (diff) | |
download | UXP-5a1843c9f9e323627f9c35529e6a8c853d4dbb0d.tar UXP-5a1843c9f9e323627f9c35529e6a8c853d4dbb0d.tar.gz UXP-5a1843c9f9e323627f9c35529e6a8c853d4dbb0d.tar.lz UXP-5a1843c9f9e323627f9c35529e6a8c853d4dbb0d.tar.xz UXP-5a1843c9f9e323627f9c35529e6a8c853d4dbb0d.zip |
Merge pull request #1 from MoonchildProductions/master
keep up with mc
Diffstat (limited to 'devtools')
31 files changed, 93 insertions, 266 deletions
diff --git a/devtools/client/menus.js b/devtools/client/menus.js index 1d2168967..dbacb367d 100644 --- a/devtools/client/menus.js +++ b/devtools/client/menus.js @@ -189,7 +189,8 @@ exports.menuitems = [ l10nKey: "getMoreDevtoolsCmd", oncommand(event) { let window = event.target.ownerDocument.defaultView; - window.openUILinkIn("https://addons.mozilla.org/firefox/collections/mozilla/webdeveloper/", "tab"); + let getMoreURL = Services.prefs.getCharPref("browser.getdevtools.url"); + window.openUILinkIn(getMoreURL, "tab"); } }, ]; diff --git a/devtools/client/netmonitor/filter-predicates.js b/devtools/client/netmonitor/filter-predicates.js index 9c8e49c62..75ee422aa 100644 --- a/devtools/client/netmonitor/filter-predicates.js +++ b/devtools/client/netmonitor/filter-predicates.js @@ -72,7 +72,7 @@ function isWS({ requestHeaders, responseHeaders }) { // Find the 'upgrade' header. let upgradeHeader = requestHeaders.headers.find(header => { - return (header.name == "Upgrade"); + return (header.name.toLowerCase() == "upgrade"); }); // If no header found on request, check response - mainly to get @@ -81,7 +81,7 @@ function isWS({ requestHeaders, responseHeaders }) { if (!upgradeHeader && responseHeaders && Array.isArray(responseHeaders.headers)) { upgradeHeader = responseHeaders.headers.find(header => { - return (header.name == "Upgrade"); + return (header.name.toLowerCase() == "upgrade"); }); } diff --git a/devtools/client/netmonitor/test/browser_net_copy_headers.js b/devtools/client/netmonitor/test/browser_net_copy_headers.js index 36ce2fb34..bb582c8e1 100644 --- a/devtools/client/netmonitor/test/browser_net_copy_headers.js +++ b/devtools/client/netmonitor/test/browser_net_copy_headers.js @@ -49,12 +49,12 @@ add_task(function* () { const EXPECTED_RESPONSE_HEADERS = [ `${httpVersion} ${status} ${statusText}`, - "Last-Modified: Sun, 3 May 2015 11:11:11 GMT", - "Content-Type: text/html", - "Content-Length: 465", - "Connection: close", - "Server: httpd.js", - "Date: Sun, 3 May 2015 11:11:11 GMT" + "last-modified: Sun, 3 May 2015 11:11:11 GMT", + "content-type: text/html", + "content-length: 465", + "connection: close", + "server: httpd.js", + "date: Sun, 3 May 2015 11:11:11 GMT" ].join("\n"); yield waitForClipboardPromise(function setup() { @@ -62,8 +62,8 @@ add_task(function* () { }, function validate(result) { // Fake the "Last-Modified" and "Date" headers because they will vary: result = String(result) - .replace(/Last-Modified: [^\n]+ GMT/, "Last-Modified: Sun, 3 May 2015 11:11:11 GMT") - .replace(/Date: [^\n]+ GMT/, "Date: Sun, 3 May 2015 11:11:11 GMT"); + .replace(/last-modified: [^\n]+ GMT/, "last-modified: Sun, 3 May 2015 11:11:11 GMT") + .replace(/date: [^\n]+ GMT/, "date: Sun, 3 May 2015 11:11:11 GMT"); return result === EXPECTED_RESPONSE_HEADERS; }); info("Clipboard contains the currently selected item's response headers."); diff --git a/devtools/client/netmonitor/test/browser_net_timing-division.js b/devtools/client/netmonitor/test/browser_net_timing-division.js index 0114ba235..ff2379dc2 100644 --- a/devtools/client/netmonitor/test/browser_net_timing-division.js +++ b/devtools/client/netmonitor/test/browser_net_timing-division.js @@ -48,9 +48,9 @@ add_task(function* () { let lastRequest = RequestsMenu.getItemAtIndex(1); info("First request happened at: " + - firstRequest.attachment.responseHeaders.headers.find(e => e.name == "Date").value); + firstRequest.attachment.responseHeaders.headers.find(e => e.name == "date").value); info("Last request happened at: " + - lastRequest.attachment.responseHeaders.headers.find(e => e.name == "Date").value); + lastRequest.attachment.responseHeaders.headers.find(e => e.name == "date").value); ok(secDivs.length, "There should be at least one division on the seconds time scale."); diff --git a/devtools/client/responsive.html/docs/browser-swap.md b/devtools/client/responsive.html/docs/browser-swap.md index 75055ad4e..f4f8322cb 100644 --- a/devtools/client/responsive.html/docs/browser-swap.md +++ b/devtools/client/responsive.html/docs/browser-swap.md @@ -96,11 +96,8 @@ browsers are swapped. Browser attributes `gBrowser.swapBrowsersAndCloseOther` transfers between browsers: -* `usercontextid` - Tab attributes `gBrowser.swapBrowsersAndCloseOther` transfers between tabs: -* `usercontextid` * `muted` * `soundplaying` * `busy` diff --git a/devtools/client/responsive.html/manager.js b/devtools/client/responsive.html/manager.js index a3fbed366..97ef8ad6d 100644 --- a/devtools/client/responsive.html/manager.js +++ b/devtools/client/responsive.html/manager.js @@ -76,11 +76,6 @@ const ResponsiveUIManager = exports.ResponsiveUIManager = { this.showRemoteOnlyNotification(window, tab, options); return promise.reject(new Error("RDM only available for remote tabs.")); } - // Remove this once we support this case in bug 1306975. - if (tab.linkedBrowser.hasAttribute("usercontextid")) { - this.showNoContainerTabsNotification(window, tab, options); - return promise.reject(new Error("RDM not available for container tabs.")); - } if (!this.isActiveForTab(tab)) { this.initMenuCheckListenerFor(window); @@ -218,16 +213,7 @@ const ResponsiveUIManager = exports.ResponsiveUIManager = { } }), - showRemoteOnlyNotification(window, tab, options) { - this.showErrorNotification(window, tab, options, getStr("responsive.remoteOnly")); - }, - - showNoContainerTabsNotification(window, tab, options) { - this.showErrorNotification(window, tab, options, - getStr("responsive.noContainerTabs")); - }, - - showErrorNotification(window, tab, { command } = {}, msg) { + showRemoteOnlyNotification(window, tab, { command } = {}) { // Default to using the browser's per-tab notification box let nbox = window.gBrowser.getNotificationBox(tab.linkedBrowser); diff --git a/devtools/client/shared/AppCacheUtils.jsm b/devtools/client/shared/AppCacheUtils.jsm index a2beca993..9fd4d0541 100644 --- a/devtools/client/shared/AppCacheUtils.jsm +++ b/devtools/client/shared/AppCacheUtils.jsm @@ -86,7 +86,7 @@ AppCacheUtils.prototype = { _parseManifest: function ACU__parseManifest(uriInfo) { let deferred = defer(); let manifestName = uriInfo.name; - let manifestLastModified = new Date(uriInfo.responseHeaders["Last-Modified"]); + let manifestLastModified = new Date(uriInfo.responseHeaders["last-modified"]); if (uriInfo.charset.toLowerCase() != "utf-8") { this._addError(0, "notUTF8", uriInfo.charset); @@ -158,7 +158,7 @@ AppCacheUtils.prototype = { // Check that the resource was not modified after the manifest was last // modified. If it was then the manifest file should be refreshed. let resourceLastModified = - new Date(uriInfo.responseHeaders["Last-Modified"]); + new Date(uriInfo.responseHeaders["last-modified"]); if (manifestLastModified < resourceLastModified) { this._addError(parsedUri.line, "fileChangedButNotManifest", @@ -230,12 +230,12 @@ AppCacheUtils.prototype = { result.requestHeaders = {}; request.visitRequestHeaders(function (header, value) { - result.requestHeaders[header] = value; + result.responseHeaders[header.toLowerCase()] = value; }); result.responseHeaders = {}; request.visitResponseHeaders(function (header, value) { - result.responseHeaders[header] = value; + result.responseHeaders[header.toLowerCase()] = value; }); deferred.resolve(result); diff --git a/devtools/client/shared/curl.js b/devtools/client/shared/curl.js index 420fe6aa5..967019746 100644 --- a/devtools/client/shared/curl.js +++ b/devtools/client/shared/curl.js @@ -81,14 +81,14 @@ const Curl = { postDataText = data.postDataText; postData.push("--data"); postData.push(escapeString(utils.writePostDataTextParams(postDataText))); - ignoredHeaders.add("Content-Length"); + ignoredHeaders.add("content-length"); } else if (multipartRequest) { postDataText = data.postDataText; postData.push("--data-binary"); let boundary = utils.getMultipartBoundary(data); let text = utils.removeBinaryDataFromMultipartText(postDataText, boundary); postData.push(escapeString(text)); - ignoredHeaders.add("Content-Length"); + ignoredHeaders.add("content-length"); } // Add method. @@ -125,11 +125,11 @@ const Curl = { } for (let i = 0; i < headers.length; i++) { let header = headers[i]; - if (header.name === "Accept-Encoding") { + if (header.name.toLowerCase() === "accept-encoding") { command.push("--compressed"); continue; } - if (ignoredHeaders.has(header.name)) { + if (ignoredHeaders.has(header.name.toLowerCase())) { continue; } command.push("-H"); @@ -375,6 +375,7 @@ const CurlUtils = { .replace(/\'/g, "\\\'") .replace(/\n/g, "\\n") .replace(/\r/g, "\\r") + .replace(/!/g, "\\041") .replace(/[^\x20-\x7E]/g, escapeCharacter) + "'"; } diff --git a/devtools/client/styleeditor/test/browser.ini b/devtools/client/styleeditor/test/browser.ini index 4a84d45e6..ba935e1dd 100644 --- a/devtools/client/styleeditor/test/browser.ini +++ b/devtools/client/styleeditor/test/browser.ini @@ -77,7 +77,6 @@ support-files = [browser_styleeditor_init.js] [browser_styleeditor_inline_friendly_names.js] [browser_styleeditor_loading.js] -[browser_styleeditor_loading_with_containers.js] [browser_styleeditor_media_sidebar.js] [browser_styleeditor_media_sidebar_links.js] skip-if = e10s && debug # Bug 1252201 - Docshell leak on debug e10s diff --git a/devtools/client/styleeditor/test/browser_styleeditor_loading_with_containers.js b/devtools/client/styleeditor/test/browser_styleeditor_loading_with_containers.js deleted file mode 100644 index a00628c8b..000000000 --- a/devtools/client/styleeditor/test/browser_styleeditor_loading_with_containers.js +++ /dev/null @@ -1,63 +0,0 @@ -/* vim: set ts=2 et sw=2 tw=80: */ -/* Any copyright is dedicated to the Public Domain. - http://creativecommons.org/publicdomain/zero/1.0/ */ - -"use strict"; - -// Test that the stylesheets can be loaded correctly with containers -// (bug 1282660). - -const TESTCASE_URI = TEST_BASE_HTTP + "simple.html"; -const EXPECTED_SHEETS = [ - { - sheetIndex: 0, - name: /^simple.css$/, - rules: 1, - active: true - }, { - sheetIndex: 1, - name: /^<.*>$/, - rules: 3, - active: false - } -]; - -add_task(function* () { - // Using the personal container. - let userContextId = 1; - let { tab } = yield* openTabInUserContext(TESTCASE_URI, userContextId); - let { ui } = yield openStyleEditor(tab); - - is(ui.editors.length, 2, "The UI contains two style sheets."); - checkSheet(ui.editors[0], EXPECTED_SHEETS[0]); - checkSheet(ui.editors[1], EXPECTED_SHEETS[1]); -}); - -function* openTabInUserContext(uri, userContextId) { - // Open the tab in the correct userContextId. - let tab = gBrowser.addTab(uri, {userContextId}); - - // Select tab and make sure its browser is focused. - gBrowser.selectedTab = tab; - tab.ownerDocument.defaultView.focus(); - - let browser = gBrowser.getBrowserForTab(tab); - yield BrowserTestUtils.browserLoaded(browser); - return {tab, browser}; -} - -function checkSheet(editor, expected) { - is(editor.styleSheet.styleSheetIndex, expected.sheetIndex, - "Style sheet has correct index."); - - let summary = editor.summary; - let name = summary.querySelector(".stylesheet-name > label") - .getAttribute("value"); - ok(expected.name.test(name), "The name '" + name + "' is correct."); - - let ruleCount = summary.querySelector(".stylesheet-rule-count").textContent; - is(parseInt(ruleCount, 10), expected.rules, "the rule count is correct"); - - is(summary.classList.contains("splitview-active"), expected.active, - "The active status for this sheet is correct."); -} diff --git a/devtools/client/webconsole/net/test/mochitest/browser_net_headers.js b/devtools/client/webconsole/net/test/mochitest/browser_net_headers.js index 4a47074ee..14cde846c 100644 --- a/devtools/client/webconsole/net/test/mochitest/browser_net_headers.js +++ b/devtools/client/webconsole/net/test/mochitest/browser_net_headers.js @@ -26,11 +26,11 @@ add_task(function* () { // Select "Headers" tab let tabBody = yield selectNetInfoTab(hud, netInfoBody, "headers"); let paramName = tabBody.querySelector( - ".netInfoParamName > span[title='Content-Type']"); + ".netInfoParamName > span[title='content-type']"); // Verify "Content-Type" header (name and value) ok(paramName, "Header name must exist"); - is(paramName.textContent, "Content-Type", + is(paramName.textContent, "content-type", "The header name must have proper value"); let paramValue = paramName.parentNode.nextSibling; diff --git a/devtools/client/webconsole/new-console-output/test/fixtures/stubs/consoleApi.js b/devtools/client/webconsole/new-console-output/test/fixtures/stubs/consoleApi.js index 26e95fe39..d9662c4fd 100644 --- a/devtools/client/webconsole/new-console-output/test/fixtures/stubs/consoleApi.js +++ b/devtools/client/webconsole/new-console-output/test/fixtures/stubs/consoleApi.js @@ -657,8 +657,7 @@ stubPackets.set("console.log('foobar', 'test')", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "styles": [], @@ -690,8 +689,7 @@ stubPackets.set("console.log(undefined)", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "styles": [], @@ -721,8 +719,7 @@ stubPackets.set("console.warn('danger, will robinson!')", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "styles": [], @@ -754,8 +751,7 @@ stubPackets.set("console.log(NaN)", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "styles": [], @@ -787,8 +783,7 @@ stubPackets.set("console.log(null)", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "styles": [], @@ -818,8 +813,7 @@ stubPackets.set("console.log('鼬')", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "styles": [], @@ -847,8 +841,7 @@ stubPackets.set("console.clear()", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "timeStamp": 1477086275587, @@ -881,8 +874,7 @@ stubPackets.set("console.count('bar')", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "timeStamp": 1477086277812, @@ -933,8 +925,7 @@ stubPackets.set("console.assert(false, {message: 'foobar'})", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "styles": [], @@ -973,8 +964,7 @@ stubPackets.set("console.log('hello \nfrom \rthe \"string world!')", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "styles": [], @@ -1004,8 +994,7 @@ stubPackets.set("console.log('úṇĩçödê țĕșť')", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "styles": [], @@ -1047,8 +1036,7 @@ stubPackets.set("console.dirxml(window)", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "timeStamp": 1477086285483, @@ -1076,8 +1064,7 @@ stubPackets.set("console.trace()", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "timeStamp": 1477086287286, @@ -1130,8 +1117,7 @@ stubPackets.set("console.time('bar')", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "timeStamp": 1477086289137, @@ -1164,8 +1150,7 @@ stubPackets.set("console.timeEnd('bar')", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "timeStamp": 1477086289138, @@ -1198,8 +1183,7 @@ stubPackets.set("console.table('bar')", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "timeStamp": 1477086290984, @@ -1246,8 +1230,7 @@ stubPackets.set("console.table(['a', 'b', 'c'])", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "timeStamp": 1477086292762, @@ -1277,8 +1260,7 @@ stubPackets.set("console.group('bar')", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "timeStamp": 1477086294628, @@ -1308,8 +1290,7 @@ stubPackets.set("console.groupEnd('bar')", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "timeStamp": 1477086294630, @@ -1339,8 +1320,7 @@ stubPackets.set("console.groupCollapsed('foo')", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "timeStamp": 1477086296567, @@ -1370,8 +1350,7 @@ stubPackets.set("console.groupEnd('foo')", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "timeStamp": 1477086296570, @@ -1399,8 +1378,7 @@ stubPackets.set("console.group()", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "timeStamp": 1477086298462, @@ -1428,8 +1406,7 @@ stubPackets.set("console.groupEnd()", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "timeStamp": 1477086298464, @@ -1460,8 +1437,7 @@ stubPackets.set("console.log(%cfoobar)", { "appId": 0, "firstPartyDomain": "", "inIsolatedMozBrowser": false, - "privateBrowsingId": 0, - "userContextId": 0 + "privateBrowsingId": 0 }, "private": false, "styles": [ diff --git a/devtools/client/webconsole/test/browser_webconsole_bug_630733_response_redirect_headers.js b/devtools/client/webconsole/test/browser_webconsole_bug_630733_response_redirect_headers.js index 509749953..da4bdcf12 100644 --- a/devtools/client/webconsole/test/browser_webconsole_bug_630733_response_redirect_headers.js +++ b/devtools/client/webconsole/test/browser_webconsole_bug_630733_response_redirect_headers.js @@ -87,7 +87,7 @@ function getContent() { function performTest() { function readHeader(name) { for (let header of headers) { - if (header.name == name) { + if (header.name.toLowerCase() == name.toLowerCase()) { return header.value; } } diff --git a/devtools/client/webconsole/test/browser_webconsole_output_02.js b/devtools/client/webconsole/test/browser_webconsole_output_02.js index 4c61cf041..837ec673c 100644 --- a/devtools/client/webconsole/test/browser_webconsole_output_02.js +++ b/devtools/client/webconsole/test/browser_webconsole_output_02.js @@ -24,7 +24,7 @@ var inputTests = [ { input: "(function() { return 42; })", output: "function ()", - printOutput: "function () { return 42; }", + printOutput: "function() { return 42; }", suppressClick: true }, @@ -40,7 +40,7 @@ var inputTests = [ { input: "testobj1.testfn2", output: "function testfn2()", - printOutput: "function () { return 42; }", + printOutput: "function() { return 42; }", suppressClick: true }, diff --git a/devtools/moz.build b/devtools/moz.build index dd9f90c5a..e6bcdd00d 100644 --- a/devtools/moz.build +++ b/devtools/moz.build @@ -13,11 +13,14 @@ if CONFIG['MOZ_DEVTOOLS_SERVER']: 'shared', ] else: - DIRS += ['shared/heapsnapshot/'] + DIRS += [ + 'shared/heapsnapshot', + 'shared/jsinspector', + ] # /browser uses DIST_SUBDIR. We opt-in to this treatment when building # DevTools for the browser to keep the root omni.ja slim for use by external XUL # apps. Mulet also uses this since it includes /browser. -if CONFIG['MOZ_BUILD_APP'] == 'b2g/dev' or CONFIG['MOZ_PHOENIX']: +if CONFIG['MOZ_PHOENIX']: DIST_SUBDIR = 'browser' export('DIST_SUBDIR') diff --git a/devtools/server/actors/moz.build b/devtools/server/actors/moz.build index ddefc3e9e..085d003cf 100644 --- a/devtools/server/actors/moz.build +++ b/devtools/server/actors/moz.build @@ -67,6 +67,6 @@ DevToolsModules( 'worker.js', ) -FINAL_TARGET_PP_FILES.chrome.devtools.modules.devtools.server.actors += [ +FINAL_TARGET_FILES.chrome.devtools.modules.devtools.server.actors += [ 'webbrowser.js', ]
\ No newline at end of file diff --git a/devtools/server/actors/stylesheets.js b/devtools/server/actors/stylesheets.js index 7fcbca8c4..f484a5976 100644 --- a/devtools/server/actors/stylesheets.js +++ b/devtools/server/actors/stylesheets.js @@ -451,21 +451,10 @@ var StyleSheetActor = protocol.ActorClassWithSpec(styleSheetSpec, { let options = { loadFromCache: true, policy: Ci.nsIContentPolicy.TYPE_INTERNAL_STYLESHEET, + window: this.window, charset: this._getCSSCharset() }; - // Bug 1282660 - We use the system principal to load the default internal - // stylesheets instead of the content principal since such stylesheets - // require system principal to load. At meanwhile, we strip the loadGroup - // for preventing the assertion of the userContextId mismatching. - // The default internal stylesheets load from the 'resource:' URL. - // Bug 1287607, 1291321 - 'chrome' and 'file' protocols should also be handled in the - // same way. - if (!/^(chrome|file|resource):\/\//.test(this.href)) { - options.window = this.window; - options.principal = this.document.nodePrincipal; - } - return fetch(this.href, options).then(({ content }) => { this.text = content; return content; diff --git a/devtools/server/actors/webbrowser.js b/devtools/server/actors/webbrowser.js index dffe49b91..e7981e163 100644 --- a/devtools/server/actors/webbrowser.js +++ b/devtools/server/actors/webbrowser.js @@ -30,9 +30,6 @@ loader.lazyRequireGetter(this, "WorkerActorList", "devtools/server/actors/worker loader.lazyRequireGetter(this, "ServiceWorkerRegistrationActorList", "devtools/server/actors/worker", true); loader.lazyRequireGetter(this, "ProcessActorList", "devtools/server/actors/process", true); loader.lazyImporter(this, "AddonManager", "resource://gre/modules/AddonManager.jsm"); -#ifdef MOZ_WEBEXTENSIONS -loader.lazyImporter(this, "ExtensionContent", "resource://gre/modules/ExtensionContent.jsm"); -#endif // Assumptions on events module: // events needs to be dispatched synchronously, @@ -984,21 +981,6 @@ TabActor.prototype = { return null; }, -#ifdef MOZ_WEBEXTENSIONS - /** - * Getter for the WebExtensions ContentScript globals related to the - * current tab content's DOM window. - */ - get webextensionsContentScriptGlobals() { - // Ignore xpcshell runtime which spawn TabActors without a window. - if (this.window) { - return ExtensionContent.getContentScriptGlobalsForWindow(this.window); - } - - return []; - }, -#endif - /** * Getter for the list of all content DOM windows in this tabActor * @return {Array} diff --git a/devtools/server/moz.build b/devtools/server/moz.build index 383505fe2..e4a6d2051 100644 --- a/devtools/server/moz.build +++ b/devtools/server/moz.build @@ -16,18 +16,6 @@ BROWSER_CHROME_MANIFESTS += ['tests/browser/browser.ini'] MOCHITEST_CHROME_MANIFESTS += ['tests/mochitest/chrome.ini'] XPCSHELL_TESTS_MANIFESTS += ['tests/unit/xpcshell.ini'] -XPIDL_SOURCES += [ - 'nsIJSInspector.idl', -] - -XPIDL_MODULE = 'jsinspector' - -SOURCES += [ - 'nsJSInspector.cpp', -] - -FINAL_LIBRARY = 'xul' - DevToolsModules( 'child.js', 'content-globals.js', diff --git a/devtools/server/tests/unit/test_listsources-04.js b/devtools/server/tests/unit/test_listsources-04.js index 6da99a6ce..8e1a57bf0 100644 --- a/devtools/server/tests/unit/test_listsources-04.js +++ b/devtools/server/tests/unit/test_listsources-04.js @@ -29,12 +29,12 @@ function run_test_with_server(server, cb) { addSources(debuggee); threadClient.getSources(Task.async(function* (res) { - do_check_true(res.sources.length === 3, "3 sources exist"); + do_check_eq(res.sources.length, 3, "3 sources exist"); yield threadClient.reconfigure({ useSourceMaps: false }); threadClient.getSources(function(res) { - do_check_true(res.sources.length === 1, "1 source exist"); + do_check_eq(res.sources.length, 1, "1 source exist"); client.close().then(cb); }); })); diff --git a/devtools/shared/heapsnapshot/HeapSnapshot.cpp b/devtools/shared/heapsnapshot/HeapSnapshot.cpp index 17f43f34e..299a96a9c 100644 --- a/devtools/shared/heapsnapshot/HeapSnapshot.cpp +++ b/devtools/shared/heapsnapshot/HeapSnapshot.cpp @@ -28,7 +28,6 @@ #include "mozilla/dom/ContentChild.h" #include "mozilla/dom/HeapSnapshotBinding.h" #include "mozilla/RangedPtr.h" -#include "mozilla/Telemetry.h" #include "mozilla/Unused.h" #include "jsapi.h" @@ -1352,10 +1351,6 @@ class MOZ_STACK_CLASS HeapSnapshotHandler JS::CompartmentSet* compartments; public: - // For telemetry. - uint32_t nodeCount; - uint32_t edgeCount; - HeapSnapshotHandler(CoreDumpWriter& writer, JS::CompartmentSet* compartments) : writer(writer), @@ -1372,8 +1367,6 @@ public: NodeData*, bool first) { - edgeCount++; - // We're only interested in the first time we reach edge.referent, not in // every edge arriving at that node. "But, don't we want to serialize every // edge in the heap graph?" you ask. Don't worry! This edge is still @@ -1387,8 +1380,6 @@ public: if (!ShouldIncludeEdge(compartments, origin, edge, &policy)) return true; - nodeCount++; - if (policy == CoreDumpWriter::EXCLUDE_EDGES) traversal.abandonReferent(); @@ -1403,9 +1394,7 @@ WriteHeapGraph(JSContext* cx, CoreDumpWriter& writer, bool wantNames, JS::CompartmentSet* compartments, - JS::AutoCheckCannotGC& noGC, - uint32_t& outNodeCount, - uint32_t& outEdgeCount) + JS::AutoCheckCannotGC& noGC) { // Serialize the starting node to the core dump. @@ -1425,11 +1414,6 @@ WriteHeapGraph(JSContext* cx, bool ok = traversal.addStartVisited(node) && traversal.traverse(); - if (ok) { - outNodeCount = handler.nodeCount; - outEdgeCount = handler.edgeCount; - } - return ok; } @@ -1563,8 +1547,6 @@ ThreadSafeChromeUtils::SaveHeapSnapshot(GlobalObject& global, bool wantNames = true; CompartmentSet compartments; - uint32_t nodeCount = 0; - uint32_t edgeCount = 0; nsCOMPtr<nsIOutputStream> outputStream = getCoreDumpOutputStream(rv, start, outFilePath); if (NS_WARN_IF(rv.Failed())) @@ -1600,9 +1582,7 @@ ThreadSafeChromeUtils::SaveHeapSnapshot(GlobalObject& global, writer, wantNames, compartments.initialized() ? &compartments : nullptr, - maybeNoGC.ref(), - nodeCount, - edgeCount)) + maybeNoGC.ref())) { rv.Throw(zeroCopyStream.failed() ? zeroCopyStream.result() @@ -1610,13 +1590,6 @@ ThreadSafeChromeUtils::SaveHeapSnapshot(GlobalObject& global, return; } } - - Telemetry::AccumulateTimeDelta(Telemetry::DEVTOOLS_SAVE_HEAP_SNAPSHOT_MS, - start); - Telemetry::Accumulate(Telemetry::DEVTOOLS_HEAP_SNAPSHOT_NODE_COUNT, - nodeCount); - Telemetry::Accumulate(Telemetry::DEVTOOLS_HEAP_SNAPSHOT_EDGE_COUNT, - edgeCount); } /* static */ already_AddRefed<HeapSnapshot> @@ -1624,8 +1597,6 @@ ThreadSafeChromeUtils::ReadHeapSnapshot(GlobalObject& global, const nsAString& filePath, ErrorResult& rv) { - auto start = TimeStamp::Now(); - UniquePtr<char[]> path(ToNewCString(filePath)); if (!path) { rv.Throw(NS_ERROR_OUT_OF_MEMORY); @@ -1641,10 +1612,6 @@ ThreadSafeChromeUtils::ReadHeapSnapshot(GlobalObject& global, global.Context(), global, reinterpret_cast<const uint8_t*>(mm.address()), mm.size(), rv); - if (!rv.Failed()) - Telemetry::AccumulateTimeDelta(Telemetry::DEVTOOLS_READ_HEAP_SNAPSHOT_MS, - start); - return snapshot.forget(); } diff --git a/devtools/shared/heapsnapshot/HeapSnapshot.h b/devtools/shared/heapsnapshot/HeapSnapshot.h index 0428033f6..12dfa4c2b 100644 --- a/devtools/shared/heapsnapshot/HeapSnapshot.h +++ b/devtools/shared/heapsnapshot/HeapSnapshot.h @@ -213,22 +213,7 @@ WriteHeapGraph(JSContext* cx, CoreDumpWriter& writer, bool wantNames, JS::CompartmentSet* compartments, - JS::AutoCheckCannotGC& noGC, - uint32_t& outNodeCount, - uint32_t& outEdgeCount); -inline bool -WriteHeapGraph(JSContext* cx, - const JS::ubi::Node& node, - CoreDumpWriter& writer, - bool wantNames, - JS::CompartmentSet* compartments, - JS::AutoCheckCannotGC& noGC) -{ - uint32_t ignoreNodeCount; - uint32_t ignoreEdgeCount; - return WriteHeapGraph(cx, node, writer, wantNames, compartments, noGC, - ignoreNodeCount, ignoreEdgeCount); -} + JS::AutoCheckCannotGC& noGC); // Get the mozilla::MallocSizeOf for the current thread's JSRuntime. MallocSizeOf GetCurrentThreadDebuggerMallocSizeOf(); diff --git a/devtools/shared/jsinspector/moz.build b/devtools/shared/jsinspector/moz.build new file mode 100644 index 000000000..fc81f7e1e --- /dev/null +++ b/devtools/shared/jsinspector/moz.build @@ -0,0 +1,17 @@ +# -*- Mode: python; indent-tabs-mode: nil; tab-width: 40 -*- +# vim: set filetype=python: +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. + +XPIDL_SOURCES += [ + 'nsIJSInspector.idl', +] + +XPIDL_MODULE = 'jsinspector' + +SOURCES += [ + 'nsJSInspector.cpp', +] + +FINAL_LIBRARY = 'xul' diff --git a/devtools/server/nsIJSInspector.idl b/devtools/shared/jsinspector/nsIJSInspector.idl index 40ad49523..40ad49523 100644 --- a/devtools/server/nsIJSInspector.idl +++ b/devtools/shared/jsinspector/nsIJSInspector.idl diff --git a/devtools/server/nsJSInspector.cpp b/devtools/shared/jsinspector/nsJSInspector.cpp index 6d717af5b..457e64c08 100644 --- a/devtools/server/nsJSInspector.cpp +++ b/devtools/shared/jsinspector/nsJSInspector.cpp @@ -37,7 +37,6 @@ NS_IMPL_CYCLE_COLLECTING_ADDREF(nsJSInspector) NS_IMPL_CYCLE_COLLECTING_RELEASE(nsJSInspector) NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN(nsJSInspector) - NS_IMPL_CYCLE_COLLECTION_TRAVERSE_SCRIPT_OBJECTS NS_IMPL_CYCLE_COLLECTION_TRAVERSE_END NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN(nsJSInspector) diff --git a/devtools/server/nsJSInspector.h b/devtools/shared/jsinspector/nsJSInspector.h index 4e60b0428..4e60b0428 100644 --- a/devtools/server/nsJSInspector.h +++ b/devtools/shared/jsinspector/nsJSInspector.h diff --git a/devtools/shared/moz.build b/devtools/shared/moz.build index e4de1d84a..6c61206dd 100644 --- a/devtools/shared/moz.build +++ b/devtools/shared/moz.build @@ -17,6 +17,7 @@ DIRS += [ 'heapsnapshot', 'inspector', 'jsbeautify', + 'jsinspector', 'layout', 'locales', 'node-properties', diff --git a/devtools/shared/security/socket.js b/devtools/shared/security/socket.js index 068a8ea81..9c6f5750a 100644 --- a/devtools/shared/security/socket.js +++ b/devtools/shared/security/socket.js @@ -480,7 +480,6 @@ SocketListener.prototype = { _setAdditionalSocketOptions: Task.async(function* () { if (this.encryption) { this._socket.serverCert = yield cert.local.getOrCreate(); - this._socket.setSessionCache(false); this._socket.setSessionTickets(false); let requestCert = Ci.nsITLSServerSocket.REQUEST_NEVER; this._socket.setRequestClientCertificate(requestCert); diff --git a/devtools/shared/webconsole/test/test_network_get.html b/devtools/shared/webconsole/test/test_network_get.html index 710c9b0d7..c2313be12 100644 --- a/devtools/shared/webconsole/test/test_network_get.html +++ b/devtools/shared/webconsole/test/test_network_get.html @@ -196,13 +196,13 @@ function onResponseHeaders(aState, aResponse) ok(!!aResponse.rawHeaders, "response rawHeaders available"); checkHeadersOrCookies(aResponse.headers, { - "Content-Type": /^application\/(json|octet-stream)$/, - "Content-Length": /^\d+$/, + "content-type": /^application\/(json|octet-stream)$/, + "content-length": /^\d+$/, }); checkRawHeaders(aResponse.rawHeaders, { - "Content-Type": /^application\/(json|octet-stream)$/, - "Content-Length": /^\d+$/, + "content-type": /^application\/(json|octet-stream)$/, + "content-length": /^\d+$/, }); onResponseCookies = onResponseCookies.bind(null, aState); diff --git a/devtools/shared/webconsole/test/test_network_longstring.html b/devtools/shared/webconsole/test/test_network_longstring.html index d55136896..9e6ea7771 100644 --- a/devtools/shared/webconsole/test/test_network_longstring.html +++ b/devtools/shared/webconsole/test/test_network_longstring.html @@ -212,8 +212,8 @@ function onResponseHeaders(aState, aResponse) ok(aResponse.headersSize > 0, "response headersSize > 0"); checkHeadersOrCookies(aResponse.headers, { - "Content-Type": /^application\/(json|octet-stream)$/, - "Content-Length": /^\d+$/, + "content-type": /^application\/(json|octet-stream)$/, + "content-length": /^\d+$/, "x-very-short": "hello world", "x-very-long": { "type": "longString", diff --git a/devtools/shared/webconsole/test/test_network_post.html b/devtools/shared/webconsole/test/test_network_post.html index d96b9b0b7..a0b8edb64 100644 --- a/devtools/shared/webconsole/test/test_network_post.html +++ b/devtools/shared/webconsole/test/test_network_post.html @@ -204,13 +204,13 @@ function onResponseHeaders(aState, aResponse) ok(!!aResponse.rawHeaders, "response rawHeaders available"); checkHeadersOrCookies(aResponse.headers, { - "Content-Type": /^application\/(json|octet-stream)$/, - "Content-Length": /^\d+$/, + "content-type": /^application\/(json|octet-stream)$/, + "content-length": /^\d+$/, }); checkRawHeaders(aResponse.rawHeaders, { - "Content-Type": /^application\/(json|octet-stream)$/, - "Content-Length": /^\d+$/, + "content-type": /^application\/(json|octet-stream)$/, + "content-length": /^\d+$/, }); onResponseCookies = onResponseCookies.bind(null, aState); |