summaryrefslogtreecommitdiffstats
path: root/build/package/mac_osx/make-diskimage
diff options
context:
space:
mode:
authorwolfbeast <mcwerewolf@wolfbeast.com>2020-03-13 11:28:54 +0100
committerwolfbeast <mcwerewolf@wolfbeast.com>2020-04-14 13:06:11 +0200
commitb45f5c435eff41ac12d234f31432463e87c58bb9 (patch)
treebd10f9c87da9defb040fbd2ef44b2e11489f5e8b /build/package/mac_osx/make-diskimage
parent3c73c0805cfb97689e9ce2419b7fe3625b3bc4a6 (diff)
downloadUXP-b45f5c435eff41ac12d234f31432463e87c58bb9.tar
UXP-b45f5c435eff41ac12d234f31432463e87c58bb9.tar.gz
UXP-b45f5c435eff41ac12d234f31432463e87c58bb9.tar.lz
UXP-b45f5c435eff41ac12d234f31432463e87c58bb9.tar.xz
UXP-b45f5c435eff41ac12d234f31432463e87c58bb9.zip
Issue #1485 - Fix incorrect grid cell sizing to min/max space.
There were actually two separate logical errors in this method: The first part is that "origSizes.isSome()" is simply a bogus requirement for applying min/max-sizes here. I'm still keeping the optimization of not needlessly copying the mSizes array (as originally intended) since it's a quite common case. The second bug is that min/max-sizes were only applied under the "if (fr != 0.0f)" block. This is bogus since the calculated 'fr' value depends on 'aAvailableSize' which might change by applying min/max-sizes and thus 'fr' could become non-zero in the second round. To fix, this patch just moves "applyMinMax" block out one level.
Diffstat (limited to 'build/package/mac_osx/make-diskimage')
0 files changed, 0 insertions, 0 deletions