summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMoonchild <moonchild@palemoon.org>2019-07-19 15:48:48 +0200
committerGitHub <noreply@github.com>2019-07-19 15:48:48 +0200
commitd2cfd332ac04f630ab1eb93b71f78a0474f43b88 (patch)
tree5095b969cd58fce7b5894af3ad395cd8878ff204
parent4a84afdc892dcc3a1732b45e5ac65812daa53fae (diff)
downloadUXP-d2cfd332ac04f630ab1eb93b71f78a0474f43b88.tar
UXP-d2cfd332ac04f630ab1eb93b71f78a0474f43b88.tar.gz
UXP-d2cfd332ac04f630ab1eb93b71f78a0474f43b88.tar.lz
UXP-d2cfd332ac04f630ab1eb93b71f78a0474f43b88.tar.xz
UXP-d2cfd332ac04f630ab1eb93b71f78a0474f43b88.zip
Fix order of OwnProperty check for rest parameters.
This was a small mistake when converting from the `hasOwn()` function format (swapped parameters). Fixing this properly makes rest parameters exclude the parameters that are defined (which is the whole point of `...rest`
-rw-r--r--js/src/builtin/Utilities.js2
1 files changed, 1 insertions, 1 deletions
diff --git a/js/src/builtin/Utilities.js b/js/src/builtin/Utilities.js
index ec5c88336..d5f233d05 100644
--- a/js/src/builtin/Utilities.js
+++ b/js/src/builtin/Utilities.js
@@ -254,7 +254,7 @@ function CopyDataProperties(target, source, excluded) {
// We abbreviate this by calling propertyIsEnumerable which is faster
// and returns false for not defined properties.
- if (!callFunction(std_Object_hasOwnProperty, key, excluded) && callFunction(std_Object_propertyIsEnumerable, source, key))
+ if (!callFunction(std_Object_hasOwnProperty, excluded, key) && callFunction(std_Object_propertyIsEnumerable, source, key))
_DefineDataProperty(target, key, source[key]);
}