diff options
| author | Moonchild <mcwerewolf@gmail.com> | 2018-05-01 09:55:55 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-05-01 09:55:55 +0200 |
| commit | d0c19e4607964c04109e12399e98e86b331edd0f (patch) | |
| tree | 4fa8d617c40af1a80e82c79b635bb4d725059146 | |
| parent | 0913ffa0cdee200fd30055bbfc1054c639c7866c (diff) | |
| parent | 83e6cb541070f5ac9b31a1b6d146c0992c44c81e (diff) | |
| download | UXP-d0c19e4607964c04109e12399e98e86b331edd0f.tar UXP-d0c19e4607964c04109e12399e98e86b331edd0f.tar.gz UXP-d0c19e4607964c04109e12399e98e86b331edd0f.tar.lz UXP-d0c19e4607964c04109e12399e98e86b331edd0f.tar.xz UXP-d0c19e4607964c04109e12399e98e86b331edd0f.zip | |
Merge pull request #309 from janekptacijarabaci/build_warnings_4
Build - throws a warning "interface 'nsISelectionPrivate' is scriptable but derives from non-scriptable 'nsISelection'"
| -rw-r--r-- | dom/base/nsISelectionPrivate.idl | 2 | ||||
| -rw-r--r-- | layout/generic/Selection.h | 5 | ||||
| -rwxr-xr-x | xpcom/idl-parser/xpidl/xpidl.py | 2 |
3 files changed, 5 insertions, 4 deletions
diff --git a/dom/base/nsISelectionPrivate.idl b/dom/base/nsISelectionPrivate.idl index 68412885e..049873b28 100644 --- a/dom/base/nsISelectionPrivate.idl +++ b/dom/base/nsISelectionPrivate.idl @@ -29,7 +29,7 @@ native nsDirection(nsDirection); native ScrollAxis(nsIPresShell::ScrollAxis); [scriptable, builtinclass, uuid(0c9f4f74-ee7e-4fe9-be6b-0ba856368178)] -interface nsISelectionPrivate : nsISelection +interface nsISelectionPrivate : nsISupports { const short ENDOFPRECEDINGLINE=0; const short STARTOFNEXTLINE=1; diff --git a/layout/generic/Selection.h b/layout/generic/Selection.h index 3d5e334fc..5414d15c1 100644 --- a/layout/generic/Selection.h +++ b/layout/generic/Selection.h @@ -51,8 +51,9 @@ struct RangeData namespace mozilla { namespace dom { -class Selection final : public nsISelectionPrivate, +class Selection final : public nsISelection, public nsWrapperCache, + public nsISelectionPrivate, public nsSupportsWeakReference { protected: @@ -63,7 +64,7 @@ public: explicit Selection(nsFrameSelection *aList); NS_DECL_CYCLE_COLLECTING_ISUPPORTS - NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS_AMBIGUOUS(Selection, nsISelectionPrivate) + NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS_AMBIGUOUS(Selection, nsISelection) NS_DECL_NSISELECTION NS_DECL_NSISELECTIONPRIVATE diff --git a/xpcom/idl-parser/xpidl/xpidl.py b/xpcom/idl-parser/xpidl/xpidl.py index 8b2d8c884..6bb1ad5de 100755 --- a/xpcom/idl-parser/xpidl/xpidl.py +++ b/xpcom/idl-parser/xpidl/xpidl.py @@ -529,7 +529,7 @@ class Interface(object): raise IDLError("interface '%s' inherits from non-interface type '%s'" % (self.name, self.base), self.location) if self.attributes.scriptable and not realbase.attributes.scriptable: - print >>sys.stderr, IDLError("interface '%s' is scriptable but derives from non-scriptable '%s'" % (self.name, self.base), self.location, warning=True) + raise IDLError("interface '%s' is scriptable but derives from non-scriptable '%s'" % (self.name, self.base), self.location, warning=True) if self.attributes.scriptable and realbase.attributes.builtinclass and not self.attributes.builtinclass: raise IDLError("interface '%s' is not builtinclass but derives from builtinclass '%s'" % (self.name, self.base), self.location) |